Changeset 277331 in webkit

Timestamp:

May 11, 2021, 11:00:26 AM (5 years ago)

Author:

Brent Fulgham

Message:

[macOS] Extend access to 'com.apple.print.normalizerd' when canvas drawing is done in the WebContent process
​https://bugs.webkit.org/show_bug.cgi?id=225623
<rdar://problem/77354349>

Reviewed by Per Arne Vollan.

We need to dynamically extend access to 'com.apple.print.normalizerd' when the GPU Process is not handling canvas drawing.
WebKit needs this access to properly draw EPS images.

Tested by fast/images/eps-as-image.html

• UIProcess/WebPageProxy.cpp:

(WebKit::gpuMachServices): Add 'com.apple.print.normalizerd' to set of required services.

• WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in: Remove 'com.apple.print.normalizerd' since it is

not possible to use from the Web Authentication process.

• WebProcess/com.apple.WebProcess.sb.in: Expect the extension to be dynamically extended on all releases.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)
• WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in (modified) (1 diff)
• WebProcess/com.apple.WebProcess.sb.in (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-05-11  Brent Fulgham  <bfulgham@apple.com>
+
+        [macOS] Extend access to 'com.apple.print.normalizerd' when canvas drawing is done in the WebContent process
+        https://bugs.webkit.org/show_bug.cgi?id=225623
+        <rdar://problem/77354349>
+
+        Reviewed by Per Arne Vollan.
+
+        We need to dynamically extend access to 'com.apple.print.normalizerd' when the GPU Process is not handling canvas drawing.
+        WebKit needs this access to properly draw EPS images.
+
+        Tested by fast/images/eps-as-image.html
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::gpuMachServices): Add 'com.apple.print.normalizerd' to set of required services.
+        * WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in: Remove 'com.apple.print.normalizerd' since it is
+        not possible to use from the Web Authentication process.
+        * WebProcess/com.apple.WebProcess.sb.in: Expect the extension to be dynamically extended on all releases.
+
 2021-05-11  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -7829 +7829 @@
 #if PLATFORM(MAC) || PLATFORM(MACCATALYST)
         "com.apple.cvmsServ"_s,
+        "com.apple.print.normalizerd"_s,
 #endif
     });

trunk/Source/WebKit/WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in

@@ -152 +152 @@
     (xpc-service-name "com.apple.coremedia.videoencoder")
     (xpc-service-name "com.apple.hiservices-xpcservice")
-    (xpc-service-name "com.apple.print.normalizerd")
 )
 

trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in

@@ -867 +867 @@
 (allow mach-lookup
     (xpc-service-name "com.apple.audio.SandboxHelper")
-    (xpc-service-name "com.apple.print.normalizerd")
 )
 #endif
@@ -1761 +1760 @@
             "com.apple.coremedia.videodecoder"
             "com.apple.coremedia.videoencoder"
+            "com.apple.print.normalizerd" ;; <rdar://problem/77354349>
             ;;; FIXME(207716): End services to remove.
         )