Changeset 277338 in webkit

Timestamp:

May 11, 2021, 1:45:18 PM (5 years ago)

Author:

Ben Nham

Message:

Failing sandbox check for media permissions should not generate a violation report
​https://bugs.webkit.org/show_bug.cgi?id=225662

Reviewed by Geoffrey Garen.

We sandbox_check the UIProcess for camera and video permissions. But if the process doesn't
have those permissions, sandbox_check fails and generates an expensive violation report that
task_suspends the process. We need to suppress the reporting with SANDBOX_CHECK_NO_REPORT.

• UIProcess/Cocoa/MediaPermissionUtilities.mm:

(WebKit::checkSandboxRequirementForType):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Cocoa/MediaPermissionUtilities.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-05-11  Ben Nham  <nham@apple.com>
+
+        Failing sandbox check for media permissions should not generate a violation report
+        https://bugs.webkit.org/show_bug.cgi?id=225662
+
+        Reviewed by Geoffrey Garen.
+
+        We sandbox_check the UIProcess for camera and video permissions. But if the process doesn't
+        have those permissions, sandbox_check fails and generates an expensive violation report that
+        task_suspends the process. We need to suppress the reporting with SANDBOX_CHECK_NO_REPORT.
+
+        * UIProcess/Cocoa/MediaPermissionUtilities.mm:
+        (WebKit::checkSandboxRequirementForType):
+
 2021-05-11  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/UIProcess/Cocoa/MediaPermissionUtilities.mm

@@ -62 +62 @@
             return;
 
-        int result = sandbox_check(getpid(), operation, SANDBOX_FILTER_NONE);
+        int result = sandbox_check(getpid(), operation, static_cast<enum sandbox_filter_type>(SANDBOX_CHECK_NO_REPORT | SANDBOX_FILTER_NONE));
         if (result == -1)
             WTFLogAlways("Error checking '%s' sandbox access, errno=%ld", operation, (long)errno);