Changeset 277347 in webkit

Timestamp:

May 11, 2021, 5:54:26 PM (5 years ago)

Author:

ggaren@apple.com

Message:

Function.prototype.toString triggers page demand on Speedometer
​https://bugs.webkit.org/show_bug.cgi?id=225678

Reviewed by Mark Lam.

Some JS libraries -- e.g. jQuery, Ember-Debug, Angular -- like to
toString() JS functions in order to enforce return type, argument type,
or deprecation invariants. This triggers pathological page demand if
we keep throwing away the underlying script string.

• loader/cache/CachedResource.cpp:

(WebCore::deadDecodedDataDeletionIntervalForResourceType): Let's try 5s.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/cache/CachedResource.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-05-11  Geoffrey Garen  <ggaren@apple.com>
+
+        Function.prototype.toString triggers page demand on Speedometer
+        https://bugs.webkit.org/show_bug.cgi?id=225678
+
+        Reviewed by Mark Lam.
+
+        Some JS libraries -- e.g. jQuery, Ember-Debug, Angular -- like to
+        toString() JS functions in order to enforce return type, argument type,
+        or deprecation invariants. This triggers pathological page demand if
+        we keep throwing away the underlying script string.
+
+        * loader/cache/CachedResource.cpp:
+        (WebCore::deadDecodedDataDeletionIntervalForResourceType): Let's try 5s.
+
 2021-05-11  Toshio Ogasawara  <toshio.ogasawara@access-company.com>
 

trunk/Source/WebCore/loader/cache/CachedResource.cpp

@@ -79 +79 @@
 {
     if (type == CachedResource::Type::Script)
-        return 0_s;
+        return 5_s;
 
     return MemoryCache::singleton().deadDecodedDataDeletionInterval();