Changeset 277359 in webkit

Timestamp:

May 12, 2021, 12:54:27 AM (5 years ago)

Author:

youenn@apple.com

Message:

fast/mediastream/getUserMedia-webaudio.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=225655
<rdar://74158395>

Reviewed by Eric Carlson.

• fast/mediastream/getUserMedia-webaudio.html:

Retry several time instead of just once when detecting no noise to improve robustness.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/mediastream/getUserMedia-webaudio.html (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-05-12  Youenn Fablet  <youenn@apple.com>
+
+        fast/mediastream/getUserMedia-webaudio.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=225655
+        <rdar://74158395>
+
+        Reviewed by Eric Carlson.
+
+        * fast/mediastream/getUserMedia-webaudio.html:
+        Retry several time instead of just once when detecting no noise to improve robustness.
+
 2021-05-11  Cameron McCormack  <heycam@apple.com>
 

trunk/LayoutTests/fast/mediastream/getUserMedia-webaudio.html

@@ -88 +88 @@
 
 var context;
-async function checkForNoise(stream, counter)
+async function checkForNoise(stream, expectedHeardNoise, counter)
 {
     if (!counter)
@@ -95 +95 @@
         return Promise.resolve(false);
     results = await analyseAudio(stream, 100, context);
-    if (results.heardNoise)
+    if (results.heardNoise == expectedHeardNoise)
         return Promise.resolve(true);
-    var results = await checkForNoise(stream, counter);
+    var results = await checkForNoise(stream, expectedHeardNoise, counter);
     return results;
 }
@@ -103 +103 @@
 promise_test(async (test) => {
     context = new AudioContext();
-    if (window.testRunner)
-        testRunner.setUserMediaPermission(true);
 
     let stream = await navigator.mediaDevices.getUserMedia({audio: { echoCancellation : true}});
     assert_true(stream.getAudioTracks()[0].getSettings().echoCancellation);
-    const results = await analyseAudio(stream, 100, context);
-    assert_false(results.heardNoise, "should not hear noise");
+    assert_true(await checkForNoise(stream, false), "should not hear noise");
 
     stream = await navigator.mediaDevices.getUserMedia({audio: { echoCancellation : false}});
     assert_false(stream.getAudioTracks()[0].getSettings().echoCancellation, "settings is ok");
-    const heardNoise = await checkForNoise(stream);
-    assert_true(heardNoise, "heard noise");
+    assert_true(await checkForNoise(stream, true), "heard noise");
 
     context.close();