Changeset 277362 in webkit

Timestamp:

May 12, 2021, 1:09:06 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION(r277083): Proximity scroll snap is broken on iOS
​https://bugs.webkit.org/show_bug.cgi?id=225649

Patch by Martin Robinson <​mrobinson@igalia.com> on 2021-05-12
Reviewed by Simon Fraser.

No new tests. iOS does not have great support for the event sending test
infrastructure used to test scroll snap.

• Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:

(ArgumentCoder<FloatScrollSnapOffsetsInfo>::encode): Include the snap type when encoding ScrollSnapOffsetsInfo.
(ArgumentCoder<FloatScrollSnapOffsetsInfo>::decode): Include the snap type when decoding ScrollSnapOffsetsInfo.

• Shared/WebCoreArgumentCoders.h: Added EnumTraits for ScrollSnapStrictness.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp (modified) (2 diffs)
• Shared/WebCoreArgumentCoders.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-05-12  Martin Robinson  <mrobinson@igalia.com>
+
+        REGRESSION(r277083): Proximity scroll snap is broken on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=225649
+
+        Reviewed by Simon Fraser.
+
+        No new tests. iOS does not have great support for the event sending test
+        infrastructure used to test scroll snap.
+
+        * Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
+        (ArgumentCoder<FloatScrollSnapOffsetsInfo>::encode): Include the snap type when encoding ScrollSnapOffsetsInfo.
+        (ArgumentCoder<FloatScrollSnapOffsetsInfo>::decode): Include the snap type when decoding ScrollSnapOffsetsInfo.
+        * Shared/WebCoreArgumentCoders.h: Added EnumTraits for ScrollSnapStrictness.
+
 2021-05-11  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp

@@ -551 +551 @@
     encoder << info.horizontalSnapOffsets;
     encoder << info.verticalSnapOffsets;
+    encoder << info.strictness;
     encoder << info.snapAreas;
 }
@@ -559 +560 @@
         return false;
     if (!decoder.decode(info.verticalSnapOffsets))
+        return false;
+    if (!decoder.decode(info.strictness))
         return false;
     if (!decoder.decode(info.snapAreas))

trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h

@@ -1013 +1013 @@
 #endif
 
+template<> struct EnumTraits<WebCore::ScrollSnapStrictness> {
+    using values = EnumValues<
+        WebCore::ScrollSnapStrictness,
+        WebCore::ScrollSnapStrictness::None,
+        WebCore::ScrollSnapStrictness::Proximity,
+        WebCore::ScrollSnapStrictness::Mandatory
+    >;
+};
+
 } // namespace WTF