Changeset 277372 in webkit

Timestamp:

May 12, 2021, 9:59:44 AM (5 years ago)

Author:

Peng Liu

Message:

Implement TextTrackPrivateRemote::inBandMetadataTrackDispatchType()
​https://bugs.webkit.org/show_bug.cgi?id=225674

Reviewed by Eric Carlson.

Source/WebCore:

Remove an unused function in InbandTextTrackPrivate.

• platform/graphics/InbandTextTrackPrivate.h:

(WebCore::InbandTextTrackPrivate::textTrackIndex const): Deleted.

Source/WebKit:

This patch ensures that InbandTextTrack::inBandMetadataTrackDispatchType()
behaviors the same no matter "Media in GPU Process" is enabled or not.

• GPUProcess/media/RemoteTextTrackProxy.cpp:

(WebKit::RemoteTextTrackProxy::configuration):

• WebProcess/GPU/media/TextTrackPrivateRemote.cpp:

(WebKit::TextTrackPrivateRemote::updateConfiguration):

• WebProcess/GPU/media/TextTrackPrivateRemote.h:

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/InbandTextTrackPrivate.h (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/GPUProcess/media/RemoteTextTrackProxy.cpp (modified) (1 diff)
• WebKit/WebProcess/GPU/media/TextTrackPrivateRemote.cpp (modified) (1 diff)
• WebKit/WebProcess/GPU/media/TextTrackPrivateRemote.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-05-12  Peng Liu  <peng.liu6@apple.com>
+
+        Implement TextTrackPrivateRemote::inBandMetadataTrackDispatchType()
+        https://bugs.webkit.org/show_bug.cgi?id=225674
+
+        Reviewed by Eric Carlson.
+
+        Remove an unused function in `InbandTextTrackPrivate`.
+
+        * platform/graphics/InbandTextTrackPrivate.h:
+        (WebCore::InbandTextTrackPrivate::textTrackIndex const): Deleted.
+
 2021-05-12  Sergio Villar Senin  <svillar@igalia.com>
 

trunk/Source/WebCore/platform/graphics/InbandTextTrackPrivate.h

@@ -75 +75 @@
     virtual AtomString inBandMetadataTrackDispatchType() const { return emptyAtom(); }
 
-    virtual int textTrackIndex() const { return 0; }
-
     virtual CueFormat cueFormat() const { return m_format; }
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-05-12  Peng Liu  <peng.liu6@apple.com>
+
+        Implement TextTrackPrivateRemote::inBandMetadataTrackDispatchType()
+        https://bugs.webkit.org/show_bug.cgi?id=225674
+
+        Reviewed by Eric Carlson.
+
+        This patch ensures that `InbandTextTrack::inBandMetadataTrackDispatchType()`
+        behaviors the same no matter "Media in GPU Process" is enabled or not.
+
+        * GPUProcess/media/RemoteTextTrackProxy.cpp:
+        (WebKit::RemoteTextTrackProxy::configuration):
+        * WebProcess/GPU/media/TextTrackPrivateRemote.cpp:
+        (WebKit::TextTrackPrivateRemote::updateConfiguration):
+        * WebProcess/GPU/media/TextTrackPrivateRemote.h:
+
 2021-05-12  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/GPUProcess/media/RemoteTextTrackProxy.cpp

@@ -66 +66 @@
     configuration->language = m_trackPrivate->language();
     configuration->trackIndex = m_trackPrivate->trackIndex();
+    configuration->inBandMetadataTrackDispatchType = m_trackPrivate->inBandMetadataTrackDispatchType();
     configuration->startTimeVariance = m_trackPrivate->startTimeVariance();
 

trunk/Source/WebKit/WebProcess/GPU/media/TextTrackPrivateRemote.cpp

@@ -82 +82 @@
 
     m_trackIndex = configuration.trackIndex;
+    m_inBandMetadataTrackDispatchType = configuration.inBandMetadataTrackDispatchType;
     m_startTimeVariance = configuration.startTimeVariance;
 

trunk/Source/WebKit/WebProcess/GPU/media/TextTrackPrivateRemote.h

@@ -79 +79 @@
     AtomString language() const final { return m_language; }
     int trackIndex() const final { return m_trackIndex; }
+    AtomString inBandMetadataTrackDispatchType() const final { return m_inBandMetadataTrackDispatchType; }
 
     using TextTrackCueFormat = WebCore::InbandTextTrackPrivate::CueFormat;
@@ -105 +106 @@
     AtomString m_language;
     int m_trackIndex { -1 };
+    AtomString m_inBandMetadataTrackDispatchType;
     MediaTime m_startTimeVariance { MediaTime::zeroTime() };
     WebCore::MediaPlayerIdentifier m_playerIdentifier;