Changeset 277380 in webkit

Timestamp:

May 12, 2021, 11:28:25 AM (5 years ago)

Author:

Chris Dumez

Message:

Unreviewed follow-up to r277376.

Fix bad early return in NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision().

• WebProcess/Notifications/NotificationPermissionRequestManager.cpp:

(WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/Notifications/NotificationPermissionRequestManager.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-05-12  Chris Dumez  <cdumez@apple.com>
+
+        Unreviewed follow-up to r277376.
+
+        Fix bad early return in NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision().
+
+        * WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
+        (WebKit::NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision):
+
 2021-05-12  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/WebProcess/Notifications/NotificationPermissionRequestManager.cpp

@@ -135 +135 @@
     auto callbacks = m_requestsPerOrigin.take(origin);
     for (auto& callback : callbacks) {
-        if (!callback)
-            return;
-        callback->handleEvent(allowed ? NotificationClient::Permission::Granted : NotificationClient::Permission::Denied);
+        if (callback)
+            callback->handleEvent(allowed ? NotificationClient::Permission::Granted : NotificationClient::Permission::Denied);
     }
 #else