⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 277384 in webkit


Ignore:
Timestamp:
May 12, 2021, 1:11:20 PM (5 years ago)
Author:
weinig@apple.com
Message:

Remove inline annoatations for static functions in PixelBufferConversion
​https://bugs.webkit.org/show_bug.cgi?id=225708

Reviewed by Darin Adler.

Remove inline annoatations for static functions in PixelBufferConversion
as suggested by Darin. The theory here is that outside of a header, the
use of 'inline' serves no purpose as the compiler is perfectly allowed
and capable of inlining these functions.

  • platform/graphics/PixelBufferConversion.cpp:

(WebCore::makeVImageBuffer):
(WebCore::convertImagePixelsAccelerated):
(WebCore::convertSinglePixelPremultipliedToPremultiplied):
(WebCore::convertSinglePixelPremultipliedToUnpremultiplied):
(WebCore::convertSinglePixelUnpremultipliedToPremultiplied):
(WebCore::convertSinglePixelUnpremultipliedToUnpremultiplied):
(WebCore::convertFunctor):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r277382 r277384  
     12021-05-12  Sam Weinig  <weinig@apple.com>
     2
     3        Remove inline annoatations for static functions in PixelBufferConversion
     4        https://bugs.webkit.org/show_bug.cgi?id=225708
     5
     6        Reviewed by Darin Adler.
     7
     8        Remove inline annoatations for static functions in PixelBufferConversion
     9        as suggested by Darin. The theory here is that outside of a header, the
     10        use of 'inline' serves no purpose as the compiler is perfectly allowed
     11        and capable of inlining these functions.
     12
     13        * platform/graphics/PixelBufferConversion.cpp:
     14        (WebCore::makeVImageBuffer):
     15        (WebCore::convertImagePixelsAccelerated):
     16        (WebCore::convertSinglePixelPremultipliedToPremultiplied):
     17        (WebCore::convertSinglePixelPremultipliedToUnpremultiplied):
     18        (WebCore::convertSinglePixelUnpremultipliedToPremultiplied):
     19        (WebCore::convertSinglePixelUnpremultipliedToUnpremultiplied):
     20        (WebCore::convertFunctor):
     21
    1222021-05-12  Alex Christensen  <achristensen@webkit.org>
    223

  • trunk/Source/WebCore/platform/graphics/PixelBufferConversion.cpp

    r277369 r277384  
    4040#if USE(ACCELERATE)
    4141
    42 template<typename View> static inline vImage_Buffer makeVImageBuffer(const View& view, const IntSize& size)
     42template<typename View> static vImage_Buffer makeVImageBuffer(const View& view, const IntSize& size)
    4343{
    4444    vImage_Buffer vImageBuffer;
    … …  
    5252}
    5353
    54 static inline void convertImagePixelsAccelerated(const ConstPixelBufferConversionView& source, const PixelBufferConversionView& destination, const IntSize& destinationSize)
     54static void convertImagePixelsAccelerated(const ConstPixelBufferConversionView& source, const PixelBufferConversionView& destination, const IntSize& destinationSize)
    5555{
    5656    auto sourceVImageBuffer = makeVImageBuffer(source, destinationSize);
    … …  
    7979    }
    8080}
     81
    8182#endif
    8283
    … …  
    8485
    8586template<PixelFormatConversion pixelFormatConversion>
    86 static inline void convertSinglePixelPremultipliedToPremultiplied(const uint8_t* sourcePixel, uint8_t* destinationPixel)
     87static void convertSinglePixelPremultipliedToPremultiplied(const uint8_t* sourcePixel, uint8_t* destinationPixel)
    8788{
    8889    uint8_t alpha = sourcePixel[3];
    … …  
    104105
    105106template<PixelFormatConversion pixelFormatConversion>
    106 static inline void convertSinglePixelPremultipliedToUnpremultiplied(const uint8_t* sourcePixel, uint8_t* destinationPixel)
     107static void convertSinglePixelPremultipliedToUnpremultiplied(const uint8_t* sourcePixel, uint8_t* destinationPixel)
    107108{
    108109    uint8_t alpha = sourcePixel[3];
    … …  
    127128
    128129template<PixelFormatConversion pixelFormatConversion>
    129 static inline void convertSinglePixelUnpremultipliedToPremultiplied(const uint8_t* sourcePixel, uint8_t* destinationPixel)
     130static void convertSinglePixelUnpremultipliedToPremultiplied(const uint8_t* sourcePixel, uint8_t* destinationPixel)
    130131{
    131132    uint8_t alpha = sourcePixel[3];
    … …  
    150151
    151152template<PixelFormatConversion pixelFormatConversion>
    152 static inline void convertSinglePixelUnpremultipliedToUnpremultiplied(const uint8_t* sourcePixel, uint8_t* destinationPixel)
     153static void convertSinglePixelUnpremultipliedToUnpremultiplied(const uint8_t* sourcePixel, uint8_t* destinationPixel)
    153154{
    154155    if constexpr (pixelFormatConversion == PixelFormatConversion::None)
    … …  
    164165
    165166template<void (*convertFunctor)(const uint8_t*, uint8_t*)>
    166 static inline void convertImagePixelsUnaccelerated(const ConstPixelBufferConversionView& source, const PixelBufferConversionView& destination, const IntSize& destinationSize)
     167static void convertImagePixelsUnaccelerated(const ConstPixelBufferConversionView& source, const PixelBufferConversionView& destination, const IntSize& destinationSize)
    167168{
    168169    const uint8_t* sourceRows = source.rows;
Note: See TracChangeset for help on using the changeset viewer.