Changeset 277385 in webkit

Timestamp:

May 12, 2021, 1:13:55 PM (5 years ago)

Author:

Said Abou-Hallawa

Message:

Removing the transform CSS property from the SVG element does not cause invalidation
​https://bugs.webkit.org/show_bug.cgi?id=225366

Reviewed by Simon Fraser.

Source/WebCore:

If the new or the old RenderStyle includes a transform, the renderer of
the SVG element needs to be repainted.

Test: svg/css/svg-css-transform-dynamic-remove.html

• rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::styleDidChange):

LayoutTests:

• svg/css/svg-css-transform-dynamic-remove-expected.html: Added.
• svg/css/svg-css-transform-dynamic-remove.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/css/svg-css-transform-dynamic-remove-expected.html (added)
• LayoutTests/svg/css/svg-css-transform-dynamic-remove.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/svg/RenderSVGModelObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-05-12  Said Abou-Hallawa  <said@apple.com>
+
+        Removing the transform CSS property from the SVG element does not cause invalidation
+        https://bugs.webkit.org/show_bug.cgi?id=225366
+
+        Reviewed by Simon Fraser.
+
+        * svg/css/svg-css-transform-dynamic-remove-expected.html: Added.
+        * svg/css/svg-css-transform-dynamic-remove.html: Added.
+
 2021-05-12  Sergio Villar Senin  <svillar@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-05-12  Said Abou-Hallawa  <said@apple.com>
+
+        Removing the transform CSS property from the SVG element does not cause invalidation
+        https://bugs.webkit.org/show_bug.cgi?id=225366
+
+        Reviewed by Simon Fraser.
+
+        If the new or the old RenderStyle includes a transform, the renderer of
+        the SVG element needs to be repainted.
+
+        Test: svg/css/svg-css-transform-dynamic-remove.html
+
+        * rendering/svg/RenderSVGModelObject.cpp:
+        (WebCore::RenderSVGModelObject::styleDidChange):
+
 2021-05-12  Sam Weinig  <weinig@apple.com>
 

trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp

@@ -102 +102 @@
     if (diff == StyleDifference::Layout) {
         setNeedsBoundariesUpdate();
-        if (style().hasTransform())
+        if (style().hasTransform() || (oldStyle && oldStyle->hasTransform()))
             setNeedsTransformUpdate();
     }