⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 277414 in webkit


Ignore:
Timestamp:
May 12, 2021, 5:31:44 PM (5 years ago)
Author:
Chris Dumez
Message:

Simplify / Modernize Notification permission implementation
​https://bugs.webkit.org/show_bug.cgi?id=225711

Reviewed by Alex Christensen.

Simplify / Modernize Notification permission implementation. The main change was
adopting sendWithAsyncReply() for the IPC instead of using 2 separate IPC messages
for the request and the decision. As a result, we don't have to deal with request
identifiers.

No new tests, no behavior change and covered by existing API tests.

  • Sources.txt:
  • UIProcess/API/APIUIClient.h:

(API::UIClient::decidePolicyForNotificationPermissionRequest):

  • UIProcess/API/C/WKNotificationPermissionRequest.cpp:

(WKNotificationPermissionRequestAllow):
(WKNotificationPermissionRequestDeny):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/API/glib/WebKitNotificationPermissionRequest.cpp:

(webkitNotificationPermissionRequestAllow):
(webkitNotificationPermissionRequestDeny):

  • UIProcess/API/glib/WebKitUIClient.cpp:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::decidePolicyForNotificationPermissionRequest):

  • UIProcess/Notifications/NotificationPermissionRequest.h:

(WebKit::NotificationPermissionRequest::create):
(WebKit::NotificationPermissionRequest::~NotificationPermissionRequest):
(WebKit::NotificationPermissionRequest::didReceiveDecision):
(WebKit::NotificationPermissionRequest::NotificationPermissionRequest):

  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp: Removed.
  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h: Removed.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetState):
(WebKit::WebPageProxy::requestNotificationPermission):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/Notifications/NotificationPermissionRequestManager.cpp:

(WebKit::NotificationPermissionRequestManager::startRequest):

  • WebProcess/Notifications/NotificationPermissionRequestManager.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
Location:
trunk/Source/WebKit
Files:
2 deleted
19 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r277413 r277414  
     12021-05-12  Chris Dumez  <cdumez@apple.com>
     2
     3        Simplify / Modernize Notification permission implementation
     4        https://bugs.webkit.org/show_bug.cgi?id=225711
     5
     6        Reviewed by Alex Christensen.
     7
     8        Simplify / Modernize Notification permission implementation. The main change was
     9        adopting sendWithAsyncReply() for the IPC instead of using 2 separate IPC messages
     10        for the request and the decision. As a result, we don't have to deal with request
     11        identifiers.
     12
     13        No new tests, no behavior change and covered by existing API tests.
     14
     15        * Sources.txt:
     16        * UIProcess/API/APIUIClient.h:
     17        (API::UIClient::decidePolicyForNotificationPermissionRequest):
     18        * UIProcess/API/C/WKNotificationPermissionRequest.cpp:
     19        (WKNotificationPermissionRequestAllow):
     20        (WKNotificationPermissionRequestDeny):
     21        * UIProcess/API/C/WKPage.cpp:
     22        (WKPageSetPageUIClient):
     23        * UIProcess/API/glib/WebKitNotificationPermissionRequest.cpp:
     24        (webkitNotificationPermissionRequestAllow):
     25        (webkitNotificationPermissionRequestDeny):
     26        * UIProcess/API/glib/WebKitUIClient.cpp:
     27        * UIProcess/Cocoa/UIDelegate.h:
     28        * UIProcess/Cocoa/UIDelegate.mm:
     29        (WebKit::UIDelegate::UIClient::decidePolicyForNotificationPermissionRequest):
     30        * UIProcess/Notifications/NotificationPermissionRequest.h:
     31        (WebKit::NotificationPermissionRequest::create):
     32        (WebKit::NotificationPermissionRequest::~NotificationPermissionRequest):
     33        (WebKit::NotificationPermissionRequest::didReceiveDecision):
     34        (WebKit::NotificationPermissionRequest::NotificationPermissionRequest):
     35        * UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp: Removed.
     36        * UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h: Removed.
     37        * UIProcess/WebPageProxy.cpp:
     38        (WebKit::WebPageProxy::resetState):
     39        (WebKit::WebPageProxy::requestNotificationPermission):
     40        * UIProcess/WebPageProxy.h:
     41        * UIProcess/WebPageProxy.messages.in:
     42        * WebKit.xcodeproj/project.pbxproj:
     43        * WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
     44        (WebKit::NotificationPermissionRequestManager::startRequest):
     45        * WebProcess/Notifications/NotificationPermissionRequestManager.h:
     46        * WebProcess/WebPage/WebPage.cpp:
     47        * WebProcess/WebPage/WebPage.h:
     48        * WebProcess/WebPage/WebPage.messages.in:
     49
    1502021-05-12  Ada Chan  <ada.chan@apple.com>
    251

  • trunk/Source/WebKit/Sources.txt

    r277264 r277414  
    470470UIProcess/Media/RemoteMediaSessionCoordinatorProxy.cpp
    471471
    472 UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp
    473472UIProcess/Notifications/WebNotification.cpp
    474473UIProcess/Notifications/WebNotificationManagerProxy.cpp

  • trunk/Source/WebKit/UIProcess/API/APIUIClient.h

    r276853 r277414  
    5555class NativeWebKeyboardEvent;
    5656class NativeWebWheelEvent;
    57 class NotificationPermissionRequest;
    5857class UserMediaPermissionRequestProxy;
    5958class WebColorPickerResultListenerProxy;
    … …  
    138137    virtual void decidePolicyForUserMediaPermissionRequest(WebKit::WebPageProxy&, WebKit::WebFrameProxy&, SecurityOrigin&, SecurityOrigin&, WebKit::UserMediaPermissionRequestProxy& request) { request.doDefaultAction(); }
    139138    virtual void checkUserMediaPermissionForOrigin(WebKit::WebPageProxy&, WebKit::WebFrameProxy&, SecurityOrigin&, SecurityOrigin&, WebKit::UserMediaPermissionCheckProxy& request) { request.deny(); }
    140     virtual void decidePolicyForNotificationPermissionRequest(WebKit::WebPageProxy&, SecurityOrigin&, Function<void(bool)>&& completionHandler) { completionHandler(false); }
     139    virtual void decidePolicyForNotificationPermissionRequest(WebKit::WebPageProxy&, SecurityOrigin&, CompletionHandler<void(bool allowed)>&& completionHandler) { completionHandler(false); }
    141140    virtual void requestStorageAccessConfirm(WebKit::WebPageProxy&, WebKit::WebFrameProxy*, const WebCore::RegistrableDomain& requestingDomain, const WebCore::RegistrableDomain& currentDomain, CompletionHandler<void(bool)>&& completionHandler) { completionHandler(true); }
    142141

  • trunk/Source/WebKit/UIProcess/API/C/WKNotificationPermissionRequest.cpp

    r102352 r277414  
    3939void WKNotificationPermissionRequestAllow(WKNotificationPermissionRequestRef notificationPermissionRequest)
    4040{
    41     return toImpl(notificationPermissionRequest)->allow();
     41    return toImpl(notificationPermissionRequest)->didReceiveDecision(true);
    4242}
    4343
    4444void WKNotificationPermissionRequestDeny(WKNotificationPermissionRequestRef notificationPermissionRequest)
    4545{
    46     return toImpl(notificationPermissionRequest)->deny();
     46    return toImpl(notificationPermissionRequest)->didReceiveDecision(false);
    4747}

  • trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp

    r277356 r277414  
    6363#include "NativeWebWheelEvent.h"
    6464#include "NavigationActionData.h"
     65#include "NotificationPermissionRequest.h"
    6566#include "PageClient.h"
    6667#include "PluginInformation.h"
    … …  
    19891990        }
    19901991       
    1991         void decidePolicyForNotificationPermissionRequest(WebPageProxy& page, API::SecurityOrigin& origin, Function<void(bool)>&& completionHandler) final
     1992        void decidePolicyForNotificationPermissionRequest(WebPageProxy& page, API::SecurityOrigin& origin, CompletionHandler<void(bool allowed)>&& completionHandler) final
    19921993        {
    19931994            if (!m_client.decidePolicyForNotificationPermissionRequest)

  • trunk/Source/WebKit/UIProcess/API/glib/WebKitNotificationPermissionRequest.cpp

    r218487 r277414  
    6565        return;
    6666
    67     priv->request->allow();
     67    priv->request->didReceiveDecision(true);
    6868    priv->madeDecision = true;
    6969}
    … …  
    7979        return;
    8080
    81     priv->request->deny();
     81    priv->request->didReceiveDecision(false);
    8282    priv->madeDecision = true;
    8383}

  • trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp

    r276490 r277414  
    2323#include "APIUIClient.h"
    2424#include "DrawingAreaProxy.h"
     25#include "NotificationPermissionRequest.h"
    2526#include "WebKitDeviceInfoPermissionRequestPrivate.h"
    2627#include "WebKitFileChooserRequestPrivate.h"
    … …  
    306307    }
    307308
    308     void decidePolicyForNotificationPermissionRequest(WebPageProxy&, API::SecurityOrigin&, Function<void(bool)>&& completionHandler) final
     309    void decidePolicyForNotificationPermissionRequest(WebPageProxy&, API::SecurityOrigin&, CompletionHandler<void(bool allowed)>&& completionHandler) final
    309310    {
    310311        GRefPtr<WebKitNotificationPermissionRequest> notificationPermissionRequest = adoptGRef(webkitNotificationPermissionRequestCreate(NotificationPermissionRequest::create(WTFMove(completionHandler)).ptr()));

  • trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.h

    r276853 r277414  
    118118        void drawHeader(WebPageProxy&, WebFrameProxy&, WebCore::FloatRect&&) final;
    119119        void drawFooter(WebPageProxy&, WebFrameProxy&, WebCore::FloatRect&&) final;
    120         void decidePolicyForNotificationPermissionRequest(WebPageProxy&, API::SecurityOrigin&, Function<void(bool)>&&) final;
     120        void decidePolicyForNotificationPermissionRequest(WebPageProxy&, API::SecurityOrigin&, CompletionHandler<void(bool allowed)>&&) final;
    121121        void unavailablePluginButtonClicked(WebPageProxy&, WKPluginUnavailabilityReason, API::Dictionary&) final;
    122122        void mouseDidMoveOverElement(WebPageProxy&, const WebHitTestResultData&, OptionSet<WebEvent::Modifier>, API::Object*);

  • trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm

    r276853 r277414  
    947947}
    948948
    949 void UIDelegate::UIClient::decidePolicyForNotificationPermissionRequest(WebKit::WebPageProxy&, API::SecurityOrigin& securityOrigin, WTF::Function<void(bool)>&& completionHandler)
     949void UIDelegate::UIClient::decidePolicyForNotificationPermissionRequest(WebKit::WebPageProxy&, API::SecurityOrigin& securityOrigin, CompletionHandler<void(bool allowed)>&& completionHandler)
    950950{
    951951    if (!m_uiDelegate)

  • trunk/Source/WebKit/UIProcess/Notifications/NotificationPermissionRequest.h

    r221894 r277414  
    2727
    2828#include "APIObject.h"
    29 #include <wtf/Function.h>
     29#include <wtf/CompletionHandler.h>
    3030
    3131namespace WebKit {
    3232
    33 class NotificationPermissionRequestManagerProxy;
    34 
    3533class NotificationPermissionRequest : public API::ObjectImpl<API::Object::Type::NotificationPermissionRequest> {
    3634public:
    37     static Ref<NotificationPermissionRequest> create(Function<void(bool)>&& completionHandler)
     35    static Ref<NotificationPermissionRequest> create(CompletionHandler<void(bool)>&& completionHandler)
    3836    {
    3937        return adoptRef(*new NotificationPermissionRequest(WTFMove(completionHandler)));
    4038    }
     39
     40    ~NotificationPermissionRequest()
     41    {
     42        didReceiveDecision(false);
     43    }
    4144   
    42     void allow()
     45    void didReceiveDecision(bool allowed)
    4346    {
    44         if (auto completionHandler = std::exchange(m_completionHandler, nullptr))
    45             completionHandler(true);
    46     }
    47 
    48     void deny()
    49     {
    50         if (auto completionHandler = std::exchange(m_completionHandler, nullptr))
    51             completionHandler(false);
     47        if (m_completionHandler)
     48            m_completionHandler(allowed);
    5249    }
    5350
    5451private:
    55     NotificationPermissionRequest(Function<void(bool)>&& completionHandler)
     52    explicit NotificationPermissionRequest(CompletionHandler<void(bool)>&& completionHandler)
    5653        : m_completionHandler(WTFMove(completionHandler))
    57     { }
     54    {
     55    }
    5856   
    59     Function<void(bool)> m_completionHandler;
     57    CompletionHandler<void(bool)> m_completionHandler;
    6058};
    6159

  • trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

    r277375 r277414  
    483483#endif
    484484    , m_geolocationPermissionRequestManager(*this)
    485     , m_notificationPermissionRequestManager(*this)
    486485#if PLATFORM(IOS_FAMILY)
    487486    , m_audibleActivityTimer(RunLoop::main(), this, &WebPageProxy::clearAudibleActivity)
    … …  
    76327631    m_geolocationPermissionRequestManager.invalidateRequests();
    76337632#endif
    7634 
    7635     m_notificationPermissionRequestManager.invalidateRequests();
    76367633
    76377634    setToolTip({ });
    … …  
    84488445
    84498446
    8450 void WebPageProxy::requestNotificationPermission(uint64_t requestID, const String& originString)
    8451 {
    8452     if (!isRequestIDValid(requestID))
    8453         return;
    8454 
     8447void WebPageProxy::requestNotificationPermission(const String& originString, CompletionHandler<void(bool allowed)>&& completionHandler)
     8448{
    84558449    auto origin = API::SecurityOrigin::createFromString(originString);
    8456     auto request = m_notificationPermissionRequestManager.createRequest(requestID);
    8457    
    8458     m_uiClient->decidePolicyForNotificationPermissionRequest(*this, origin.get(), [request = WTFMove(request)](bool allowed) {
    8459         if (allowed)
    8460             request->allow();
    8461         else
    8462             request->deny();
    8463     });
     8450    m_uiClient->decidePolicyForNotificationPermissionRequest(*this, origin.get(), WTFMove(completionHandler));
    84648451}
    84658452

  • trunk/Source/WebKit/UIProcess/WebPageProxy.h

    r277356 r277414  
    4343#include "MediaPlaybackState.h"
    4444#include "MessageSender.h"
    45 #include "NotificationPermissionRequestManagerProxy.h"
    4645#include "PDFPluginIdentifier.h"
    4746#include "PageLoadState.h"
    … …  
    21302129    RefPtr<API::Navigation> launchProcessForReload();
    21312130
    2132     void requestNotificationPermission(uint64_t notificationID, const String& originString);
     2131    void requestNotificationPermission(const String& originString, CompletionHandler<void(bool allowed)>&&);
    21332132    void showNotification(const String& title, const String& body, const String& iconURL, const String& tag, const String& lang, WebCore::NotificationDirection, const String& originString, uint64_t notificationID);
    21342133    void cancelNotification(uint64_t notificationID);
    … …  
    26012600    RefPtr<WebOpenPanelResultListenerProxy> m_openPanelResultListener;
    26022601    GeolocationPermissionRequestManagerProxy m_geolocationPermissionRequestManager;
    2603     NotificationPermissionRequestManagerProxy m_notificationPermissionRequestManager;
    26042602
    26052603#if ENABLE(MEDIA_STREAM)

  • trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in

    r277196 r277414  
    282282
    283283    # Notification messages
    284     RequestNotificationPermission(uint64_t requestID, String originIdentifier)
     284    RequestNotificationPermission(String originIdentifier) -> (bool allowed) Async
    285285    ShowNotification(String title, String body, String iconURL, String tag, String lang, enum:uint8_t WebCore::NotificationDirection dir, String originIdentifier, uint64_t notificationID)
    286286    CancelNotification(uint64_t notificationID)

  • trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj

    r277264 r277414  
    823823                31A2EC4B148997C200810D71 /* WebNotificationManagerProxy.h in Headers */ = {isa = PBXBuildFile; fileRef = 31A2EC44148997BF00810D71 /* WebNotificationManagerProxy.h */; };
    824824                31A2EC4E148997C200810D71 /* WebNotificationProvider.h in Headers */ = {isa = PBXBuildFile; fileRef = 31A2EC47148997C100810D71 /* WebNotificationProvider.h */; };
    825                 31A2EC521489981900810D71 /* NotificationPermissionRequestManagerProxy.h in Headers */ = {isa = PBXBuildFile; fileRef = 31A2EC511489981500810D71 /* NotificationPermissionRequestManagerProxy.h */; };
    826825                31A2EC5614899C0900810D71 /* NotificationPermissionRequest.h in Headers */ = {isa = PBXBuildFile; fileRef = 31A2EC531489982500810D71 /* NotificationPermissionRequest.h */; };
    827826                31A2EC74148D59CA00810D71 /* WKNotificationPermissionRequest.h in Headers */ = {isa = PBXBuildFile; fileRef = 31A2EC72148D59BB00810D71 /* WKNotificationPermissionRequest.h */; settings = {ATTRIBUTES = (Private, ); }; };
    … …  
    35773576                31A2EC46148997C000810D71 /* WebNotificationProvider.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WebNotificationProvider.cpp; sourceTree = "<group>"; };
    35783577                31A2EC47148997C100810D71 /* WebNotificationProvider.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebNotificationProvider.h; sourceTree = "<group>"; };
    3579                 31A2EC4F1489980500810D71 /* NotificationPermissionRequestManagerProxy.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = NotificationPermissionRequestManagerProxy.cpp; sourceTree = "<group>"; };
    3580                 31A2EC511489981500810D71 /* NotificationPermissionRequestManagerProxy.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = NotificationPermissionRequestManagerProxy.h; sourceTree = "<group>"; };
    35813578                31A2EC531489982500810D71 /* NotificationPermissionRequest.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = NotificationPermissionRequest.h; sourceTree = "<group>"; };
    35823579                31A2EC72148D59BB00810D71 /* WKNotificationPermissionRequest.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WKNotificationPermissionRequest.h; sourceTree = "<group>"; };
    … …  
    78387835                        children = (
    78397836                                31A2EC531489982500810D71 /* NotificationPermissionRequest.h */,
    7840                                 31A2EC4F1489980500810D71 /* NotificationPermissionRequestManagerProxy.cpp */,
    7841                                 31A2EC511489981500810D71 /* NotificationPermissionRequestManagerProxy.h */,
    78427837                                31A2EC41148997BE00810D71 /* WebNotification.cpp */,
    78437838                                31A2EC42148997BE00810D71 /* WebNotification.h */,
    … …  
    1211112106                                31A2EC5614899C0900810D71 /* NotificationPermissionRequest.h in Headers */,
    1211212107                                3131261F148FF82C00BA2A39 /* NotificationPermissionRequestManager.h in Headers */,
    12113                                 31A2EC521489981900810D71 /* NotificationPermissionRequestManagerProxy.h in Headers */,
    1211412108                                1A2D848B127F6A49001EB962 /* NPIdentifierData.h in Headers */,
    1211512109                                1AE4976811FF658E0048B464 /* NPJSObject.h in Headers */,

  • trunk/Source/WebKit/WebProcess/Notifications/NotificationPermissionRequestManager.cpp

    r277380 r277414  
    4444using namespace WebCore;
    4545
    46 #if ENABLE(NOTIFICATIONS)
    47 static uint64_t generateRequestID()
    48 {
    49     static uint64_t uniqueRequestID = 1;
    50     return uniqueRequestID++;
    51 }
    52 #endif
    53 
    5446Ref<NotificationPermissionRequestManager> NotificationPermissionRequestManager::create(WebPage* page)
    5547{
    … …  
    8375        return;
    8476
    85     uint64_t requestID = generateRequestID();
    86     m_idToOriginMap.set(requestID, securityOrigin);
     77    m_page->sendWithAsyncReply(Messages::WebPageProxy::RequestNotificationPermission(securityOrigin.toString()), [this, protectedThis = makeRef(*this), callback = WTFMove(callback), securityOrigin](bool allowed) mutable {
     78        WebProcess::singleton().supplement<WebNotificationManager>()->didUpdateNotificationDecision(securityOrigin.toString(), allowed);
    8779
    88     // FIXME: This should use sendWithAsyncReply().
    89     m_page->send(Messages::WebPageProxy::RequestNotificationPermission(requestID, securityOrigin.toString()));
     80        auto callbacks = m_requestsPerOrigin.take(securityOrigin);
     81        for (auto& callback : callbacks) {
     82            if (callback)
     83                callback->handleEvent(allowed ? NotificationClient::Permission::Granted : NotificationClient::Permission::Denied);
     84        }
     85    });
    9086}
    9187#endif
    … …  
    121117}
    122118
    123 void NotificationPermissionRequestManager::didReceiveNotificationPermissionDecision(uint64_t requestID, bool allowed)
    124 {
    125 #if ENABLE(NOTIFICATIONS)
    126     if (!isRequestIDValid(requestID))
    127         return;
    128 
    129     auto origin = m_idToOriginMap.take(requestID);
    130     if (origin.isEmpty())
    131         return;
    132 
    133     WebProcess::singleton().supplement<WebNotificationManager>()->didUpdateNotificationDecision(origin.toString(), allowed);
    134 
    135     auto callbacks = m_requestsPerOrigin.take(origin);
    136     for (auto& callback : callbacks) {
    137         if (callback)
    138             callback->handleEvent(allowed ? NotificationClient::Permission::Granted : NotificationClient::Permission::Denied);
    139     }
    140 #else
    141     UNUSED_PARAM(requestID);
    142     UNUSED_PARAM(allowed);
    143 #endif   
    144 }
    145 
    146119} // namespace WebKit

  • trunk/Source/WebKit/WebProcess/Notifications/NotificationPermissionRequestManager.h

    r277376 r277414  
    5858    void removeAllPermissionsForTesting();
    5959   
    60     void didReceiveNotificationPermissionDecision(uint64_t notificationID, bool allowed);
    61    
    6260private:
    6361    NotificationPermissionRequestManager(WebPage*);
    … …  
    6563#if ENABLE(NOTIFICATIONS)
    6664    HashMap<WebCore::SecurityOriginData, Vector<RefPtr<WebCore::NotificationPermissionCallback>>> m_requestsPerOrigin;
    67     HashMap<uint64_t, WebCore::SecurityOriginData> m_idToOriginMap;
    6865    WebPage* m_page;
    6966#endif

  • trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp

    r277356 r277414  
    46554655#endif
    46564656
    4657 void WebPage::didReceiveNotificationPermissionDecision(uint64_t notificationID, bool allowed)
    4658 {
    4659     notificationPermissionRequestManager()->didReceiveNotificationPermissionDecision(notificationID, allowed);
    4660 }
    4661 
    46624657#if ENABLE(MEDIA_STREAM)
    46634658

  • trunk/Source/WebKit/WebProcess/WebPage/WebPage.h

    r277356 r277414  
    17371737    void didReceiveGeolocationPermissionDecision(GeolocationIdentifier, const String& authorizationToken);
    17381738
    1739     void didReceiveNotificationPermissionDecision(uint64_t notificationID, bool allowed);
    1740 
    17411739#if ENABLE(MEDIA_STREAM)
    17421740    void userMediaAccessWasGranted(uint64_t userMediaID, WebCore::CaptureDevice&& audioDeviceUID, WebCore::CaptureDevice&& videoDeviceUID, String&& mediaDeviceIdentifierHashSalt, SandboxExtension::Handle&&, CompletionHandler<void()>&&);

  • trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in

    r277356 r277414  
    394394    ResumeAllMediaPlayback() -> () Async
    395395
    396     # Notification
    397     DidReceiveNotificationPermissionDecision(uint64_t notificationID, bool allowed)
    398 
    399396    FreezeLayerTreeDueToSwipeAnimation()
    400397    UnfreezeLayerTreeDueToSwipeAnimation()
Note: See TracChangeset for help on using the changeset viewer.