Changeset 277429 in webkit

Timestamp:

May 13, 2021, 3:39:13 AM (5 years ago)

Author:

timothy_horton@apple.com

Message:

ResizeReversePaginatedWebView fails on some OS versions on some hardware
​https://bugs.webkit.org/show_bug.cgi?id=224699
<rdar://76782199>

Reviewed by Megan Gardner.

• TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:

(TestWebKitAPI::didLayout):
This test does *not* care about the specific number of pages that are
generated; the key to the test is the scroll position check.

Since the page-count check in this test has caused lots of trouble
in the past (see the history) just remove it and replace it with a
check that we ended up paginated at all.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-05-13  Tim Horton  <timothy_horton@apple.com>
+
+        ResizeReversePaginatedWebView fails on some OS versions on some hardware
+        https://bugs.webkit.org/show_bug.cgi?id=224699
+        <rdar://76782199>
+
+        Reviewed by Megan Gardner.
+
+        * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
+        (TestWebKitAPI::didLayout):
+        This test does *not* care about the specific number of pages that are
+        generated; the key to the test is the scroll position check.
+
+        Since the page-count check in this test has caused lots of trouble
+        in the past (see the history) just remove it and replace it with a
+        check that we ended up paginated at all.
+
 2021-05-12  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp

@@ -43 +43 @@
 static const unsigned pageLength = 100;
 static const unsigned pageGap = 100;
-static const unsigned expectedPageCount = 49;
 
 static void didLayout(WKPageRef page, WKPageRenderingProgressEvents milestones, WKTypeRef, const void* clientInfo)
@@ -51 +50 @@
 
         unsigned pageCount = WKPageGetPageCount(page);
-        EXPECT_EQ(expectedPageCount, pageCount);
+        EXPECT_GT(pageCount, 2U);
 
         webView->resizeTo((pageLength * pageCount) + (pageGap * (pageCount - 1)), 500);