Changeset 277447 in webkit

Timestamp:

May 13, 2021, 12:45:02 PM (5 years ago)

Author:

Chris Dumez

Message:

Process suspension may be delayed by up to 5 seconds after there is no longer any database activity
​https://bugs.webkit.org/show_bug.cgi?id=225774

Reviewed by Geoffrey Garen.

Use a 1 second HysteresisActivity in WebSQLiteDatabaseTracker instead of a 5 seconds one.
I frequently see our processes' suspension getting delayed by 5 seconds when homing out of
MobileSafari due to database activity. This change should help with that.

• Shared/WebSQLiteDatabaseTracker.cpp:

(WebKit::WebSQLiteDatabaseTracker::WebSQLiteDatabaseTracker):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/WebSQLiteDatabaseTracker.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-05-13  Chris Dumez  <cdumez@apple.com>
+
+        Process suspension may be delayed by up to 5 seconds after there is no longer any database activity
+        https://bugs.webkit.org/show_bug.cgi?id=225774
+
+        Reviewed by Geoffrey Garen.
+
+        Use a 1 second HysteresisActivity in WebSQLiteDatabaseTracker instead of a 5 seconds one.
+        I frequently see our processes' suspension getting delayed by 5 seconds when homing out of
+        MobileSafari due to database activity. This change should help with that.
+
+        * Shared/WebSQLiteDatabaseTracker.cpp:
+        (WebKit::WebSQLiteDatabaseTracker::WebSQLiteDatabaseTracker):
+
 2021-05-13  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/Shared/WebSQLiteDatabaseTracker.cpp

@@ -38 +38 @@
 WebSQLiteDatabaseTracker::WebSQLiteDatabaseTracker(IsHoldingLockedFilesHandler&& isHoldingLockedFilesHandler)
     : m_isHoldingLockedFilesHandler(WTFMove(isHoldingLockedFilesHandler))
-    , m_hysteresis([this](PAL::HysteresisState state) { setIsHoldingLockedFiles(state == PAL::HysteresisState::Started); })
+    , m_hysteresis([this](PAL::HysteresisState state) { setIsHoldingLockedFiles(state == PAL::HysteresisState::Started); }, 1_s)
 {
     ASSERT(RunLoop::isMain());