Changeset 277465 in webkit

Timestamp:

May 13, 2021, 4:31:11 PM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[ews] Style fixes in steps.py
​https://bugs.webkit.org/show_bug.cgi?id=225784

Reviewed by Dewei Zhu.

• CISupport/ews-build/steps.py:

(CheckOutSource.init):
(ShowIdentifier.hideStepIf):
(BugzillaMixin.get_bugzilla_api_key):
(RunJavaScriptCoreTests.commandComplete):
(AnalyzeJSCTestsResults.send_email_for_pre_existing_failure):
(AnalyzeLayoutTestsResults._report_flaky_tests):
(DownloadBuiltProduct):
(AnalyzeAPITestsResults.analyzeResults.getAPITestFailures):
(AnalyzeAPITestsResults.send_email_for_pre_existing_failure):

Location:

trunk/Tools

Files:

• CISupport/ews-build/steps.py (modified) (9 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/CISupport/ews-build/steps.py

@@ -112 +112 @@
     def __init__(self, repourl='https://github.com/WebKit/WebKit.git', **kwargs):
         super(CheckOutSource, self).__init__(repourl=repourl,
-                                                retry=self.CHECKOUT_DELAY_AND_MAX_RETRIES_PAIR,
-                                                timeout=2 * 60 * 60,
-                                                alwaysUseLatest=True,
-                                                logEnviron=False,
-                                                method='clean',
-                                                progress=True,
-                                                **kwargs)
+                                             retry=self.CHECKOUT_DELAY_AND_MAX_RETRIES_PAIR,
+                                             timeout=2 * 60 * 60,
+                                             alwaysUseLatest=True,
+                                             logEnviron=False,
+                                             method='clean',
+                                             progress=True,
+                                             **kwargs)
 
     def getResultSummary(self):
@@ -255 +255 @@
         return results == SUCCESS
 
+
 class CleanWorkingDirectory(shell.ShellCommand):
     name = 'clean-working-directory'
@@ -716 +717 @@
             passwords = json.load(open('passwords.json'))
             return passwords.get('BUGZILLA_API_KEY', '')
-        except:
+        except Exception as e:
             print('Error in reading Bugzilla api key')
             return ''
@@ -1837 +1838 @@
             return
 
-        if jsc_results.get('allMasmTestsPassed') == False:
+        if jsc_results.get('allMasmTestsPassed') is False:
             self.binaryFailures.append('testmasm')
-        if jsc_results.get('allAirTestsPassed') == False:
+        if jsc_results.get('allAirTestsPassed') is False:
             self.binaryFailures.append('testair')
-        if jsc_results.get('allB3TestsPassed') == False:
+        if jsc_results.get('allB3TestsPassed') is False:
             self.binaryFailures.append('testb3')
-        if jsc_results.get('allDFGTestsPassed') == False:
+        if jsc_results.get('allDFGTestsPassed') is False:
             self.binaryFailures.append('testdfg')
-        if jsc_results.get('allApiTestsPassed') == False:
+        if jsc_results.get('allApiTestsPassed') is False:
             self.binaryFailures.append('testapi')
 
@@ -2026 +2027 @@
 
 
-
 class CleanBuild(shell.Compile):
     name = 'delete-WebKitBuild-directory'
@@ -2544 +2544 @@
 
     def _report_flaky_tests(self, flaky_tests):
-        #TODO: implement this
+        # TODO: implement this
         pass
 
@@ -2701 +2701 @@
 class DownloadBuiltProduct(shell.ShellCommand):
     command = ['python', 'Tools/CISupport/download-built-product',
-        WithProperties('--%(configuration)s'),
-        WithProperties(S3URL + 'ews-archives.webkit.org/%(fullPlatform)s-%(architecture)s-%(configuration)s/%(patch_id)s.zip')]
+               WithProperties('--%(configuration)s'),
+               WithProperties(S3URL + 'ews-archives.webkit.org/%(fullPlatform)s-%(architecture)s-%(configuration)s/%(patch_id)s.zip')]
     name = 'download-built-product'
     description = ['downloading built product']
@@ -2875 +2875 @@
             # TODO: Analyze Time-out, Crash and Failure independently
             return set([failure.get('name') for failure in result.get('Timedout', [])] +
-                [failure.get('name') for failure in result.get('Crashed', [])] +
-                [failure.get('name') for failure in result.get('Failed', [])])
+                       [failure.get('name') for failure in result.get('Crashed', [])] +
+                       [failure.get('name') for failure in result.get('Failed', [])])
 
         first_run_failures = getAPITestFailures(first_run_results)
@@ -2989 +2989 @@
             print('Error in sending email for pre-existing failure: {}'.format(e))
 
+
 class ArchiveTestResults(shell.ShellCommand):
     command = ['python', 'Tools/CISupport/test-result-archive',

trunk/Tools/ChangeLog

@@ +1 @@
+2021-05-13  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews] Style fixes in steps.py
+        https://bugs.webkit.org/show_bug.cgi?id=225784
+
+        Reviewed by Dewei Zhu.
+
+        * CISupport/ews-build/steps.py:
+        (CheckOutSource.__init__):
+        (ShowIdentifier.hideStepIf):
+        (BugzillaMixin.get_bugzilla_api_key):
+        (RunJavaScriptCoreTests.commandComplete):
+        (AnalyzeJSCTestsResults.send_email_for_pre_existing_failure):
+        (AnalyzeLayoutTestsResults._report_flaky_tests):
+        (DownloadBuiltProduct):
+        (AnalyzeAPITestsResults.analyzeResults.getAPITestFailures):
+        (AnalyzeAPITestsResults.send_email_for_pre_existing_failure):
+
 2021-05-13  Chris Dumez  <cdumez@apple.com>