Changeset 277476 in webkit

Timestamp:

May 13, 2021, 7:06:04 PM (5 years ago)

Author:

aakash_jain@apple.com

Message:

report-non-inclusive-language should skip symlinks
​https://bugs.webkit.org/show_bug.cgi?id=225789

Reviewed by Darin Adler.

• Scripts/report-non-inclusive-language: Skip symlinks since most likely the linked file would be checked

directly by the script while iterating the directory structure and would result in it being counted twice.
Also the script fails with an error if there is a symlink pointing to a non-existing file.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/report-non-inclusive-language (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-05-13  Aakash Jain  <aakash_jain@apple.com>
+
+        report-non-inclusive-language should skip symlinks
+        https://bugs.webkit.org/show_bug.cgi?id=225789
+
+        Reviewed by Darin Adler.
+
+        * Scripts/report-non-inclusive-language: Skip symlinks since most likely the linked file would be checked 
+        directly by the script while iterating the directory structure and would result in it being counted twice.
+        Also the script fails with an error if there is a symlink pointing to a non-existing file.
+
 2021-05-13  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/Scripts/report-non-inclusive-language

@@ -68 +68 @@
         if file in IGNORE_FILE_NAMES:
             continue
+        if os.path.islink(os.path.join(subroot, file)):
+            continue
         handle = open(os.path.join(subroot, file), "r")
         for line in handle.readlines():