Changeset 277483 in webkit

Timestamp:

May 13, 2021, 10:53:12 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Misc GCC warning cleanup
​https://bugs.webkit.org/show_bug.cgi?id=225777

Patch by Michael Catanzaro <Michael Catanzaro> on 2021-05-13
Reviewed by Carlos Garcia Campos.

Source/WebCore:

• bindings/js/JSAudioNodeCustom.cpp:

(WebCore::toJSNewlyCreated): Add missing RELEASE_ASSERT_NOT_REACHED().

• svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter): Remove redundant condition.

Source/WebDriver:

Remove unused variable.

• glib/WebDriverServiceGLib.cpp:

(WebDriver::parseVersion):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/bindings/js/JSAudioNodeCustom.cpp (modified) (1 diff)
• WebCore/svg/SVGToOTFFontConversion.cpp (modified) (1 diff)
• WebDriver/ChangeLog (modified) (1 diff)
• WebDriver/glib/WebDriverServiceGLib.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-05-13  Michael Catanzaro  <mcatanzaro@gnome.org>
+
+        Misc GCC warning cleanup
+        https://bugs.webkit.org/show_bug.cgi?id=225777
+
+        Reviewed by Carlos Garcia Campos.
+
+        * bindings/js/JSAudioNodeCustom.cpp:
+        (WebCore::toJSNewlyCreated): Add missing RELEASE_ASSERT_NOT_REACHED().
+        * svg/SVGToOTFFontConversion.cpp:
+        (WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter): Remove redundant condition.
+
 2021-05-13  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/bindings/js/JSAudioNodeCustom.cpp

@@ -132 +132 @@
         return createWrapper<AudioWorkletNode>(globalObject, WTFMove(node));
     }
+    RELEASE_ASSERT_NOT_REACHED();
 }
 

trunk/Source/WebCore/svg/SVGToOTFFontConversion.cpp

@@ -1452 +1452 @@
                 break;
             }
-            if (auto value = parseIntegerAllowingTrailingJunk<uint16_t>(segment); value && *value >= 0 && *value < 1000) {
+            if (auto value = parseIntegerAllowingTrailingJunk<uint16_t>(segment); value && *value < 1000) {
                 m_weight = (*value + 50) / 100;
                 break;

trunk/Source/WebDriver/ChangeLog

@@ +1 @@
+2021-05-13  Michael Catanzaro  <mcatanzaro@gnome.org>
+
+        Misc GCC warning cleanup
+        https://bugs.webkit.org/show_bug.cgi?id=225777
+
+        Reviewed by Carlos Garcia Campos.
+
+        Remove unused variable.
+
+        * glib/WebDriverServiceGLib.cpp:
+        (WebDriver::parseVersion):
+
 2021-05-13  Darin Adler  <darin@apple.com>
 

trunk/Source/WebDriver/glib/WebDriverServiceGLib.cpp

@@ -36 +36 @@
 
     Vector<String> tokens = version.split('.');
-    bool ok;
     switch (tokens.size()) {
     case 3: {