Changeset 277484 in webkit

Timestamp:

May 13, 2021, 11:42:35 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Check for null element in paintSearchFieldResultsButton
​https://bugs.webkit.org/show_bug.cgi?id=225232

Patch by Rob Buis <​rbuis@igalia.com> on 2021-05-13
Reviewed by Ryosuke Niwa.

Source/WebCore:

Check for null element in paintSearchFieldResultsButton.

Test: fast/css/searchfield-results-button-crash.html

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldResultsButton):

LayoutTests:

Add test for this.

• fast/css/searchfield-results-button-crash-expected.txt: Added.
• fast/css/searchfield-results-button-crash.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/searchfield-results-button-crash-expected.txt (added)
• LayoutTests/fast/css/searchfield-results-button-crash.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderThemeMac.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-05-13  Rob Buis  <rbuis@igalia.com>
+
+        Check for null element in paintSearchFieldResultsButton
+        https://bugs.webkit.org/show_bug.cgi?id=225232
+
+        Reviewed by Ryosuke Niwa.
+
+        Add test for this.
+
+        * fast/css/searchfield-results-button-crash-expected.txt: Added.
+        * fast/css/searchfield-results-button-crash.html: Added.
+
 2021-05-13  Lauro Moura  <lmoura@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-05-13  Rob Buis  <rbuis@igalia.com>
+
+        Check for null element in paintSearchFieldResultsButton
+        https://bugs.webkit.org/show_bug.cgi?id=225232
+
+        Reviewed by Ryosuke Niwa.
+
+        Check for null element in paintSearchFieldResultsButton.
+
+        Test: fast/css/searchfield-results-button-crash.html
+
+        * rendering/RenderThemeMac.mm:
+        (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
+
 2021-05-13  Michael Catanzaro  <mcatanzaro@gnome.org>
 

trunk/Source/WebCore/rendering/RenderThemeMac.mm

@@ -2042 +2042 @@
     };
 
+    if (!box.element())
+        return false;
     Element* input = box.element()->shadowHost();
     if (!input)