Changeset 277999 in webkit

Timestamp:

May 24, 2021, 11:22:41 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

GLContextEGL::swapBuffers() shouldn't do anything for Surfaceless contexts
​https://bugs.webkit.org/show_bug.cgi?id=226164

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2021-05-24
Reviewed by Philippe Normand.

In case of a surfaceless GLContextEGL, the swapBuffers() method should
return early, avoiding an assert expecting a non-null EGLSurface (not
viable for surfaceless context) and a call to eglSwapBuffers(), which
on some drivers could still fail even when the surfaceless context
support is present and active.

• platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::swapBuffers):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/egl/GLContextEGL.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-05-24  Zan Dobersek  <zdobersek@igalia.com>
+
+        GLContextEGL::swapBuffers() shouldn't do anything for Surfaceless contexts
+        https://bugs.webkit.org/show_bug.cgi?id=226164
+
+        Reviewed by Philippe Normand.
+
+        In case of a surfaceless GLContextEGL, the swapBuffers() method should
+        return early, avoiding an assert expecting a non-null EGLSurface (not
+        viable for surfaceless context) and a call to eglSwapBuffers(), which
+        on some drivers could still fail even when the surfaceless context
+        support is present and active.
+
+        * platform/graphics/egl/GLContextEGL.cpp:
+        (WebCore::GLContextEGL::swapBuffers):
+
 2021-05-24  Cathie Chen  <cathiechen@igalia.com>
 

trunk/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp

@@ -478 +478 @@
 void GLContextEGL::swapBuffers()
 {
+    if (m_type == Surfaceless)
+        return;
+
     ASSERT(m_surface);
     eglSwapBuffers(m_display.eglDisplay(), m_surface);