Changeset 27833 in webkit

Timestamp:

Nov 15, 2007 5:04:48 PM (16 years ago)

Author:

timothy@apple.com

Message:

Reviewed by Sam.

Bug 16007: REGRESSION: Disclosure triangle click zone for resource categories is off by 10 pixels
​http://bugs.webkit.org/show_bug.cgi?id=16007

Makes the click width an option on TreeElement and make ResourceCategoryTreeElement
a true subclass of TreeElement. The click width for ResourceCategoryTreeElement is
20 pixels, and the default is 10 pixels.

• page/inspector/ResourceCategory.js:
• page/inspector/treeoutline.js:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/inspector/ResourceCategory.js (modified) (1 diff)
• page/inspector/treeoutline.js (modified) (4 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-11-15  Timothy Hatcher  <timothy@apple.com>
+
+        Reviewed by Sam.
+
+        Bug 16007: REGRESSION: Disclosure triangle click zone for resource categories is off by 10 pixels
+        http://bugs.webkit.org/show_bug.cgi?id=16007
+
+        Makes the click width an option on TreeElement and make ResourceCategoryTreeElement
+        a true subclass of TreeElement. The click width for ResourceCategoryTreeElement is 
+        20 pixels, and the default is 10 pixels.
+
+        * page/inspector/ResourceCategory.js:
+        * page/inspector/treeoutline.js:
+
 2007-11-15  Anders Carlsson  <andersca@apple.com>
 

trunk/WebCore/page/inspector/ResourceCategory.js

@@ -94 +94 @@
 WebInspector.ResourceCategoryTreeElement = function(category)
 {
-    var item = new TreeElement(category.title, category, true);
-    item.selectable = false;
-    return item;
+    TreeElement.call(this, category.title, category, true);
 }
+
+WebInspector.ResourceCategoryTreeElement.prototype = {
+    selectable: false,
+    arrowToggleWidth: 20
+}
+
+WebInspector.ResourceCategoryTreeElement.prototype.__proto__ = TreeElement.prototype;

trunk/WebCore/page/inspector/treeoutline.js

@@ -391 +391 @@
     this.expanded = false;
     this.selected = false;
-    this.selectable = true;
     this.hasChildren = hasChildren;
     this.children = [];
@@ -402 +401 @@
 
 TreeElement.prototype = {
+    selectable: true,
+    arrowToggleWidth: 10,
+
     get listItemElement() {
         return this._listItemNode;
@@ -511 +513 @@
         return;
 
-    if (event.offsetX > 10 || !element.treeElement.hasChildren)
+    if (event.offsetX > element.treeElement.arrowToggleWidth || !element.treeElement.hasChildren)
         element.treeElement.select();
 }
@@ -521 +523 @@
         return;
 
-    if (event.offsetX <= 10 && element.treeElement.hasChildren) {
+    if (event.offsetX <= element.treeElement.arrowToggleWidth && element.treeElement.hasChildren) {
         if (element.treeElement.expanded) {
             if (event.altKey)