Changeset 278334 in webkit

Timestamp:

Jun 1, 2021, 5:27:45 PM (5 years ago)

Author:

Chris Fleizach

Message:

REGRESSION: (r277971) TestWebKitAPI.WebKit.AccessibilityReduceMotion is timing out
​https://bugs.webkit.org/show_bug.cgi?id=226505
<rdar://problem/78721462>

Reviewed by Darin Adler.

The distributed notification for RM is no longer re-posted within WebKit, so we don't need to listen for it.

• TestWebKitAPI/Tests/WebKit/AccessibilityReduceMotion.mm:

(TEST):
(notificationCallback): Deleted.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKit/AccessibilityReduceMotion.mm (modified) (4 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-06-01  Chris Fleizach  <cfleizach@apple.com>
+
+        REGRESSION: (r277971) TestWebKitAPI.WebKit.AccessibilityReduceMotion is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=226505
+        <rdar://problem/78721462>
+
+        Reviewed by Darin Adler.
+
+        The distributed notification for RM is no longer re-posted within WebKit, so we don't need to listen for it.
+
+        * TestWebKitAPI/Tests/WebKit/AccessibilityReduceMotion.mm:
+        (TEST):
+        (notificationCallback): Deleted.
+
 2021-06-01  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKit/AccessibilityReduceMotion.mm

@@ -58 +58 @@
 #endif
 
-static bool reduceMotionNotificationReceived = false;
 static bool receivedPreferenceNotification = false;
 
@@ -73 +72 @@
 @end
 
-static void notificationCallback(CFNotificationCenterRef center, void *observer, CFNotificationName name, const void *object, CFDictionaryRef userInfo)
-{
-    reduceMotionNotificationReceived = true;
-}
-
 TEST(WebKit, AccessibilityReduceMotion)
 {
-    CFNotificationCenterAddObserver(NOTIFICATION_CENTER, nullptr, &notificationCallback, REDUCED_MOTION_CHANGED_NOTIFICATION, nullptr, CFNotificationSuspensionBehaviorDeliverImmediately);
-
     WKWebViewConfiguration *configuration = [WKWebViewConfiguration _test_configurationWithTestPlugInClassName:@"WebProcessPlugInWithInternals" configureJSCForTesting:YES];
     auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 300, 300) configuration:configuration addToWindow:YES]);
@@ -97 +89 @@
     ASSERT_FALSE(reduceMotion());
 
-    reduceMotionNotificationReceived = false;
-
     CFPreferencesSetAppValue(REDUCED_MOTION_PREFERENCE, kCFBooleanTrue, ACCESSIBILITY_DOMAIN);
 
     TestWebKitAPI::Util::run(&receivedPreferenceNotification);
-    TestWebKitAPI::Util::run(&reduceMotionNotificationReceived);
 
     [webView synchronouslyLoadTestPageNamed:@"simple"];
@@ -109 +98 @@
 
     CFPreferencesSetAppValue(REDUCED_MOTION_PREFERENCE, nullptr, ACCESSIBILITY_DOMAIN);
-
-    CFNotificationCenterRemoveObserver(NOTIFICATION_CENTER, nullptr, REDUCED_MOTION_CHANGED_NOTIFICATION, nullptr);
 }