Changeset 278409 in webkit

Timestamp:

Jun 3, 2021, 10:04:44 AM (5 years ago)

Author:

Chris Dumez

Message:

StorageArea should be able to send its IPC directly from the background thread
​https://bugs.webkit.org/show_bug.cgi?id=226583

Reviewed by Alex Christensen.

Update StorageArea so that it does its IPC sending straight from the storage thread, instead of
hopping to the main thread to do so.

• NetworkProcess/WebStorage/StorageArea.cpp:

(WebKit::StorageArea::clear):
(WebKit::StorageArea::dispatchEvents const):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/WebStorage/StorageArea.cpp (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-06-03  Chris Dumez  <cdumez@apple.com>
+
+        StorageArea should be able to send its IPC directly from the background thread
+        https://bugs.webkit.org/show_bug.cgi?id=226583
+
+        Reviewed by Alex Christensen.
+
+        Update StorageArea so that it does its IPC sending straight from the storage thread, instead of
+        hopping to the main thread to do so.
+
+        * NetworkProcess/WebStorage/StorageArea.cpp:
+        (WebKit::StorageArea::clear):
+        (WebKit::StorageArea::dispatchEvents const):
+
 2021-06-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/NetworkProcess/WebStorage/StorageArea.cpp

@@ -164 +164 @@
     }
 
-    for (auto it = m_eventListeners.begin(), end = m_eventListeners.end(); it != end; ++it) {
-        RunLoop::main().dispatch([connectionID = *it, destinationStorageAreaID = m_identifier] {
-            if (auto* connection = IPC::Connection::connection(connectionID))
-                connection->send(Messages::StorageAreaMap::ClearCache(), destinationStorageAreaID);
-        });
-    }
+    for (auto& listenerUniqueID : m_eventListeners)
+        IPC::Connection::send(listenerUniqueID, Messages::StorageAreaMap::ClearCache(), m_identifier.toUInt64());
 }
 
@@ -190 +186 @@
     ASSERT(!RunLoop::isMain());
     ASSERT(storageAreaImplID);
-    for (auto it = m_eventListeners.begin(), end = m_eventListeners.end(); it != end; ++it) {
-        std::optional<StorageAreaImplIdentifier> optionalStorageAreaImplID = *it == sourceConnection ? std::make_optional(storageAreaImplID) : std::nullopt;
-
-        RunLoop::main().dispatch([connectionID = *it, destinationStorageAreaID = m_identifier, key = key.isolatedCopy(), oldValue = oldValue.isolatedCopy(), newValue = newValue.isolatedCopy(), urlString = urlString.isolatedCopy(), optionalStorageAreaImplID = WTFMove(optionalStorageAreaImplID)] {
-            if (auto* connection = IPC::Connection::connection(connectionID))
-                connection->send(Messages::StorageAreaMap::DispatchStorageEvent(optionalStorageAreaImplID, key, oldValue, newValue, urlString), destinationStorageAreaID);
-        });
+    for (auto& listenerUniqueID : m_eventListeners) {
+        auto optionalStorageAreaImplID = listenerUniqueID == sourceConnection ? std::make_optional(storageAreaImplID) : std::nullopt;
+        IPC::Connection::send(listenerUniqueID, Messages::StorageAreaMap::DispatchStorageEvent(optionalStorageAreaImplID, key, oldValue, newValue, urlString), m_identifier.toUInt64());
     }
 }