Changeset 278412 in webkit

Timestamp:

Jun 3, 2021, 11:04:30 AM (5 years ago)

Author:

Chris Fleizach

Message:

AX: macOS WebContent can't read prefs from com.apple.Accessibility
​https://bugs.webkit.org/show_bug.cgi?id=226528

Reviewed by Per Arne Vollan.

Some accessibility preferences on macOS use libAccessibility.
WebContent should process these on iOS & macOS.

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::setPreferenceValue):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/cocoa/WebProcessCocoa.mm (modified) (4 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-06-03  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: macOS WebContent can't read prefs from com.apple.Accessibility
+        https://bugs.webkit.org/show_bug.cgi?id=226528
+
+        Reviewed by Per Arne Vollan.
+
+        Some accessibility preferences on macOS use libAccessibility. 
+        WebContent should process these on iOS & macOS.
+
+        * WebProcess/cocoa/WebProcessCocoa.mm:
+        (WebKit::setPreferenceValue):
+
 2021-06-03  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

@@ -103 +103 @@
 #import <wtf/cocoa/VectorCocoa.h>
 
+#if ENABLE(CFPREFS_DIRECT_MODE)
+#import "AccessibilitySupportSPI.h"
+#endif
+
 #if ENABLE(REMOTE_INSPECTOR)
 #import <JavaScriptCore/RemoteInspector.h>
@@ -113 +117 @@
 
 #if PLATFORM(IOS_FAMILY)
-#import "AccessibilitySupportSPI.h"
 #import "RunningBoardServicesSPI.h"
 #import "UserInterfaceIdiom.h"
@@ -171 +174 @@
 #endif
 
-#if PLATFORM(IOS_FAMILY)
+#if ENABLE(CFPREFS_DIRECT_MODE)
 SOFT_LINK_LIBRARY(libAccessibility)
 SOFT_LINK_OPTIONAL(libAccessibility, _AXSUpdateWebAccessibilitySettings, void, (), ());
@@ -1127 +1130 @@
     }
 
-#if PLATFORM(IOS_FAMILY)
     if (domain == String(kAXSAccessibilityPreferenceDomain)) {
         if (_AXSUpdateWebAccessibilitySettingsPtr())
             _AXSUpdateWebAccessibilitySettingsPtr()();
     }
-#endif
     
 #if USE(APPKIT)