Changeset 278415 in webkit

Timestamp:

Jun 3, 2021, 12:40:39 PM (5 years ago)

Author:

youenn@apple.com

Message:

Do not recalibrate camera if the settings are the same
​https://bugs.webkit.org/show_bug.cgi?id=226585

Reviewed by Eric Carlson.

Make sure to not update the preset if the constraints are equal to the current settings.
Manually tested.

• platform/mediastream/RealtimeVideoCaptureSource.cpp:

(WebCore::RealtimeVideoCaptureSource::clientUpdatedSizeAndFrameRate):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mediastream/RealtimeVideoCaptureSource.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-06-03  Youenn Fablet  <youenn@apple.com>
+
+        Do not recalibrate camera if the settings are the same
+        https://bugs.webkit.org/show_bug.cgi?id=226585
+
+        Reviewed by Eric Carlson.
+
+        Make sure to not update the preset if the constraints are equal to the current settings.
+        Manually tested.
+
+        * platform/mediastream/RealtimeVideoCaptureSource.cpp:
+        (WebCore::RealtimeVideoCaptureSource::clientUpdatedSizeAndFrameRate):
+
 2021-06-03  Alan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp

@@ -408 +408 @@
     // FIXME: We only change settings if capture resolution is below requested one. We should get the best preset for all clients.
     auto& settings = this->settings();
-    if (width && *width < static_cast<int>(settings.width()))
+    if (width && *width <= static_cast<int>(settings.width()))
         width = { };
-    if (height && *height < static_cast<int>(settings.height()))
+    if (height && *height <= static_cast<int>(settings.height()))
         height = { };
-    if (frameRate && *frameRate < static_cast<double>(settings.frameRate()))
+    if (frameRate && *frameRate <= static_cast<double>(settings.frameRate()))
         frameRate = { };