Changeset 278476 in webkit

Timestamp:

Jun 4, 2021 11:14:46 AM (3 years ago)

Author:

fpizlo@apple.com

Message:

Don't emit the NotDouble checks if we're already NotDouble.

Rubber stamped by Saam Barati.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::speculateNotDouble):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::speculateNotDouble):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGSpeculativeJIT.cpp (modified) (1 diff)
• ftl/FTLLowerDFGToB3.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-06-04  Filip Pizlo  <fpizlo@apple.com>
+
+        Don't emit the NotDouble checks if we're already NotDouble.
+
+        Rubber stamped by Saam Barati.
+
+        * dfg/DFGSpeculativeJIT.cpp:
+        (JSC::DFG::SpeculativeJIT::speculateNotDouble):
+        * ftl/FTLLowerDFGToB3.cpp:
+        (JSC::FTL::DFG::LowerDFGToB3::speculateNotDouble):
+
 2021-06-04  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp

@@ -11435 +11435 @@
 void SpeculativeJIT::speculateNotDouble(Edge edge)
 {
+    if (!needsTypeCheck(edge, ~SpecFullDouble))
+        return;
+    
     JSValueOperand operand(this, edge, ManualOperandSpeculation);
     GPRTemporary temp(this);

trunk/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp

@@ -18454 +18454 @@
     void speculateNotDouble(Edge edge)
     {
+        if (!m_interpreter.needsTypeCheck(edge))
+            return;
+    
         LValue value = lowJSValue(edge, ManualOperandSpeculation);