Changeset 278616 in webkit

Timestamp:

Jun 8, 2021, 9:54:34 AM (5 years ago)

Author:

weinig@apple.com

Message:

Add copy of std::span so that we can use it pre-moving to c++20
​https://bugs.webkit.org/show_bug.cgi?id=226351

Reviewed by Alex Christensen.

Source/WTF:

Imports a copy of Tristan Brindle's Boost licensed implementation of std::span
from 5d8d366eca918d0ed3d2d196cbeae6abfd874736 of ​https://github.com/tcbrindle/span.

It has been further modified to rename tcb::span to WTF::Span.

• LICENSE_1_0-Boost.txt: Added.
• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/Span.h: Added.

Tools:

Add basic WTF::Span test to make sure things compile and work.

• TestWebKitAPI/CMakeLists.txt:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WTF/Span.cpp: Added.

Location:

trunk

Files:

• Source/WTF/ChangeLog (modified) (1 diff)
• Source/WTF/LICENSE_1_0-Boost.txt (added)
• Source/WTF/WTF.xcodeproj/project.pbxproj (modified) (2 diffs)
• Source/WTF/wtf/CMakeLists.txt (modified) (1 diff)
• Source/WTF/wtf/Span.h (added)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/CMakeLists.txt (modified) (1 diff)
• Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (modified) (4 diffs)
• Tools/TestWebKitAPI/Tests/WTF/Span.cpp (added)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2021-06-08  Sam Weinig  <weinig@apple.com>
+
+        Add copy of std::span so that we can use it pre-moving to c++20
+        https://bugs.webkit.org/show_bug.cgi?id=226351
+
+        Reviewed by Alex Christensen.
+
+        Imports a copy of Tristan Brindle's Boost licensed implementation of std::span 
+        from 5d8d366eca918d0ed3d2d196cbeae6abfd874736 of https://github.com/tcbrindle/span.
+
+        It has been further modified to rename tcb::span to WTF::Span.
+
+        * LICENSE_1_0-Boost.txt: Added.
+        * WTF.xcodeproj/project.pbxproj:
+        * wtf/CMakeLists.txt:
+        * wtf/Span.h: Added.
+
 2021-06-07  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WTF/WTF.xcodeproj/project.pbxproj

@@ -692 +692 @@
                 ADF2CE641E39F106006889DB /* MemoryFootprint.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MemoryFootprint.h; sourceTree = "<group>"; };
                 ADF2CE651E39F106006889DB /* MemoryFootprintCocoa.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = MemoryFootprintCocoa.cpp; sourceTree = "<group>"; };
+                BCA30C7F266D3034000D230C /* Span.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = Span.h; sourceTree = "<group>"; };
                 C2BCFC3E1F61D13000C9222C /* Language.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = Language.cpp; sourceTree = "<group>"; };
                 C2BCFC3F1F61D13000C9222C /* Language.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Language.h; sourceTree = "<group>"; };
@@ -1258 +1259 @@
                                 93156C8D262C982200EAE27B /* SortedArrayMap.h */,
                                 79038E05224B05A7004C0738 /* SpanningTree.h */,
+                                BCA30C7F266D3034000D230C /* Span.h */,
                                 A8A4730D151A825B004123FF /* Spectrum.h */,
                                 A8A4730E151A825B004123FF /* StackBounds.cpp */,

trunk/Source/WTF/wtf/CMakeLists.txt

@@ -241 +241 @@
     SoftLinking.h
     SortedArrayMap.h
+    Span.h
     SpanningTree.h
     Spectrum.h

trunk/Tools/ChangeLog

@@ +1 @@
+2021-06-08  Sam Weinig  <weinig@apple.com>
+
+        Add copy of std::span so that we can use it pre-moving to c++20
+        https://bugs.webkit.org/show_bug.cgi?id=226351
+
+        Reviewed by Alex Christensen.
+
+        Add basic WTF::Span test to make sure things compile and work.
+
+        * TestWebKitAPI/CMakeLists.txt:
+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+        * TestWebKitAPI/Tests/WTF/Span.cpp: Added.
+
 2021-06-08  Sam Weinig  <weinig@apple.com>
 

trunk/Tools/TestWebKitAPI/CMakeLists.txt

@@ -85 +85 @@
     Tests/WTF/ScopedLambda.cpp
     Tests/WTF/SetForScope.cpp
+    Tests/WTF/Span.cpp
     Tests/WTF/StdLibExtras.cpp
     Tests/WTF/StringBuilder.cpp

trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

@@ -982 +982 @@
                 BC575BE0126F590D006F0F12 /* PlatformUtilitiesMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = BC131884117114B600B69727 /* PlatformUtilitiesMac.mm */; };
                 BC909784125571CF00083756 /* simple.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = BC909778125571AB00083756 /* simple.html */; };
+                BCA30C7E266D2F43000D230C /* Span.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BCA30C7D266D2F43000D230C /* Span.cpp */; };
                 BCAA485614A0444C0088FAC4 /* simple-tall.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = BCAA485514A021640088FAC4 /* simple-tall.html */; };
                 BCB68042126FBFF100642A61 /* DocumentStartUserScriptAlertCrash_Bundle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BCB68041126FBFF100642A61 /* DocumentStartUserScriptAlertCrash_Bundle.cpp */; };
@@ -2748 +2749 @@
                 BC90995D12567BC100083756 /* WKString.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WKString.cpp; sourceTree = "<group>"; };
                 BC9099931256ACF100083756 /* WKStringJSString.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WKStringJSString.cpp; sourceTree = "<group>"; };
+                BCA30C7D266D2F43000D230C /* Span.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = Span.cpp; sourceTree = "<group>"; };
                 BCAA485514A021640088FAC4 /* simple-tall.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = "simple-tall.html"; sourceTree = "<group>"; };
                 BCAA485714A044D40088FAC4 /* EditorCommands.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = EditorCommands.mm; sourceTree = "<group>"; };
@@ -4485 +4487 @@
                                 33C2C9C02651F5B900E407F6 /* SmallSet.cpp */,
                                 93FCDB33263631560046DD7D /* SortedArrayMap.cpp */,
+                                BCA30C7D266D2F43000D230C /* Span.cpp */,
                                 FE2BCDC62470FC7000DEC33B /* StdLibExtras.cpp */,
                                 81B50192140F232300D9EB58 /* StringBuilder.cpp */,
@@ -5193 +5196 @@
                                 A310827221F296FF00C28B97 /* FileSystem.cpp in Sources */,
                                 E3210519261979F300157C67 /* FixedVector.cpp in Sources */,
+                                BCA30C7E266D2F43000D230C /* Span.cpp in Sources */,
                                 9310CD381EF708FB0050FFE0 /* Function.cpp in Sources */,
                                 6BFD294C1D5E6C1D008EC968 /* HashCountedSet.cpp in Sources */,