Changeset 278663 in webkit

Timestamp:

Jun 9, 2021, 9:33:46 AM (5 years ago)

Author:

Peng Liu

Message:

[iOS] UIDelegate::UIClient::fullscreenMayReturnToInline() is not called when a video exits fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=226785

Reviewed by Eric Carlson.

On iOS, UIDelegate::UIClient::fullscreenMayReturnToInline() is called when
a video exits picture-in-picture, but not when a video exits fullscreen.
This patch fixes that.

We cannot add a regression test for this patch before fixing webkit.org/b/212654.

• UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

(WebKit::VideoFullscreenManagerProxy::exitFullscreen):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Cocoa/VideoFullscreenManagerProxy.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-06-09  Peng Liu  <peng.liu6@apple.com>
+
+        [iOS] UIDelegate::UIClient::fullscreenMayReturnToInline() is not called when a video exits fullscreen
+        https://bugs.webkit.org/show_bug.cgi?id=226785
+
+        Reviewed by Eric Carlson.
+
+        On iOS, `UIDelegate::UIClient::fullscreenMayReturnToInline()` is called when
+        a video exits picture-in-picture, but not when a video exits fullscreen.
+        This patch fixes that.
+
+        We cannot add a regression test for this patch before fixing webkit.org/b/212654.
+
+        * UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
+        (WebKit::VideoFullscreenManagerProxy::exitFullscreen):
+
 2021-06-09  Diego Pino Garcia  <dpino@igalia.com>
 

trunk/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm

@@ -626 +626 @@
     IntRect finalWindowRect;
     m_page->rootViewToWindow(enclosingIntRect(finalRect), finalWindowRect);
+#else
+    if (hasMode(WebCore::HTMLMediaElementEnums::VideoFullscreenModeStandard))
+        m_page->fullscreenMayReturnToInline();
 #endif