Changeset 278667 in webkit

Timestamp:

Jun 9, 2021, 11:33:58 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

[css-counter-styles] Mark counter-style descriptors as "descriptor-only"
​https://bugs.webkit.org/show_bug.cgi?id=226792

Patch by Tyler Wilcock <Tyler Wilcock> on 2021-06-09
Reviewed by Simon Fraser.

• css/CSSProperties.json:

Mark @counter-style rule descriptors (additive-symbols, fallback, pad,
symbols, negative, prefix, range, suffix, system) as "descriptor-only".

Note that while speak-as is also a valid descriptor for
@counter-style rules, it is deliberately excluded from this change as
it is also a property in the CSS Speech specification.

​https://www.w3.org/TR/css-speech-1/#speaking-props-speak-as

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSProperties.json (modified) (9 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-06-09  Tyler Wilcock  <twilco.o@protonmail.com>
+
+        [css-counter-styles] Mark counter-style descriptors as "descriptor-only"
+        https://bugs.webkit.org/show_bug.cgi?id=226792
+
+        Reviewed by Simon Fraser.
+
+        * css/CSSProperties.json:
+        Mark @counter-style rule descriptors (additive-symbols, fallback, pad,
+        symbols, negative, prefix, range, suffix, system) as "descriptor-only".
+
+        Note that while `speak-as` is also a valid descriptor for
+        @counter-style rules, it is deliberately excluded from this change as
+        it is also a property in the CSS Speech specification.
+
+        https://www.w3.org/TR/css-speech-1/#speaking-props-speak-as
+
 2021-06-09  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebCore/css/CSSProperties.json

@@ -821 +821 @@
         "additive-symbols": {
             "codegen-properties": {
+                "descriptor-only": true,
                 "settings-flag": "cssCounterStyleAtRules",
                 "skip-builder": true
@@ -2494 +2495 @@
         "fallback": {
             "codegen-properties": {
+                "descriptor-only": true,
                 "settings-flag": "cssCounterStyleAtRules",
                 "skip-builder": true
@@ -3462 +3464 @@
         "pad": {
             "codegen-properties": {
+                "descriptor-only": true,
                 "settings-flag": "cssCounterStyleAtRules",
                 "skip-builder": true
@@ -3953 +3956 @@
         "symbols": {
             "codegen-properties": {
+                "descriptor-only": true,
                 "settings-flag": "cssCounterStyleAtRules",
                 "skip-builder": true
@@ -6160 +6164 @@
         "negative": {
             "codegen-properties": {
+                "descriptor-only": true,
                 "settings-flag": "cssCounterStyleAtRules",
                 "skip-builder": true
@@ -6255 +6260 @@
         "prefix": {
             "codegen-properties": {
+                "descriptor-only": true,
                 "settings-flag": "cssCounterStyleAtRules",
                 "skip-builder": true
@@ -6273 +6279 @@
         "range": {
             "codegen-properties": {
+                "descriptor-only": true,
                 "settings-flag": "cssCounterStyleAtRules",
                 "skip-builder": true
@@ -6295 +6302 @@
         "suffix": {
             "codegen-properties": {
+                "descriptor-only": true,
                 "settings-flag": "cssCounterStyleAtRules",
                 "skip-builder": true
@@ -7139 +7147 @@
         "system": {
             "codegen-properties": {
+                "descriptor-only": true,
                 "settings-flag": "cssCounterStyleAtRules",
                 "skip-builder": true