Changeset 278674 in webkit

Timestamp:

Jun 9, 2021, 2:28:59 PM (5 years ago)

Author:

Ryan Haddad

Message:

[test-webkit-lldb] 3 dump_class_layout_unittest.TestDumpClassLayout tests failing with Xcode 12.5
​https://bugs.webkit.org/show_bug.cgi?id=226540

Unreviewed test gardening.

• lldb/dump_class_layout_unittest.py: Rebaseline tests.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• lldb/dump_class_layout_unittest.py (modified) (6 diffs)

trunk/Tools/ChangeLog

@@ -94 +94 @@
         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp:
         (TestWebKitAPI::TEST):
+
+2021-06-09  Ryan Haddad  <ryanhaddad@apple.com>
+
+        [test-webkit-lldb] 3 dump_class_layout_unittest.TestDumpClassLayout tests failing with Xcode 12.5
+        https://bugs.webkit.org/show_bug.cgi?id=226540
+
+        Unreviewed test gardening.
+
+        * lldb/dump_class_layout_unittest.py: Rebaseline tests.
 
 2021-06-08  Sam Weinig  <weinig@apple.com>

trunk/Tools/lldb/dump_class_layout_unittest.py

@@ -319 +319 @@
   +1 < :2>   unsigned long bitfield5 : 2
   +1 < :1>   <UNUSED BITS: 1 bit>
-  +2 <  2>   <PADDING: 2 bytes>
+  +2 <  1>   <PADDING: 1 bytes>
   +4 <  4>   int intMember
   +8 < :1>   unsigned int bitfield7 : 1
@@ -327 +327 @@
  +10 <  6>   <PADDING: 6 bytes>
 Total byte size: 16
-Total pad bytes: 8
-Padding percentage: 50.00 %"""
+Total pad bytes: 7
+Padding percentage: 49.22 %"""
         actual_layout = debugger_instance.layout_for_classname('ClassWithPaddedBitfields')
         self.assertEqual(EXPECTED_RESULT, actual_layout.as_string())
@@ -342 +342 @@
   +1 < :2>       unsigned long bitfield5 : 2
   +1 < :1>       <UNUSED BITS: 1 bit>
-  +2 <  2>       <PADDING: 2 bytes>
+  +2 <  1>       <PADDING: 1 bytes>
   +4 <  4>       int intMember
   +8 < :1>       unsigned int bitfield7 : 1
@@ -353 +353 @@
  +17 <  7>   <PADDING: 7 bytes>
 Total byte size: 24
-Total pad bytes: 15
-Padding percentage: 62.50 %"""
+Total pad bytes: 14
+Padding percentage: 61.98 %"""
         actual_layout = debugger_instance.layout_for_classname('MemberHasBitfieldPadding')
         self.assertEqual(EXPECTED_RESULT, actual_layout.as_string())
@@ -368 +368 @@
   +1 < :2>       unsigned long bitfield5 : 2
   +1 < :1>       <UNUSED BITS: 1 bit>
-  +2 <  2>       <PADDING: 2 bytes>
+  +2 <  1>       <PADDING: 1 bytes>
   +4 <  4>       int intMember
   +8 < :1>       unsigned int bitfield7 : 1
@@ -378 +378 @@
  +11 <  5>   <PADDING: 5 bytes>
 Total byte size: 16
-Total pad bytes: 7
-Padding percentage: 43.75 %"""
+Total pad bytes: 6
+Padding percentage: 42.97 %"""
         actual_layout = debugger_instance.layout_for_classname('InheritsFromClassWithPaddedBitfields')
         self.assertEqual(EXPECTED_RESULT, actual_layout.as_string())