Changeset 278681 in webkit

Timestamp:

Jun 9, 2021, 4:41:30 PM (5 years ago)

Author:

eric.carlson@apple.com

Message:

Nullptr crash in MediaSource::updateBufferedIfNeeded
​https://bugs.webkit.org/show_bug.cgi?id=226851
rdar://79059134

Reviewed by Devin Rousso.

No new tests, I was unable to come up with a reproducible case.

• Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::updateBufferedIfNeeded): NULL-check m_private.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediasource/MediaSource.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-06-09  Eric Carlson  <eric.carlson@apple.com>
+
+        Nullptr crash in MediaSource::updateBufferedIfNeeded
+        https://bugs.webkit.org/show_bug.cgi?id=226851
+        rdar://79059134
+
+        Reviewed by Devin Rousso.
+
+        No new tests, I was unable to come up with a reproducible case.
+
+        * Modules/mediasource/MediaSource.cpp:
+        (WebCore::MediaSource::updateBufferedIfNeeded): NULL-check `m_private`.
+
 2021-06-09  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp

@@ -1156 +1156 @@
     }
 
-    m_private->bufferedChanged(*m_buffered);
+    if (m_private)
+        m_private->bufferedChanged(*m_buffered);
 }