Changeset 278690 in webkit

Timestamp:

Jun 9, 2021, 8:23:49 PM (5 years ago)

Author:

Cameron McCormack

Message:

Add window.internals.log()
​https://bugs.webkit.org/show_bug.cgi?id=226403

Reviewed by Tim Horton.

window.internals.log() writes output to stderr using WTFLogAlways.
This may be useful for interleaving some output generated from within a
test with WebCore logging, which also goes to stderr. console.log()
doesn't work for this, since that goes to stdout and is captured as
the test output.

• testing/Internals.cpp:

(WebCore::Internals::log):

• testing/Internals.h:
• testing/Internals.idl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• testing/Internals.cpp (modified) (1 diff)
• testing/Internals.h (modified) (1 diff)
• testing/Internals.idl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-06-09  Cameron McCormack  <heycam@apple.com>
+
+        Add window.internals.log()
+        https://bugs.webkit.org/show_bug.cgi?id=226403
+
+        Reviewed by Tim Horton.
+
+        window.internals.log() writes output to stderr using WTFLogAlways.
+        This may be useful for interleaving some output generated from within a
+        test with WebCore logging, which also goes to stderr. console.log()
+        doesn't work for this, since that goes to stdout and is captured as
+        the test output.
+
+        * testing/Internals.cpp:
+        (WebCore::Internals::log):
+        * testing/Internals.h:
+        * testing/Internals.idl:
+
 2021-06-09  Cathie Chen  <cathiechen@igalia.com>
 

trunk/Source/WebCore/testing/Internals.cpp

@@ -768 +768 @@
 }
 
+void Internals::log(const String& value)
+{
+    WTFLogAlways("%s", value.utf8().data());
+}
+
 bool Internals::isPreloaded(const String& url)
 {

trunk/Source/WebCore/testing/Internals.h

@@ -170 +170 @@
     String styleChangeType(Node&);
     String description(JSC::JSValue);
+    void log(const String&);
 
     bool isPreloaded(const String& url);

trunk/Source/WebCore/testing/Internals.idl

@@ -281 +281 @@
     DOMString styleChangeType(Node node);
     DOMString description(any value);
+    undefined log(DOMString value);
 
     // Animated image pausing testing.