Changeset 278692 in webkit

Timestamp:

Jun 9, 2021, 9:52:56 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Null check page in generateCertificate
​https://bugs.webkit.org/show_bug.cgi?id=226798

Patch by Rob Buis <​rbuis@igalia.com> on 2021-06-09
Reviewed by Youenn Fablet.

Source/WebCore:

Null check page in generateCertificate.

Test: http/wpt/webrtc/RTCPeerConnection-generateCertificate-crash.html

• Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::generateCertificate):

LayoutTests:

• http/wpt/webrtc/RTCPeerConnection-generateCertificate-crash-expected.txt: Added.
• http/wpt/webrtc/RTCPeerConnection-generateCertificate-crash.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/wpt/webrtc/RTCPeerConnection-generateCertificate-crash-expected.txt (added)
• LayoutTests/http/wpt/webrtc/RTCPeerConnection-generateCertificate-crash.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-06-09  Rob Buis  <rbuis@igalia.com>
+
+        Null check page in generateCertificate
+        https://bugs.webkit.org/show_bug.cgi?id=226798
+
+        Reviewed by Youenn Fablet.
+
+        * http/wpt/webrtc/RTCPeerConnection-generateCertificate-crash-expected.txt: Added.
+        * http/wpt/webrtc/RTCPeerConnection-generateCertificate-crash.html: Added.
+
 2021-06-09  Andres Gonzalez  <andresg_22@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-06-09  Rob Buis  <rbuis@igalia.com>
+
+        Null check page in generateCertificate
+        https://bugs.webkit.org/show_bug.cgi?id=226798
+
+        Reviewed by Youenn Fablet.
+
+        Null check page in generateCertificate.
+
+        Test: http/wpt/webrtc/RTCPeerConnection-generateCertificate-crash.html
+
+        * Modules/mediastream/PeerConnectionBackend.cpp:
+        (WebCore::PeerConnectionBackend::generateCertificate):
+
 2021-06-09  Cameron McCormack  <heycam@apple.com>
 

trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp

@@ -607 +607 @@
 {
 #if USE(LIBWEBRTC)
-    LibWebRTCCertificateGenerator::generateCertificate(document.securityOrigin(), document.page()->libWebRTCProvider(), info, WTFMove(promise));
+    auto* page = document.page();
+    if (!page) {
+        promise.reject(InvalidStateError);
+        return;
+    }
+    LibWebRTCCertificateGenerator::generateCertificate(document.securityOrigin(), page->libWebRTCProvider(), info, WTFMove(promise));
 #else
     UNUSED_PARAM(document);