⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 278849 in webkit


Ignore:
Timestamp:
Jun 14, 2021, 2:36:12 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Pass PAL::SessionID by value instead of reference
​https://bugs.webkit.org/show_bug.cgi?id=226983

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-06-14
Reviewed by Geoffrey Garen.

Source/WebCore:

It's a wrapper around an integer which will pass in a register.
There's no reason to pass a pointer to it.

  • loader/CrossOriginAccessControl.cpp:

(WebCore::validatePreflightResponse):

  • loader/CrossOriginAccessControl.h:
  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCache::appendEntry):
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight):

  • loader/CrossOriginPreflightResultCache.h:
  • loader/EmptyClients.cpp:
  • loader/cache/CachedApplicationManifest.cpp:

(WebCore::CachedApplicationManifest::CachedApplicationManifest):

  • loader/cache/CachedApplicationManifest.h:
  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):

  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::CachedFont):

  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::CachedImage):

  • loader/cache/CachedImage.h:
  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::CachedRawResource):

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):

  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::updateCachedResourceWithCurrentRequest):

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedSVGDocument.cpp:

(WebCore::CachedSVGDocument::CachedSVGDocument):

  • loader/cache/CachedSVGDocument.h:
  • loader/cache/CachedSVGFont.cpp:

(WebCore::CachedSVGFont::CachedSVGFont):

  • loader/cache/CachedSVGFont.h:
  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::CachedScript):

  • loader/cache/CachedScript.h:
  • loader/cache/CachedTextTrack.cpp:

(WebCore::CachedTextTrack::CachedTextTrack):

  • loader/cache/CachedTextTrack.h:
  • loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):

  • loader/cache/CachedXSLStyleSheet.h:
  • page/DatabaseProvider.h:
  • platform/WebCoreCrossThreadCopier.cpp:

(WTF::PAL::SessionID>::copy):

  • platform/WebCoreCrossThreadCopier.h:
  • storage/StorageNamespaceProvider.cpp:

(WebCore::StorageNamespaceProvider::setSessionIDForTesting):

  • storage/StorageNamespaceProvider.h:

Source/WebKit:

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::newTestingSession):
(WebKit::NetworkProcess::ensureSession):
(WebKit::NetworkProcess::storageSession const):
(WebKit::NetworkProcess::findCacheEngine):
(WebKit::NetworkProcess::ensureCacheEngine):
(WebKit::NetworkProcess::removeCacheEngine):
(WebKit::NetworkProcess::flushCookies):
(WebKit::NetworkProcess::platformFlushCookies):
(WebKit::NetworkProcess::addWebPageNetworkParameters):
(WebKit::NetworkProcess::removeWebPageNetworkParameters):
(WebKit::NetworkProcess::countNonDefaultSessionSets):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::shouldLogCookieInformation):

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/NetworkStorageSessionProvider.h:
  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::makeUseDecision):

  • NetworkProcess/cache/NetworkCache.h:

(WebKit::NetworkCache::Cache::sessionID const):

  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::flushCookies):
(WebKit::NetworkProcess::platformFlushCookies):

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::configurationForSessionID):

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::flushCookies):

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebProcessPool.h:
  • WebProcess/Databases/WebDatabaseProvider.cpp:

(WebKit::WebDatabaseProvider::idbConnectionToServerForSession):

  • WebProcess/Databases/WebDatabaseProvider.h:

Source/WebKitLegacy:

  • Storage/WebDatabaseProvider.cpp:

(WebDatabaseProvider::idbConnectionToServerForSession):

  • Storage/WebDatabaseProvider.h:
  • WebCoreSupport/NetworkStorageSessionMap.cpp:

(NetworkStorageSessionMap::storageSession):
(NetworkStorageSessionMap::ensureSession):
(NetworkStorageSessionMap::destroySession):

  • WebCoreSupport/NetworkStorageSessionMap.h:
Location:
trunk/Source
Files:
55 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r278848 r278849  
     12021-06-14  Alex Christensen  <achristensen@webkit.org>
     2
     3        Pass PAL::SessionID by value instead of reference
     4        https://bugs.webkit.org/show_bug.cgi?id=226983
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        It's a wrapper around an integer which will pass in a register.
     9        There's no reason to pass a pointer to it.
     10
     11        * loader/CrossOriginAccessControl.cpp:
     12        (WebCore::validatePreflightResponse):
     13        * loader/CrossOriginAccessControl.h:
     14        * loader/CrossOriginPreflightResultCache.cpp:
     15        (WebCore::CrossOriginPreflightResultCache::appendEntry):
     16        (WebCore::CrossOriginPreflightResultCache::canSkipPreflight):
     17        * loader/CrossOriginPreflightResultCache.h:
     18        * loader/EmptyClients.cpp:
     19        * loader/cache/CachedApplicationManifest.cpp:
     20        (WebCore::CachedApplicationManifest::CachedApplicationManifest):
     21        * loader/cache/CachedApplicationManifest.h:
     22        * loader/cache/CachedCSSStyleSheet.cpp:
     23        (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
     24        * loader/cache/CachedCSSStyleSheet.h:
     25        * loader/cache/CachedFont.cpp:
     26        (WebCore::CachedFont::CachedFont):
     27        * loader/cache/CachedFont.h:
     28        * loader/cache/CachedImage.cpp:
     29        (WebCore::CachedImage::CachedImage):
     30        * loader/cache/CachedImage.h:
     31        * loader/cache/CachedRawResource.cpp:
     32        (WebCore::CachedRawResource::CachedRawResource):
     33        * loader/cache/CachedRawResource.h:
     34        * loader/cache/CachedResource.cpp:
     35        (WebCore::CachedResource::CachedResource):
     36        * loader/cache/CachedResource.h:
     37        * loader/cache/CachedResourceLoader.cpp:
     38        (WebCore::createResource):
     39        (WebCore::CachedResourceLoader::updateCachedResourceWithCurrentRequest):
     40        * loader/cache/CachedResourceLoader.h:
     41        * loader/cache/CachedSVGDocument.cpp:
     42        (WebCore::CachedSVGDocument::CachedSVGDocument):
     43        * loader/cache/CachedSVGDocument.h:
     44        * loader/cache/CachedSVGFont.cpp:
     45        (WebCore::CachedSVGFont::CachedSVGFont):
     46        * loader/cache/CachedSVGFont.h:
     47        * loader/cache/CachedScript.cpp:
     48        (WebCore::CachedScript::CachedScript):
     49        * loader/cache/CachedScript.h:
     50        * loader/cache/CachedTextTrack.cpp:
     51        (WebCore::CachedTextTrack::CachedTextTrack):
     52        * loader/cache/CachedTextTrack.h:
     53        * loader/cache/CachedXSLStyleSheet.cpp:
     54        (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
     55        * loader/cache/CachedXSLStyleSheet.h:
     56        * page/DatabaseProvider.h:
     57        * platform/WebCoreCrossThreadCopier.cpp:
     58        (WTF::PAL::SessionID>::copy):
     59        * platform/WebCoreCrossThreadCopier.h:
     60        * storage/StorageNamespaceProvider.cpp:
     61        (WebCore::StorageNamespaceProvider::setSessionIDForTesting):
     62        * storage/StorageNamespaceProvider.h:
     63
    1642021-06-14  Patrick Angle  <pangle@apple.com>
    265

  • trunk/Source/WebCore/loader/CrossOriginAccessControl.cpp

    r278800 r278849  
    258258}
    259259
    260 Expected<void, String> validatePreflightResponse(const PAL::SessionID& sessionID, const ResourceRequest& request, const ResourceResponse& response, StoredCredentialsPolicy storedCredentialsPolicy, const SecurityOrigin& securityOrigin, const CrossOriginAccessControlCheckDisabler* checkDisabler)
     260Expected<void, String> validatePreflightResponse(PAL::SessionID sessionID, const ResourceRequest& request, const ResourceResponse& response, StoredCredentialsPolicy storedCredentialsPolicy, const SecurityOrigin& securityOrigin, const CrossOriginAccessControlCheckDisabler* checkDisabler)
    261261{
    262262    if (!response.isSuccessful())

  • trunk/Source/WebCore/loader/CrossOriginAccessControl.h

    r278800 r278849  
    8383
    8484WEBCORE_EXPORT Expected<void, String> passesAccessControlCheck(const ResourceResponse&, StoredCredentialsPolicy, const SecurityOrigin&, const CrossOriginAccessControlCheckDisabler*);
    85 WEBCORE_EXPORT Expected<void, String> validatePreflightResponse(const PAL::SessionID&, const ResourceRequest&, const ResourceResponse&, StoredCredentialsPolicy, const SecurityOrigin&, const CrossOriginAccessControlCheckDisabler*);
     85WEBCORE_EXPORT Expected<void, String> validatePreflightResponse(PAL::SessionID, const ResourceRequest&, const ResourceResponse&, StoredCredentialsPolicy, const SecurityOrigin&, const CrossOriginAccessControlCheckDisabler*);
    8686
    8787WEBCORE_EXPORT std::optional<ResourceError> validateCrossOriginResourcePolicy(const SecurityOrigin&, const URL&, const ResourceResponse&);

  • trunk/Source/WebCore/loader/CrossOriginPreflightResultCache.cpp

    r278800 r278849  
    122122}
    123123
    124 void CrossOriginPreflightResultCache::appendEntry(const PAL::SessionID& sessionID, const String& origin, const URL& url, std::unique_ptr<CrossOriginPreflightResultCacheItem> preflightResult)
     124void CrossOriginPreflightResultCache::appendEntry(PAL::SessionID sessionID, const String& origin, const URL& url, std::unique_ptr<CrossOriginPreflightResultCacheItem> preflightResult)
    125125{
    126126    ASSERT(isMainThread());
    … …  
    128128}
    129129
    130 bool CrossOriginPreflightResultCache::canSkipPreflight(const PAL::SessionID& sessionID, const String& origin, const URL& url, StoredCredentialsPolicy storedCredentialsPolicy, const String& method, const HTTPHeaderMap& requestHeaders)
     130bool CrossOriginPreflightResultCache::canSkipPreflight(PAL::SessionID sessionID, const String& origin, const URL& url, StoredCredentialsPolicy storedCredentialsPolicy, const String& method, const HTTPHeaderMap& requestHeaders)
    131131{
    132132    ASSERT(isMainThread());

  • trunk/Source/WebCore/loader/CrossOriginPreflightResultCache.h

    r278800 r278849  
    6868public:
    6969    WEBCORE_EXPORT static CrossOriginPreflightResultCache& singleton();
    70     WEBCORE_EXPORT void appendEntry(const PAL::SessionID&, const String& origin, const URL&, std::unique_ptr<CrossOriginPreflightResultCacheItem>);
    71     WEBCORE_EXPORT bool canSkipPreflight(const PAL::SessionID&, const String& origin, const URL&, StoredCredentialsPolicy, const String& method, const HTTPHeaderMap& requestHeaders);
     70    WEBCORE_EXPORT void appendEntry(PAL::SessionID, const String& origin, const URL&, std::unique_ptr<CrossOriginPreflightResultCacheItem>);
     71    WEBCORE_EXPORT bool canSkipPreflight(PAL::SessionID, const String& origin, const URL&, StoredCredentialsPolicy, const String& method, const HTTPHeaderMap& requestHeaders);
    7272    WEBCORE_EXPORT void clear();
    7373

  • trunk/Source/WebCore/loader/EmptyClients.cpp

    r278630 r278849  
    203203    };
    204204
    205     IDBClient::IDBConnectionToServer& idbConnectionToServerForSession(const PAL::SessionID&) final
     205    IDBClient::IDBConnectionToServer& idbConnectionToServerForSession(PAL::SessionID) final
    206206    {
    207207        static NeverDestroyed<EmptyIDBConnectionToServerDeletegate> emptyDelegate;

  • trunk/Source/WebCore/loader/cache/CachedApplicationManifest.cpp

    r278253 r278849  
    3535namespace WebCore {
    3636
    37 CachedApplicationManifest::CachedApplicationManifest(CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
     37CachedApplicationManifest::CachedApplicationManifest(CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar)
    3838    : CachedResource(WTFMove(request), Type::ApplicationManifest, sessionID, cookieJar)
    3939    , m_decoder(TextResourceDecoder::create("application/manifest+json", UTF8Encoding()))

  • trunk/Source/WebCore/loader/cache/CachedApplicationManifest.h

    r278340 r278849  
    3838class CachedApplicationManifest final : public CachedResource {
    3939public:
    40     CachedApplicationManifest(CachedResourceRequest&&, const PAL::SessionID&, const CookieJar*);
     40    CachedApplicationManifest(CachedResourceRequest&&, PAL::SessionID, const CookieJar*);
    4141
    4242    std::optional<struct ApplicationManifest> process(const URL& manifestURL, const URL& documentURL, Document* = nullptr);

  • trunk/Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp

    r264566 r278849  
    3939namespace WebCore {
    4040
    41 CachedCSSStyleSheet::CachedCSSStyleSheet(CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
     41CachedCSSStyleSheet::CachedCSSStyleSheet(CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar)
    4242    : CachedResource(WTFMove(request), Type::CSSStyleSheet, sessionID, cookieJar)
    4343    , m_decoder(TextResourceDecoder::create("text/css", request.charset()))

  • trunk/Source/WebCore/loader/cache/CachedCSSStyleSheet.h

    r261597 r278849  
    3535class CachedCSSStyleSheet final : public CachedResource {
    3636public:
    37     CachedCSSStyleSheet(CachedResourceRequest&&, const PAL::SessionID&, const CookieJar*);
     37    CachedCSSStyleSheet(CachedResourceRequest&&, PAL::SessionID, const CookieJar*);
    3838    virtual ~CachedCSSStyleSheet();
    3939

  • trunk/Source/WebCore/loader/cache/CachedFont.cpp

    r276450 r278849  
    4242namespace WebCore {
    4343
    44 CachedFont::CachedFont(CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar, Type type)
     44CachedFont::CachedFont(CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar, Type type)
    4545    : CachedResource(WTFMove(request), type, sessionID, cookieJar)
    4646    , m_loadInitiated(false)

  • trunk/Source/WebCore/loader/cache/CachedFont.h

    r273094 r278849  
    3030#include "Font.h"
    3131#include "TextFlags.h"
     32#include <pal/SessionID.h>
    3233
    3334namespace WebCore {
    … …  
    4647class CachedFont : public CachedResource {
    4748public:
    48     CachedFont(CachedResourceRequest&&, const PAL::SessionID&, const CookieJar*, Type = Type::FontResource);
     49    CachedFont(CachedResourceRequest&&, PAL::SessionID, const CookieJar*, Type = Type::FontResource);
    4950    virtual ~CachedFont();
    5051

  • trunk/Source/WebCore/loader/cache/CachedImage.cpp

    r278516 r278849  
    5656namespace WebCore {
    5757
    58 CachedImage::CachedImage(CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
     58CachedImage::CachedImage(CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar)
    5959    : CachedResource(WTFMove(request), Type::ImageResource, sessionID, cookieJar)
    6060    , m_updateImageDataCount(0)
    … …  
    6666}
    6767
    68 CachedImage::CachedImage(Image* image, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
     68CachedImage::CachedImage(Image* image, PAL::SessionID sessionID, const CookieJar* cookieJar)
    6969    : CachedResource(URL(), Type::ImageResource, sessionID, cookieJar)
    7070    , m_image(image)
    … …  
    7676}
    7777
    78 CachedImage::CachedImage(const URL& url, Image* image, const PAL::SessionID& sessionID, const CookieJar* cookieJar, const String& domainForCachePartition)
     78CachedImage::CachedImage(const URL& url, Image* image, PAL::SessionID sessionID, const CookieJar* cookieJar, const String& domainForCachePartition)
    7979    : CachedResource(url, Type::ImageResource, sessionID, cookieJar)
    8080    , m_image(image)

  • trunk/Source/WebCore/loader/cache/CachedImage.h

    r278516 r278849  
    4848
    4949public:
    50     CachedImage(CachedResourceRequest&&, const PAL::SessionID&, const CookieJar*);
    51     CachedImage(Image*, const PAL::SessionID&, const CookieJar*);
     50    CachedImage(CachedResourceRequest&&, PAL::SessionID, const CookieJar*);
     51    CachedImage(Image*, PAL::SessionID, const CookieJar*);
    5252    // Constructor to use for manually cached images.
    53     CachedImage(const URL&, Image*, const PAL::SessionID&, const CookieJar*, const String& domainForCachePartition);
     53    CachedImage(const URL&, Image*, PAL::SessionID, const CookieJar*, const String& domainForCachePartition);
    5454    virtual ~CachedImage();
    5555

  • trunk/Source/WebCore/loader/cache/CachedRawResource.cpp

    r278702 r278849  
    4242namespace WebCore {
    4343
    44 CachedRawResource::CachedRawResource(CachedResourceRequest&& request, Type type, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
     44CachedRawResource::CachedRawResource(CachedResourceRequest&& request, Type type, PAL::SessionID sessionID, const CookieJar* cookieJar)
    4545    : CachedResource(WTFMove(request), type, sessionID, cookieJar)
    4646    , m_identifier(0)

  • trunk/Source/WebCore/loader/cache/CachedRawResource.h

    r278516 r278849  
    3333class CachedRawResource final : public CachedResource {
    3434public:
    35     CachedRawResource(CachedResourceRequest&&, Type, const PAL::SessionID&, const CookieJar*);
     35    CachedRawResource(CachedResourceRequest&&, Type, PAL::SessionID, const CookieJar*);
    3636
    3737    void setDefersLoading(bool);

  • trunk/Source/WebCore/loader/cache/CachedResource.cpp

    r278793 r278849  
    8484DEFINE_DEBUG_ONLY_GLOBAL(WTF::RefCountedLeakCounter, cachedResourceLeakCounter, ("CachedResource"));
    8585
    86 CachedResource::CachedResource(CachedResourceRequest&& request, Type type, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
     86CachedResource::CachedResource(CachedResourceRequest&& request, Type type, PAL::SessionID sessionID, const CookieJar* cookieJar)
    8787    : m_options(request.options())
    8888    , m_resourceRequest(request.releaseResourceRequest())
    … …  
    122122
    123123// FIXME: For this constructor, we should probably mandate that the URL has no fragment identifier.
    124 CachedResource::CachedResource(const URL& url, Type type, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
     124CachedResource::CachedResource(const URL& url, Type type, PAL::SessionID sessionID, const CookieJar* cookieJar)
    125125    : m_resourceRequest(url)
    126126    , m_decodedDataDeletionTimer(*this, &CachedResource::destroyDecodedData, deadDecodedDataDeletionIntervalForResourceType(type))

  • trunk/Source/WebCore/loader/cache/CachedResource.h

    r278516 r278849  
    104104    static_assert(static_cast<unsigned>(DecodeError) <= ((1ULL << bitWidthOfStatus) - 1));
    105105
    106     CachedResource(CachedResourceRequest&&, Type, const PAL::SessionID&, const CookieJar*);
     106    CachedResource(CachedResourceRequest&&, Type, PAL::SessionID, const CookieJar*);
    107107    virtual ~CachedResource();
    108108
    … …  
    297297protected:
    298298    // CachedResource constructor that may be used when the CachedResource can already be filled with response data.
    299     CachedResource(const URL&, Type, const PAL::SessionID&, const CookieJar*);
     299    CachedResource(const URL&, Type, PAL::SessionID, const CookieJar*);
    300300
    301301    void setEncodedSize(unsigned);

  • trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp

    r278779 r278849  
    114114}
    115115
    116 static CachedResourceHandle<CachedResource> createResource(CachedResource::Type type, CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar, const Settings& settings)
     116static CachedResourceHandle<CachedResource> createResource(CachedResource::Type type, CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar, const Settings& settings)
    117117{
    118118    switch (type) {
    … …  
    745745}
    746746
    747 CachedResourceHandle<CachedResource> CachedResourceLoader::updateCachedResourceWithCurrentRequest(const CachedResource& resource, CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar& cookieJar, const Settings& settings)
     747CachedResourceHandle<CachedResource> CachedResourceLoader::updateCachedResourceWithCurrentRequest(const CachedResource& resource, CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar& cookieJar, const Settings& settings)
    748748{
    749749    if (!isResourceSuitableForDirectReuse(resource, request)) {

  • trunk/Source/WebCore/loader/cache/CachedResourceLoader.h

    r278779 r278849  
    187187
    188188    bool shouldUpdateCachedResourceWithCurrentRequest(const CachedResource&, const CachedResourceRequest&);
    189     CachedResourceHandle<CachedResource> updateCachedResourceWithCurrentRequest(const CachedResource&, CachedResourceRequest&&, const PAL::SessionID&, const CookieJar&, const Settings&);
     189    CachedResourceHandle<CachedResource> updateCachedResourceWithCurrentRequest(const CachedResource&, CachedResourceRequest&&, PAL::SessionID, const CookieJar&, const Settings&);
    190190
    191191    bool shouldContinueAfterNotifyingLoadedFromMemoryCache(const CachedResourceRequest&, CachedResource&, ResourceError&);

  • trunk/Source/WebCore/loader/cache/CachedSVGDocument.cpp

    r268114 r278849  
    2929namespace WebCore {
    3030
    31 CachedSVGDocument::CachedSVGDocument(CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar, const Settings& settings)
     31CachedSVGDocument::CachedSVGDocument(CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar, const Settings& settings)
    3232    : CachedResource(WTFMove(request), Type::SVGDocumentResource, sessionID, cookieJar)
    3333    , m_decoder(TextResourceDecoder::create("application/xml"))

  • trunk/Source/WebCore/loader/cache/CachedSVGDocument.h

    r268114 r278849  
    3333class CachedSVGDocument final : public CachedResource {
    3434public:
    35     explicit CachedSVGDocument(CachedResourceRequest&&, const PAL::SessionID&, const CookieJar*, const Settings&);
     35    explicit CachedSVGDocument(CachedResourceRequest&&, PAL::SessionID, const CookieJar*, const Settings&);
    3636    explicit CachedSVGDocument(CachedResourceRequest&&, CachedSVGDocument&);
    3737    virtual ~CachedSVGDocument();

  • trunk/Source/WebCore/loader/cache/CachedSVGFont.cpp

    r268114 r278849  
    4242namespace WebCore {
    4343
    44 CachedSVGFont::CachedSVGFont(CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar, const Settings& settings)
     44CachedSVGFont::CachedSVGFont(CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar, const Settings& settings)
    4545    : CachedFont(WTFMove(request), sessionID, cookieJar, Type::SVGFontResource)
    4646    , m_externalSVGFontElement(nullptr)

  • trunk/Source/WebCore/loader/cache/CachedSVGFont.h

    r268114 r278849  
    3535class CachedSVGFont final : public CachedFont {
    3636public:
    37     CachedSVGFont(CachedResourceRequest&&, const PAL::SessionID&, const CookieJar*, const Settings&);
     37    CachedSVGFont(CachedResourceRequest&&, PAL::SessionID, const CookieJar*, const Settings&);
    3838    CachedSVGFont(CachedResourceRequest&&, CachedSVGFont&);
    3939

  • trunk/Source/WebCore/loader/cache/CachedScript.cpp

    r278619 r278849  
    3737namespace WebCore {
    3838
    39 CachedScript::CachedScript(CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
     39CachedScript::CachedScript(CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar)
    4040    : CachedResource(WTFMove(request), Type::Script, sessionID, cookieJar)
    4141    , m_decoder(TextResourceDecoder::create("text/javascript"_s, request.charset()))

  • trunk/Source/WebCore/loader/cache/CachedScript.h

    r261597 r278849  
    3434class CachedScript final : public CachedResource {
    3535public:
    36     CachedScript(CachedResourceRequest&&, const PAL::SessionID&, const CookieJar*);
     36    CachedScript(CachedResourceRequest&&, PAL::SessionID, const CookieJar*);
    3737    virtual ~CachedScript();
    3838

  • trunk/Source/WebCore/loader/cache/CachedTextTrack.cpp

    r262695 r278849  
    3636namespace WebCore {
    3737
    38 CachedTextTrack::CachedTextTrack(CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
     38CachedTextTrack::CachedTextTrack(CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar)
    3939    : CachedResource(WTFMove(request), Type::TextTrackResource, sessionID, cookieJar)
    4040{

  • trunk/Source/WebCore/loader/cache/CachedTextTrack.h

    r262695 r278849  
    3232class CachedTextTrack final : public CachedResource {
    3333public:
    34     CachedTextTrack(CachedResourceRequest&&, const PAL::SessionID&, const CookieJar*);
     34    CachedTextTrack(CachedResourceRequest&&, PAL::SessionID, const CookieJar*);
    3535
    3636private:

  • trunk/Source/WebCore/loader/cache/CachedXSLStyleSheet.cpp

    r261597 r278849  
    3737#if ENABLE(XSLT)
    3838
    39 CachedXSLStyleSheet::CachedXSLStyleSheet(CachedResourceRequest&& request, const PAL::SessionID& sessionID, const CookieJar* cookieJar)
     39CachedXSLStyleSheet::CachedXSLStyleSheet(CachedResourceRequest&& request, PAL::SessionID sessionID, const CookieJar* cookieJar)
    4040    : CachedResource(WTFMove(request), Type::XSLStyleSheet, sessionID, cookieJar)
    4141    , m_decoder(TextResourceDecoder::create("text/xsl"))

  • trunk/Source/WebCore/loader/cache/CachedXSLStyleSheet.h

    r261597 r278849  
    3636class CachedXSLStyleSheet final : public CachedResource {
    3737public:
    38     CachedXSLStyleSheet(CachedResourceRequest&&, const PAL::SessionID&, const CookieJar*);
     38    CachedXSLStyleSheet(CachedResourceRequest&&, PAL::SessionID, const CookieJar*);
    3939    virtual ~CachedXSLStyleSheet();
    4040

  • trunk/Source/WebCore/page/DatabaseProvider.h

    r275151 r278849  
    4141public:
    4242    virtual ~DatabaseProvider();
    43     virtual IDBClient::IDBConnectionToServer& idbConnectionToServerForSession(const PAL::SessionID&) = 0;
     43    virtual IDBClient::IDBConnectionToServer& idbConnectionToServerForSession(PAL::SessionID) = 0;
    4444};
    4545

  • trunk/Source/WebCore/platform/WebCoreCrossThreadCopier.cpp

    r220887 r278849  
    3737namespace WTF {
    3838
    39 CrossThreadCopierBase<false, false, PAL::SessionID>::Type CrossThreadCopierBase<false, false, PAL::SessionID>::copy(const PAL::SessionID& sessionID)
     39CrossThreadCopierBase<false, false, PAL::SessionID>::Type CrossThreadCopierBase<false, false, PAL::SessionID>::copy(PAL::SessionID sessionID)
    4040{
    4141    return sessionID;

  • trunk/Source/WebCore/platform/WebCoreCrossThreadCopier.h

    r220857 r278849  
    4646template<> struct CrossThreadCopierBase<false, false, PAL::SessionID> {
    4747    typedef PAL::SessionID Type;
    48     static Type copy(const PAL::SessionID&);
     48    static Type copy(PAL::SessionID);
    4949};
    5050

  • trunk/Source/WebCore/storage/StorageNamespaceProvider.cpp

    r249575 r278849  
    8383}
    8484
    85 void StorageNamespaceProvider::setSessionIDForTesting(const PAL::SessionID& newSessionID)
     85void StorageNamespaceProvider::setSessionIDForTesting(PAL::SessionID newSessionID)
    8686{
    8787    if (m_localStorageNamespace && newSessionID != m_localStorageNamespace->sessionID())

  • trunk/Source/WebCore/storage/StorageNamespaceProvider.h

    r276880 r278849  
    5151    Ref<StorageArea> localStorageArea(Document&);
    5252
    53     WEBCORE_EXPORT void setSessionIDForTesting(const PAL::SessionID&);
     53    WEBCORE_EXPORT void setSessionIDForTesting(PAL::SessionID);
    5454
    5555protected:

  • trunk/Source/WebKit/ChangeLog

    r278841 r278849  
     12021-06-14  Alex Christensen  <achristensen@webkit.org>
     2
     3        Pass PAL::SessionID by value instead of reference
     4        https://bugs.webkit.org/show_bug.cgi?id=226983
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        * NetworkProcess/NetworkProcess.cpp:
     9        (WebKit::NetworkProcess::newTestingSession):
     10        (WebKit::NetworkProcess::ensureSession):
     11        (WebKit::NetworkProcess::storageSession const):
     12        (WebKit::NetworkProcess::findCacheEngine):
     13        (WebKit::NetworkProcess::ensureCacheEngine):
     14        (WebKit::NetworkProcess::removeCacheEngine):
     15        (WebKit::NetworkProcess::flushCookies):
     16        (WebKit::NetworkProcess::platformFlushCookies):
     17        (WebKit::NetworkProcess::addWebPageNetworkParameters):
     18        (WebKit::NetworkProcess::removeWebPageNetworkParameters):
     19        (WebKit::NetworkProcess::countNonDefaultSessionSets):
     20        * NetworkProcess/NetworkProcess.h:
     21        * NetworkProcess/NetworkResourceLoader.cpp:
     22        (WebKit::NetworkResourceLoader::shouldLogCookieInformation):
     23        * NetworkProcess/NetworkResourceLoader.h:
     24        * NetworkProcess/NetworkStorageSessionProvider.h:
     25        * NetworkProcess/cache/NetworkCache.cpp:
     26        (WebKit::NetworkCache::makeUseDecision):
     27        * NetworkProcess/cache/NetworkCache.h:
     28        (WebKit::NetworkCache::Cache::sessionID const):
     29        * NetworkProcess/cocoa/NetworkProcessCocoa.mm:
     30        (WebKit::NetworkProcess::flushCookies):
     31        (WebKit::NetworkProcess::platformFlushCookies):
     32        * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
     33        (WebKit::configurationForSessionID):
     34        * UIProcess/Network/NetworkProcessProxy.cpp:
     35        (WebKit::NetworkProcessProxy::flushCookies):
     36        * UIProcess/Network/NetworkProcessProxy.h:
     37        * UIProcess/WebProcessPool.h:
     38        * WebProcess/Databases/WebDatabaseProvider.cpp:
     39        (WebKit::WebDatabaseProvider::idbConnectionToServerForSession):
     40        * WebProcess/Databases/WebDatabaseProvider.h:
     41
    1422021-06-14  Youenn Fablet  <youenn@apple.com>
    243

  • trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp

    r278475 r278849  
    452452}
    453453
    454 std::unique_ptr<WebCore::NetworkStorageSession> NetworkProcess::newTestingSession(const PAL::SessionID& sessionID)
     454std::unique_ptr<WebCore::NetworkStorageSession> NetworkProcess::newTestingSession(PAL::SessionID sessionID)
    455455{
    456456#if PLATFORM(COCOA)
    … …  
    470470
    471471#if PLATFORM(COCOA)
    472 void NetworkProcess::ensureSession(const PAL::SessionID& sessionID, bool shouldUseTestingNetworkSession, const String& identifierBase, RetainPtr<CFHTTPCookieStorageRef>&& cookieStorage)
     472void NetworkProcess::ensureSession(PAL::SessionID sessionID, bool shouldUseTestingNetworkSession, const String& identifierBase, RetainPtr<CFHTTPCookieStorageRef>&& cookieStorage)
    473473#else
    474 void NetworkProcess::ensureSession(const PAL::SessionID& sessionID, bool shouldUseTestingNetworkSession, const String& identifierBase)
     474void NetworkProcess::ensureSession(PAL::SessionID sessionID, bool shouldUseTestingNetworkSession, const String& identifierBase)
    475475#endif
    476476{
    … …  
    510510}
    511511
    512 WebCore::NetworkStorageSession* NetworkProcess::storageSession(const PAL::SessionID& sessionID) const
     512WebCore::NetworkStorageSession* NetworkProcess::storageSession(PAL::SessionID sessionID) const
    513513{
    514514    return m_networkStorageSessions.get(sessionID);
    … …  
    20742074#endif // ENABLE(RESOURCE_LOAD_STATISTICS)
    20752075
    2076 CacheStorage::Engine* NetworkProcess::findCacheEngine(const PAL::SessionID& sessionID)
     2076CacheStorage::Engine* NetworkProcess::findCacheEngine(PAL::SessionID sessionID)
    20772077{
    20782078    return m_cacheEngines.get(sessionID);
    20792079}
    20802080
    2081 CacheStorage::Engine& NetworkProcess::ensureCacheEngine(const PAL::SessionID& sessionID, Function<Ref<CacheStorage::Engine>()>&& functor)
     2081CacheStorage::Engine& NetworkProcess::ensureCacheEngine(PAL::SessionID sessionID, Function<Ref<CacheStorage::Engine>()>&& functor)
    20822082{
    20832083    return m_cacheEngines.ensure(sessionID, WTFMove(functor)).iterator->value;
    20842084}
    20852085
    2086 void NetworkProcess::removeCacheEngine(const PAL::SessionID& sessionID)
     2086void NetworkProcess::removeCacheEngine(PAL::SessionID sessionID)
    20872087{
    20882088    m_cacheEngines.remove(sessionID);
    … …  
    25292529}
    25302530
    2531 void NetworkProcess::flushCookies(const PAL::SessionID&, CompletionHandler<void()>&& completionHandler)
    2532 {
    2533     completionHandler();
    2534 }
    2535 
    2536 void NetworkProcess::platformFlushCookies(const PAL::SessionID&, CompletionHandler<void()>&& completionHandler)
     2531void NetworkProcess::flushCookies(PAL::SessionID, CompletionHandler<void()>&& completionHandler)
     2532{
     2533    completionHandler();
     2534}
     2535
     2536void NetworkProcess::platformFlushCookies(PAL::SessionID, CompletionHandler<void()>&& completionHandler)
    25372537{
    25382538    completionHandler();
    … …  
    27952795#endif
    27962796
    2797 void NetworkProcess::addWebPageNetworkParameters(const PAL::SessionID& sessionID, WebPageProxyIdentifier pageID, WebPageNetworkParameters&& parameters)
     2797void NetworkProcess::addWebPageNetworkParameters(PAL::SessionID sessionID, WebPageProxyIdentifier pageID, WebPageNetworkParameters&& parameters)
    27982798{
    27992799    auto session = networkSession(sessionID);
    … …  
    28042804}
    28052805
    2806 void NetworkProcess::removeWebPageNetworkParameters(const PAL::SessionID& sessionID, WebPageProxyIdentifier pageID)
     2806void NetworkProcess::removeWebPageNetworkParameters(PAL::SessionID sessionID, WebPageProxyIdentifier pageID)
    28072807{
    28082808    auto session = networkSession(sessionID);
    … …  
    28132813}
    28142814
    2815 void NetworkProcess::countNonDefaultSessionSets(const PAL::SessionID& sessionID, CompletionHandler<void(size_t)>&& completionHandler)
     2815void NetworkProcess::countNonDefaultSessionSets(PAL::SessionID sessionID, CompletionHandler<void(size_t)>&& completionHandler)
    28162816{
    28172817    auto session = networkSession(sessionID);

  • trunk/Source/WebKit/NetworkProcess/NetworkProcess.h

    r278475 r278849  
    174174
    175175    void forEachNetworkStorageSession(const Function<void(WebCore::NetworkStorageSession&)>&);
    176     WebCore::NetworkStorageSession* storageSession(const PAL::SessionID&) const;
    177     std::unique_ptr<WebCore::NetworkStorageSession> newTestingSession(const PAL::SessionID&);
     176    WebCore::NetworkStorageSession* storageSession(PAL::SessionID) const;
     177    std::unique_ptr<WebCore::NetworkStorageSession> newTestingSession(PAL::SessionID);
    178178#if PLATFORM(COCOA)
    179     void ensureSession(const PAL::SessionID&, bool shouldUseTestingNetworkSession, const String& identifier, RetainPtr<CFHTTPCookieStorageRef>&&);
     179    void ensureSession(PAL::SessionID, bool shouldUseTestingNetworkSession, const String& identifier, RetainPtr<CFHTTPCookieStorageRef>&&);
    180180#else
    181     void ensureSession(const PAL::SessionID&, bool shouldUseTestingNetworkSession, const String& identifier);
     181    void ensureSession(PAL::SessionID, bool shouldUseTestingNetworkSession, const String& identifier);
    182182#endif
    183183
    … …  
    330330    void deref() const override { ThreadSafeRefCounted<NetworkProcess>::deref(); }
    331331
    332     CacheStorage::Engine* findCacheEngine(const PAL::SessionID&);
    333     CacheStorage::Engine& ensureCacheEngine(const PAL::SessionID&, Function<Ref<CacheStorage::Engine>()>&&);
    334     void removeCacheEngine(const PAL::SessionID&);
     332    CacheStorage::Engine* findCacheEngine(PAL::SessionID);
     333    CacheStorage::Engine& ensureCacheEngine(PAL::SessionID, Function<Ref<CacheStorage::Engine>()>&&);
     334    void removeCacheEngine(PAL::SessionID);
    335335    void requestStorageSpace(PAL::SessionID, const WebCore::ClientOrigin&, uint64_t quota, uint64_t currentSize, uint64_t spaceRequired, CompletionHandler<void(std::optional<uint64_t>)>&&);
    336336
    … …  
    452452    void setAllowsAnySSLCertificateForWebSocket(bool, CompletionHandler<void()>&&);
    453453   
    454     void flushCookies(const PAL::SessionID&, CompletionHandler<void()>&&);
    455 
    456     void addWebPageNetworkParameters(const PAL::SessionID&, WebPageProxyIdentifier, WebPageNetworkParameters&&);
    457     void removeWebPageNetworkParameters(const PAL::SessionID&, WebPageProxyIdentifier);
    458     void countNonDefaultSessionSets(const PAL::SessionID&, CompletionHandler<void(size_t)>&&);
     454    void flushCookies(PAL::SessionID, CompletionHandler<void()>&&);
     455
     456    void addWebPageNetworkParameters(PAL::SessionID, WebPageProxyIdentifier, WebPageNetworkParameters&&);
     457    void removeWebPageNetworkParameters(PAL::SessionID, WebPageProxyIdentifier);
     458    void countNonDefaultSessionSets(PAL::SessionID, CompletionHandler<void(size_t)>&&);
    459459
    460460#if USE(SOUP)
    … …  
    473473#endif
    474474
    475     void platformFlushCookies(const PAL::SessionID&, CompletionHandler<void()>&&);
     475    void platformFlushCookies(PAL::SessionID, CompletionHandler<void()>&&);
    476476   
    477477    void registerURLSchemeAsSecure(const String&) const;

  • trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp

    r278738 r278849  
    12851285
    12861286#if ENABLE(RESOURCE_LOAD_STATISTICS) && !RELEASE_LOG_DISABLED
    1287 bool NetworkResourceLoader::shouldLogCookieInformation(NetworkConnectionToWebProcess& connection, const PAL::SessionID& sessionID)
     1287bool NetworkResourceLoader::shouldLogCookieInformation(NetworkConnectionToWebProcess& connection, PAL::SessionID sessionID)
    12881288{
    12891289    if (auto* session = connection.networkProcess().networkSession(sessionID))

  • trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h

    r278253 r278849  
    129129
    130130#if ENABLE(RESOURCE_LOAD_STATISTICS) && !RELEASE_LOG_DISABLED
    131     static bool shouldLogCookieInformation(NetworkConnectionToWebProcess&, const PAL::SessionID&);
     131    static bool shouldLogCookieInformation(NetworkConnectionToWebProcess&, PAL::SessionID);
    132132    static void logCookieInformation(NetworkConnectionToWebProcess&, const String& label, const void* loggedObject, const WebCore::NetworkStorageSession&, const URL& firstParty, const WebCore::SameSiteInfo&, const URL&, const String& referrer, std::optional<WebCore::FrameIdentifier>, std::optional<WebCore::PageIdentifier>, std::optional<uint64_t> identifier);
    133133#endif

  • trunk/Source/WebKit/NetworkProcess/NetworkStorageSessionProvider.h

    r248099 r278849  
    3636class NetworkStorageSessionProvider final : public WebCore::StorageSessionProvider {
    3737public:
    38     static Ref<NetworkStorageSessionProvider> create(NetworkProcess& networkProcess, const PAL::SessionID& sessionID) { return adoptRef(*new NetworkStorageSessionProvider(networkProcess, sessionID)); }
     38    static Ref<NetworkStorageSessionProvider> create(NetworkProcess& networkProcess, PAL::SessionID sessionID) { return adoptRef(*new NetworkStorageSessionProvider(networkProcess, sessionID)); }
    3939   
    4040private:
    41     NetworkStorageSessionProvider(NetworkProcess& networkProcess, const PAL::SessionID& sessionID)
     41    NetworkStorageSessionProvider(NetworkProcess& networkProcess, PAL::SessionID sessionID)
    4242        : m_networkProcess(makeWeakPtr(networkProcess))
    4343        , m_sessionID(sessionID) { }

  • trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp

    r278253 r278849  
    221221}
    222222
    223 static UseDecision makeUseDecision(NetworkProcess& networkProcess, const PAL::SessionID& sessionID, const Entry& entry, const WebCore::ResourceRequest& request)
     223static UseDecision makeUseDecision(NetworkProcess& networkProcess, PAL::SessionID sessionID, const Entry& entry, const WebCore::ResourceRequest& request)
    224224{
    225225    // The request is conditional so we force revalidation from the network. We merely check the disk cache

  • trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.h

    r278253 r278849  
    204204
    205205    NetworkProcess& networkProcess() { return m_networkProcess.get(); }
    206     const PAL::SessionID& sessionID() const { return m_sessionID; }
     206    PAL::SessionID sessionID() const { return m_sessionID; }
    207207    const String& storageDirectory() const { return m_storageDirectory; }
    208208

  • trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm

    r278253 r278849  
    213213#endif
    214214
    215 void NetworkProcess::flushCookies(const PAL::SessionID& sessionID, CompletionHandler<void()>&& completionHandler)
     215void NetworkProcess::flushCookies(PAL::SessionID sessionID, CompletionHandler<void()>&& completionHandler)
    216216{
    217217    platformFlushCookies(sessionID, WTFMove(completionHandler));
    … …  
    228228}
    229229
    230 void NetworkProcess::platformFlushCookies(const PAL::SessionID& sessionID, CompletionHandler<void()>&& completionHandler)
     230void NetworkProcess::platformFlushCookies(PAL::SessionID sessionID, CompletionHandler<void()>&& completionHandler)
    231231{
    232232    ASSERT(hasProcessPrivilege(ProcessPrivilege::CanAccessRawCookies));

  • trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

    r278738 r278849  
    10631063#endif
    10641064
    1065 static NSURLSessionConfiguration *configurationForSessionID(const PAL::SessionID& session, bool isFullWebBrowser)
     1065static NSURLSessionConfiguration *configurationForSessionID(PAL::SessionID session, bool isFullWebBrowser)
    10661066{
    10671067#if HAVE(LOGGING_PRIVACY_LEVEL)

  • trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp

    r278421 r278849  
    12631263}
    12641264
    1265 void NetworkProcessProxy::flushCookies(const PAL::SessionID& sessionID, CompletionHandler<void()>&& completionHandler)
     1265void NetworkProcessProxy::flushCookies(PAL::SessionID sessionID, CompletionHandler<void()>&& completionHandler)
    12661266{
    12671267    sendWithAsyncReply(Messages::NetworkProcess::FlushCookies(sessionID), WTFMove(completionHandler));

  • trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h

    r278253 r278849  
    211211    void setIsHoldingLockedFiles(bool);
    212212
    213     void flushCookies(const PAL::SessionID&, CompletionHandler<void()>&&);
     213    void flushCookies(PAL::SessionID, CompletionHandler<void()>&&);
    214214
    215215    void testProcessIncomingSyncMessagesWhenWaitingForSyncReply(WebPageProxyIdentifier, Messages::NetworkProcessProxy::TestProcessIncomingSyncMessagesWhenWaitingForSyncReplyDelayedReply&&);

  • trunk/Source/WebKit/UIProcess/WebProcessPool.h

    r278745 r278849  
    300300    static Statistics& statistics();   
    301301
    302     void clearCachedCredentials(const PAL::SessionID&);
     302    void clearCachedCredentials(PAL::SessionID);
    303303    void terminateNetworkProcess();
    304304    void terminateAllWebContentProcesses();

  • trunk/Source/WebKit/WebProcess/Databases/WebDatabaseProvider.cpp

    r275151 r278849  
    6767}
    6868
    69 WebCore::IDBClient::IDBConnectionToServer& WebDatabaseProvider::idbConnectionToServerForSession(const PAL::SessionID&)
     69WebCore::IDBClient::IDBConnectionToServer& WebDatabaseProvider::idbConnectionToServerForSession(PAL::SessionID)
    7070{
    7171    return WebProcess::singleton().ensureNetworkProcessConnection().idbConnectionToServer().coreConnectionToServer();

  • trunk/Source/WebKit/WebProcess/Databases/WebDatabaseProvider.h

    r275151 r278849  
    3737    virtual ~WebDatabaseProvider();
    3838
    39     WebCore::IDBClient::IDBConnectionToServer& idbConnectionToServerForSession(const PAL::SessionID&) final;
     39    WebCore::IDBClient::IDBConnectionToServer& idbConnectionToServerForSession(PAL::SessionID) final;
    4040
    4141private:

  • trunk/Source/WebKitLegacy/ChangeLog

    r278738 r278849  
     12021-06-14  Alex Christensen  <achristensen@webkit.org>
     2
     3        Pass PAL::SessionID by value instead of reference
     4        https://bugs.webkit.org/show_bug.cgi?id=226983
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        * Storage/WebDatabaseProvider.cpp:
     9        (WebDatabaseProvider::idbConnectionToServerForSession):
     10        * Storage/WebDatabaseProvider.h:
     11        * WebCoreSupport/NetworkStorageSessionMap.cpp:
     12        (NetworkStorageSessionMap::storageSession):
     13        (NetworkStorageSessionMap::ensureSession):
     14        (NetworkStorageSessionMap::destroySession):
     15        * WebCoreSupport/NetworkStorageSessionMap.h:
     16
    1172021-06-10  Alex Christensen  <achristensen@webkit.org>
    218

  • trunk/Source/WebKitLegacy/Storage/WebDatabaseProvider.cpp

    r275151 r278849  
    4343}
    4444
    45 WebCore::IDBClient::IDBConnectionToServer& WebDatabaseProvider::idbConnectionToServerForSession(const PAL::SessionID& sessionID)
     45WebCore::IDBClient::IDBConnectionToServer& WebDatabaseProvider::idbConnectionToServerForSession(PAL::SessionID sessionID)
    4646{
    4747    return m_idbServerMap.ensure(sessionID, [&sessionID] {

  • trunk/Source/WebKitLegacy/Storage/WebDatabaseProvider.h

    r275151 r278849  
    3838    virtual ~WebDatabaseProvider();
    3939
    40     WebCore::IDBClient::IDBConnectionToServer& idbConnectionToServerForSession(const PAL::SessionID&) override;
     40    WebCore::IDBClient::IDBConnectionToServer& idbConnectionToServerForSession(PAL::SessionID) override;
    4141
    4242    void deleteAllDatabases();

  • trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp

    r277967 r278849  
    4747}
    4848
    49 WebCore::NetworkStorageSession* NetworkStorageSessionMap::storageSession(const PAL::SessionID& sessionID)
     49WebCore::NetworkStorageSession* NetworkStorageSessionMap::storageSession(PAL::SessionID sessionID)
    5050{
    5151    if (sessionID == PAL::SessionID::defaultSessionID())
    … …  
    7878}
    7979
    80 void NetworkStorageSessionMap::ensureSession(const PAL::SessionID& sessionID, const String& identifierBase)
     80void NetworkStorageSessionMap::ensureSession(PAL::SessionID sessionID, const String& identifierBase)
    8181{
    8282#if PLATFORM(COCOA) || USE(CFURLCONNECTION)
    … …  
    109109}
    110110
    111 void NetworkStorageSessionMap::destroySession(const PAL::SessionID& sessionID)
     111void NetworkStorageSessionMap::destroySession(PAL::SessionID sessionID)
    112112{
    113113    globalSessionMap().remove(sessionID);

  • trunk/Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.h

    r240292 r278849  
    3838class NetworkStorageSessionMap {
    3939public:
    40     static WebCore::NetworkStorageSession* storageSession(const PAL::SessionID&);
     40    static WebCore::NetworkStorageSession* storageSession(PAL::SessionID);
    4141    static WebCore::NetworkStorageSession& defaultStorageSession();
    4242    static void switchToNewTestingSession();
    43     static void ensureSession(const PAL::SessionID&, const String& identifierBase = String());
    44     static void destroySession(const PAL::SessionID&);
     43    static void ensureSession(PAL::SessionID, const String& identifierBase = String());
     44    static void destroySession(PAL::SessionID);
    4545};
Note: See TracChangeset for help on using the changeset viewer.