Changeset 278854 in webkit

Timestamp:

Jun 14, 2021, 5:54:08 PM (5 years ago)

Author:

keith_miller@apple.com

Message:

run-javascriptcore-tests should print output when a test binary fails by default
​https://bugs.webkit.org/show_bug.cgi?id=226985

Reviewed by Mark Lam.

• Scripts/run-javascriptcore-tests:

(runTest):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-javascriptcore-tests (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-06-14  Keith Miller  <keith_miller@apple.com>
+
+        run-javascriptcore-tests should print output when a test binary fails by default
+        https://bugs.webkit.org/show_bug.cgi?id=226985
+
+        Reviewed by Mark Lam.
+
+        * Scripts/run-javascriptcore-tests:
+        (runTest):
+
 2021-06-14  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Tools/Scripts/run-javascriptcore-tests

@@ -631 +631 @@
 
     open(TEST, "-|", "@command 2>&1") or die "Failed to run @command";
+    my $testOutput = "";
     while ( my $line = <TEST> ) {
-        print $line if ($verbose);
+        $testOutput .= $line;
     }
     $testResult = close(TEST) ? 0 : $?;
@@ -638 +639 @@
 
     my $exitStatus = exitStatus($testResult);
+
+    print "$testOutput" if ($verbose or $testResult);
     print "$testName completed with rc=$testResult ($exitStatus)\n\n";