Changeset 27893 in webkit

Timestamp:

Nov 18, 2007 3:04:19 PM (16 years ago)

Author:

timothy@apple.com

Message:

Reviewed by Sam Weinig.

Bug 16043: Remove InspectorController.log now that console.log works
​http://bugs.webkit.org/show_bug.cgi?id=16043

Remove the last uses of InspectorController.log. Once use was no longer needed,
checking an erro case that can't happen anymore. The other case now uses console.error.

• page/InspectorController.cpp: Remove the log function. (WebCore::InspectorController::windowScriptObjectAvailable): Remove the log function from InspectorController script class.
• page/inspector/DocumentPanel.js: Remove a use of InspectorController.log that isn't needed.
• page/inspector/Panel.js: Change InspectorController.log to console.log and early return.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/InspectorController.cpp (modified) (2 diffs)
• page/inspector/DocumentPanel.js (modified) (1 diff)
• page/inspector/Panel.js (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-11-18  Timothy Hatcher  <timothy@apple.com>
+
+        Reviewed by Sam Weinig.
+
+        Bug 16043: Remove InspectorController.log now that console.log works
+        http://bugs.webkit.org/show_bug.cgi?id=16043
+
+        Remove the last uses of InspectorController.log. Once use was no longer needed,
+        checking an erro case that can't happen anymore. The other case now uses console.error.
+
+        * page/InspectorController.cpp: Remove the log function.
+        (WebCore::InspectorController::windowScriptObjectAvailable): Remove the log function from
+        InspectorController script class.
+        * page/inspector/DocumentPanel.js: Remove a use of InspectorController.log that isn't needed.
+        * page/inspector/Panel.js: Change InspectorController.log to console.log and early return.
+
 2007-11-18  Timothy Hatcher  <timothy@apple.com>
 

trunk/WebCore/page/InspectorController.cpp

@@ -427 +427 @@
 }
 
-static JSValueRef log(JSContextRef ctx, JSObjectRef /*function*/, JSObjectRef /*thisObject*/, size_t argumentCount, const JSValueRef arguments[], JSValueRef* /*exception*/)
-{
-    if (argumentCount < 1 || !JSValueIsString(ctx, arguments[0]))
-        return JSValueMakeUndefined(ctx);
-
-#ifndef NDEBUG
-    JSStringRef string = JSValueToStringCopy(ctx, arguments[0], 0);
-    String message(JSStringGetCharactersPtr(string), JSStringGetLength(string));
-    JSStringRelease(string);
-
-    fprintf(stderr, "%s\n", message.latin1().data());
-#endif
-
-    return JSValueMakeUndefined(ctx);
-}
-
 static JSValueRef search(JSContextRef ctx, JSObjectRef /*function*/, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* /*exception*/)
 {
@@ -747 +731 @@
         { "attach", attach, kJSPropertyAttributeNone },
         { "detach", detach, kJSPropertyAttributeNone },
-        { "log", log, kJSPropertyAttributeNone },
         { "search", search, kJSPropertyAttributeNone },
 #if ENABLE(DATABASE)

trunk/WebCore/page/inspector/DocumentPanel.js

@@ -131 +131 @@
     set focusedDOMNode(x)
     {
-        if (this.resource.category !== WebInspector.resourceCategories.documents) {
-            InspectorController.log("Called set focusedDOMNode on a non-document resource " + this.resource.displayName + " which is not a document");
-            return;
-        }
-
         if (this._focusedDOMNode === x) {
             var nodeItem = this.revealNode(x);

trunk/WebCore/page/inspector/Panel.js

@@ -141 +141 @@
             return;
 
+        if (this !== x.panel) {
+            console.error("Set currentView to a view " + x.title + " whose panel is not this panel");
+            return;
+        }
+
         if (this._currentView) {
             this._currentView.buttonElement.removeStyleClass("selected");
@@ -155 +160 @@
             if (x.show)
                 x.show();
-            if (x.panel !== this)
-                InspectorController.log("Set currentView to a view " + x.title + " whose panel is not this panel");
         }
     },