Changeset 279065 in webkit

Timestamp:

Jun 21, 2021, 3:13:28 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

[GLIB] REGRESSION(r278701): numerous WebRTC tests failing after libwebrtc update to M92
​https://bugs.webkit.org/show_bug.cgi?id=227172

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-06-21
Reviewed by Adrian Perez de Castro.

Non-apple ports do not use the bundled libvpx library, they rely on the host libvpx instead.
LibWebRTC expects to depend on the bundled version, thus using its API. So we need to be
very careful with which libvpx version is used from the host, in order to avoid API/ABI
issues. Hence the version check should specify a version that is API/ABI compatible with
what libwebrtc expects.

This patch also re-enables data channel support, which was disabled during the update to M92
in CMake ports.

• CMakeLists.txt:

Location:

trunk/Source/ThirdParty/libwebrtc

Files:

• CMakeLists.txt (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt

@@ -5 +5 @@
 
 if (NOT APPLE)
-    find_package(LibVpx 1.7.0)
+    find_package(LibVpx 1.10.0)
     if (NOT LIBVPX_FOUND)
         message(FATAL_ERROR "libvpx is needed for USE_LIBWEBRTC.")
@@ -1675 +1675 @@
   WEBRTC_CODEC_OPUS
   WEBRTC_CODEC_RED
+  WEBRTC_HAVE_SCTP
+  WEBRTC_HAVE_USRSCTP
   WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE
   WEBRTC_INTELLIGIBILITY_ENHANCER=0
@@ -1732 +1734 @@
     Source/third_party/libsrtp/include
     Source/third_party/libyuv/include
-    Source/third_party/libvpx/source/libvpx
     Source/third_party/opus/src/celt
     Source/third_party/opus/src/include

trunk/Source/ThirdParty/libwebrtc/ChangeLog

@@ +1 @@
+2021-06-21  Philippe Normand  <pnormand@igalia.com>
+
+        [GLIB] REGRESSION(r278701): numerous WebRTC tests failing after libwebrtc update to M92
+        https://bugs.webkit.org/show_bug.cgi?id=227172
+
+        Reviewed by Adrian Perez de Castro.
+
+        Non-apple ports do not use the bundled libvpx library, they rely on the host libvpx instead.
+        LibWebRTC expects to depend on the bundled version, thus using its API. So we need to be
+        very careful with which libvpx version is used from the host, in order to avoid API/ABI
+        issues. Hence the version check should specify a version that is API/ABI compatible with
+        what libwebrtc expects.
+
+        This patch also re-enables data channel support, which was disabled during the update to M92
+        in CMake ports.
+
+        * CMakeLists.txt:
+
 2021-06-17  Commit Queue  <commit-queue@webkit.org>