Changeset 279095 in webkit

Timestamp:

Jun 21, 2021, 5:45:11 PM (5 years ago)

Author:

Chris Dumez

Message:

[WK2] Don't process-swap on navigations within the same non-HTTP(s) protocol
​https://bugs.webkit.org/show_bug.cgi?id=227220
<rdar://79106461>

Unreviewed follow-up to fix GTK test that started failing after the behavior
change in r279079.

• TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:

(testWebExtensionPageID):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-06-21  Chris Dumez  <cdumez@apple.com>
+
+        [WK2] Don't process-swap on navigations within the same non-HTTP(s) protocol
+        https://bugs.webkit.org/show_bug.cgi?id=227220
+        <rdar://79106461>
+
+        Unreviewed follow-up to fix GTK test that started failing after the behavior
+        change in r279079.
+
+        * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
+        (testWebExtensionPageID):
+
 2021-06-21  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp

@@ -493 +493 @@
     test->loadURI("foo://host6/");
     test->waitUntilLoadFinished();
-    g_assert_true(pageIDChangedEmitted);
+    g_assert_false(pageIDChangedEmitted);
     pageIDChangedEmitted = false;
-    g_assert_cmpuint(pageID, <, webkit_web_view_get_page_id(test->m_webView));
+    g_assert_cmpuint(pageID, ==, webkit_web_view_get_page_id(test->m_webView));
     pageID = webkit_web_view_get_page_id(test->m_webView);
     proxy = test->extensionProxy();
@@ -502 +502 @@
     test->goBack();
     test->waitUntilLoadFinished();
-    g_assert_true(pageIDChangedEmitted);
+    g_assert_false(pageIDChangedEmitted);
     pageIDChangedEmitted = false;
-    g_assert_cmpuint(pageID, >, webkit_web_view_get_page_id(test->m_webView));
+    g_assert_cmpuint(pageID, ==, webkit_web_view_get_page_id(test->m_webView));
     pageID = webkit_web_view_get_page_id(test->m_webView);
     proxy = test->extensionProxy();
@@ -511 +511 @@
     test->goForward();
     test->waitUntilLoadFinished();
-    g_assert_true(pageIDChangedEmitted);
+    g_assert_false(pageIDChangedEmitted);
     pageIDChangedEmitted = false;
-    g_assert_cmpuint(pageID, <, webkit_web_view_get_page_id(test->m_webView));
+    g_assert_cmpuint(pageID, ==, webkit_web_view_get_page_id(test->m_webView));
     pageID = webkit_web_view_get_page_id(test->m_webView);
     proxy = test->extensionProxy();