Changeset 279493 in webkit

Timestamp:

Jul 1, 2021, 6:36:04 PM (5 years ago)

Author:

Patrick Angle

Message:

Web Inspector: [Regression: r279271] Sources: Breakpoints section in navigation sidebar disappears when Web Inspector becomes taller than 650px
​https://bugs.webkit.org/show_bug.cgi?id=227597

Reviewed by Devin Rousso.

As of r279271, flex base size is no longer clamped by max-height. As a result the non-clamped element
(resources-container) was sized to the full height of the container, leaving no space for the other sections
to be shown. Removing the height: 100%; declaration resolves this by allowing the flex container to lay out
its children as needed. Because the resources container has no maximum height constraint, it still occupies the
remaining height of the container. Each container will also continue to shrink/grow at their prescribed ratio
just as they did before r279271.

• UserInterface/Views/SourcesNavigationSidebarPanel.css:

(@media (min-height: 650px) .sidebar > .panel.navigation.sources > .content > :matches(.call-stack-container, .breakpoints-container, .resources-container, .local-overrides-container)):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/SourcesNavigationSidebarPanel.css (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-07-01  Patrick Angle  <pangle@apple.com>
+
+        Web Inspector: [Regression: r279271] Sources: Breakpoints section in navigation sidebar disappears when Web Inspector becomes taller than 650px
+        https://bugs.webkit.org/show_bug.cgi?id=227597
+
+        Reviewed by Devin Rousso.
+
+        As of r279271, flex base size is no longer clamped by max-height. As a result the non-clamped element
+        (`resources-container`) was sized to the full height of the container, leaving no space for the other sections
+        to be shown. Removing the `height: 100%;` declaration resolves this by allowing the flex container to lay out
+        its children as needed. Because the resources container has no maximum height constraint, it still occupies the
+        remaining height of the container. Each container will also continue to shrink/grow at their prescribed ratio
+        just as they did before r279271.
+
+        * UserInterface/Views/SourcesNavigationSidebarPanel.css:
+        (@media (min-height: 650px) .sidebar > .panel.navigation.sources > .content > :matches(.call-stack-container, .breakpoints-container, .resources-container, .local-overrides-container)):
+
 2021-06-30  Patrick Angle  <pangle@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css

@@ -132 +132 @@
 
     .sidebar > .panel.navigation.sources > .content > :matches(.call-stack-container, .breakpoints-container, .resources-container, .local-overrides-container) {
-        height: 100%;
         overflow-y: auto;
     }