Changeset 279855 in webkit

Timestamp:

Jul 12, 2021, 4:07:14 PM (5 years ago)

Author:

Chris Fleizach

Message:

AX: Make WebKit observe spatial audio accessibility settings
​https://bugs.webkit.org/show_bug.cgi?id=227848

Reviewed by Sam Weinig.

Source/WebKit:

Allow mac and iOS to read from accessibility domains.
Allow mac sandbox to read from com.apple.Accessibility.

• PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
• UIProcess/Cocoa/PreferenceObserver.mm:

(-[WKPreferenceObserver init]):

Source/WTF:

This flag was using the wrong format for a HAVE setting, so the code wasn't being compiled in.

• wtf/PlatformHave.h:

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/PlatformHave.h (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in (modified) (1 diff)
• WebKit/UIProcess/Cocoa/PreferenceObserver.mm (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2021-07-12  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Make WebKit observe spatial audio accessibility settings
+        https://bugs.webkit.org/show_bug.cgi?id=227848
+
+        Reviewed by Sam Weinig.
+
+        This flag was using the wrong format for a HAVE setting, so the code wasn't being compiled in.
+
+        * wtf/PlatformHave.h:
+
 2021-07-12  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WTF/wtf/PlatformHave.h

@@ -1041 +1041 @@
 #if (((PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 150000) \
     || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000))
-#define UPDATE_WEB_ACCESSIBILITY_SETTINGS 1
+#define HAVE_UPDATE_WEB_ACCESSIBILITY_SETTINGS 1
 #endif
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-07-12  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Make WebKit observe spatial audio accessibility settings
+        https://bugs.webkit.org/show_bug.cgi?id=227848
+
+        Reviewed by Sam Weinig.
+
+        Allow mac and iOS to read from accessibility domains.
+        Allow mac sandbox to read from com.apple.Accessibility.
+
+        * PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
+        * UIProcess/Cocoa/PreferenceObserver.mm:
+        (-[WKPreferenceObserver init]):
+
 2021-07-12  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in

@@ -262 +262 @@
     ".GlobalPreferences"
     "com.apple.ATS"
+    "com.apple.Accessibility"
     "com.apple.Bluetooth"
     "com.apple.CoreGraphics"

trunk/Source/WebKit/UIProcess/Cocoa/PreferenceObserver.mm

@@ -130 +130 @@
 
     std::initializer_list<NSString*> domains = {
+        @"com.apple.Accessibility",
+        @"com.apple.mediaaccessibility",
 #if PLATFORM(IOS_FAMILY)
-        @"com.apple.Accessibility",
         @"com.apple.AdLib",
         @"com.apple.SpeakSelection",
@@ -150 +151 @@
         @"com.apple.driver.AppleBluetoothMultitouch.mouse",
         @"com.apple.driver.AppleBluetoothMultitouch.trackpad",
-        @"com.apple.mediaaccessibility",
         @"com.apple.speech.voice.prefs",
         @"com.apple.universalaccess",