Changeset 27996 in webkit


Ignore:
Timestamp:
Nov 23, 2007 8:48:07 PM (16 years ago)
Author:
timothy@apple.com
Message:

Reviewed by Adam Roben.

Bug 16110: Clicking inside the resource headers in the network timeline collapses them
http://bugs.webkit.org/show_bug.cgi?id=16110

Toggle the resource headers only if the click happens on the
resource row, not within the headers area.

  • WebCore.xcodeproj/project.pbxproj:
  • page/inspector/NetworkPanel.js:
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r27994 r27996  
     12007-11-23  Timothy Hatcher  <timothy@apple.com>
     2
     3        Reviewed by Adam Roben.
     4
     5        Bug 16110: Clicking inside the resource headers in the network timeline collapses them
     6        http://bugs.webkit.org/show_bug.cgi?id=16110
     7
     8        Toggle the resource headers only if the click happens on the
     9        resource row, not within the headers area.
     10
     11        * WebCore.xcodeproj/project.pbxproj:
     12        * page/inspector/NetworkPanel.js:
     13
    1142007-11-23  Kevin Ollivier  <kevino@theolliviers.com>
    215
  • trunk/WebCore/page/inspector/NetworkPanel.js

    r27979 r27996  
    115115    onClick: function(event)
    116116    {
     117        // If the click wasn't inside a network resource row, ignore it.
    117118        var resourceElement = event.target.firstParentOrSelfWithClass("network-resource");
    118119        if (!resourceElement)
    119120            return;
    120121
     122        // If the click was within the network info element, ignore it.
     123        var networkInfo = event.target.firstParentOrSelfWithClass("network-info");
     124        if (networkInfo)
     125            return;
     126
     127        // If the click was within the tip balloon element, hide it.
    121128        var balloon = event.target.firstParentOrSelfWithClass("tip-balloon");
    122129        if (balloon) {
    123             resourceElement.timelineEntry.toggleTipBalloon(event);
     130            resourceElement.timelineEntry.showingTipBalloon = false;
    124131            return;
    125132        }
Note: See TracChangeset for help on using the changeset viewer.