Changeset 280501 in webkit

Timestamp:

Jul 30, 2021, 4:04:07 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Add spacebar functionality for macOS smooth scrolling
​https://bugs.webkit.org/show_bug.cgi?id=228155

Patch by Dana Estra <​destra@apple.com> on 2021-07-30
Reviewed by Tim Horton.

Fixed bug that was causing spacebar events to return false from beginKeyboardScrollGesture.

Manually tested on webpage.

• platform/KeyboardScrollingAnimator.cpp:

(WebCore::KeyboardScrollingAnimator::beginKeyboardScrollGesture):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/KeyboardScrollingAnimator.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-07-30  Dana Estra  <destra@apple.com>
+
+        Add spacebar functionality for macOS smooth scrolling
+        https://bugs.webkit.org/show_bug.cgi?id=228155
+
+        Reviewed by Tim Horton.
+        
+        Fixed bug that was causing spacebar events to return false from beginKeyboardScrollGesture.
+
+        Manually tested on webpage.
+
+        * platform/KeyboardScrollingAnimator.cpp:
+        (WebCore::KeyboardScrollingAnimator::beginKeyboardScrollGesture):
+
 2021-07-30  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/KeyboardScrollingAnimator.cpp

@@ -231 +231 @@
     m_currentKeyboardScroll = scroll;
 
-    if (event.type() != eventNames().keydownEvent)
+    if (!(event.type() == eventNames().keydownEvent || event.type() == eventNames().keypressEvent))
         return false;