Changeset 280573 in webkit

Timestamp:

Aug 2, 2021, 5:49:37 PM (5 years ago)

Author:

Jean-Yves Avenard

Message:

[WebAudio] Add webm/vorbis container support
​https://bugs.webkit.org/show_bug.cgi?id=228139
rdar://80883073

Reviewed by Jer Noble.

Source/WebKit:

Access to the com.apple.audio.AudioComponentRegistrar is denied by the sandbox which
prevents registering the Vorbis Audio Component. So we instantiate the decoder right before
setting up the sandbox.
This is a workaround for rdar://81137953.
Test: webaudio/decode-audio-data-webm-vorbis.html

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::initializeSandbox):

LayoutTests:

• platform/mac/TestExpectations:
• webaudio/decode-audio-data-webm-vorbis-expected.txt: Added.
• webaudio/decode-audio-data-webm-vorbis.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/TestExpectations (modified) (1 diff)
• LayoutTests/webaudio/decode-audio-data-webm-vorbis-expected.txt (added)
• LayoutTests/webaudio/decode-audio-data-webm-vorbis.html (added)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-08-02  Jean-Yves Avenard  <jya@apple.com>
+
+        [WebAudio] Add webm/vorbis container support
+        https://bugs.webkit.org/show_bug.cgi?id=228139
+        rdar://80883073
+
+        Reviewed by Jer Noble.
+
+        * platform/mac/TestExpectations:
+        * webaudio/decode-audio-data-webm-vorbis-expected.txt: Added.
+        * webaudio/decode-audio-data-webm-vorbis.html: Added.
+
 2021-08-02  Eric Hutchison  <ehutchison@apple.com>
 

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1717 +1717 @@
 [ Catalina Mojave BigSur ] media/media-source/media-webm-opus-partial-abort.html [ Skip ]
 [ Catalina Mojave BigSur ] webaudio/decode-audio-data-webm-opus.html [ Skip ]
+[ Catalina Mojave BigSur ] webaudio/decode-audio-data-webm-vorbis.html [ Skip ]
 
 webkit.org/b/214422 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/suspend-after-construct.html [ Pass Failure ]

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-08-02  Jean-Yves Avenard  <jya@apple.com>
+
+        [WebAudio] Add webm/vorbis container support
+        https://bugs.webkit.org/show_bug.cgi?id=228139
+        rdar://80883073
+
+        Reviewed by Jer Noble.
+
+        Access to the com.apple.audio.AudioComponentRegistrar is denied by the sandbox which
+        prevents registering the Vorbis Audio Component. So we instantiate the decoder right before
+        setting up the sandbox.
+        This is a workaround for rdar://81137953.
+        Test: webaudio/decode-audio-data-webm-vorbis.html
+
+        * WebProcess/cocoa/WebProcessCocoa.mm:
+        (WebKit::WebProcess::initializeSandbox):
+
 2021-08-02  Jean-Yves Avenard  <jya@apple.com>
 

trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

@@ -82 +82 @@
 #import <WebCore/UTIUtilities.h>
 #import <WebCore/VersionChecks.h>
+#import <WebCore/WebMAudioUtilitiesCocoa.h>
 #import <algorithm>
 #import <dispatch/dispatch.h>
@@ -745 +746 @@
     auto webKitBundle = [NSBundle bundleWithIdentifier:@"com.apple.WebKit"];
 
+    // We need to initialize the Vorbis decoder before the sandbox gets setup; this is a one off action.
+    WebCore::registerVorbisDecoderIfNeeded();
+
     sandboxParameters.setOverrideSandboxProfilePath(makeString(String([webKitBundle resourcePath]), "/com.apple.WebProcess.sb"));