Changeset 280575 in webkit

Timestamp:

Aug 2, 2021, 5:55:12 PM (5 years ago)

Author:

Kate Cheney

Message:

[App Privacy Report] Domains are deleted for ephemeral website data stores
​https://bugs.webkit.org/show_bug.cgi?id=228708
<rdar://problem/81282432>

Reviewed by Alex Christensen.

No new tests. Since this data is not stored in WebKit, we have no
way to test when it gets deleted or not. I tested manually and requested
an automated test at the correct networking layer.

Only clear Privacy Report data if the website data store is
persistent. Safari calls the SPI to remove website data for ephemeral
data stores in some cases that are unrelated to a user clearing
website data or history and thus should not clear App Privacy Report
data. Additionally, it is unexpected that clearing an ephemeral data
store would clear disk data, as website data is only stored in memory
in this case.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::removeNetworkWebsiteData):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/cocoa/NetworkSessionCocoa.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-08-02  Kate Cheney  <katherine_cheney@apple.com>
+
+        [App Privacy Report] Domains are deleted for ephemeral website data stores
+        https://bugs.webkit.org/show_bug.cgi?id=228708
+        <rdar://problem/81282432>
+
+        Reviewed by Alex Christensen.
+
+        No new tests. Since this data is not stored in WebKit, we have no
+        way to test when it gets deleted or not. I tested manually and requested
+        an automated test at the correct networking layer.
+
+        Only clear Privacy Report data if the website data store is
+        persistent. Safari calls the SPI to remove website data for ephemeral
+        data stores in some cases that are unrelated to a user clearing
+        website data or history and thus should not clear App Privacy Report
+        data. Additionally, it is unexpected that clearing an ephemeral data
+        store would clear disk data, as website data is only stored in memory
+        in this case.
+
+        * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+        (WebKit::NetworkSessionCocoa::removeNetworkWebsiteData):
+
 2021-08-02  Jean-Yves Avenard  <jya@apple.com>
 

trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

@@ -1832 +1832 @@
 {
 #if ENABLE(APP_PRIVACY_REPORT) && HAVE(SYMPTOMS_FRAMEWORK)
+    // FIXME: Add automated test for this once rdar://81420753 is resolved.
+    if (sessionID().isEphemeral()) {
+        completionHandler();
+        return;
+    }
+
     auto bundleID = WebCore::applicationBundleIdentifier();
     if (!isParentProcessAFullWebBrowser(networkProcess()) && !isActingOnBehalfOfAFullWebBrowser(bundleID))