Changeset 280576 in webkit

Timestamp:

Aug 2, 2021, 6:05:39 PM (5 years ago)

Author:

Peng Liu

Message:

[GPUP] RemoteAudioSession::setPreferredBufferSize() does not change its preferredBufferSize
​https://bugs.webkit.org/show_bug.cgi?id=228720

Reviewed by Jer Noble.

Source/WebKit:

RemoteAudioSession should update its preferredBufferSize in
setPreferredBufferSize(). Otherwise, the preferredBufferSize
will become inconsistent with the value in the GPU process.

No new tests. Fix API test failures.

• WebProcess/GPU/media/RemoteAudioSession.cpp:

(WebKit::RemoteAudioSession::setPreferredBufferSize):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:

(TEST_F):

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-08-02  Peng Liu  <peng.liu6@apple.com>
+
+        [GPUP] RemoteAudioSession::setPreferredBufferSize() does not change its preferredBufferSize
+        https://bugs.webkit.org/show_bug.cgi?id=228720
+
+        Reviewed by Jer Noble.
+
+        `RemoteAudioSession` should update its `preferredBufferSize` in
+        `setPreferredBufferSize()`. Otherwise, the `preferredBufferSize`
+        will become inconsistent with the value in the GPU process.
+
+        No new tests. Fix API test failures.
+
+        * WebProcess/GPU/media/RemoteAudioSession.cpp:
+        (WebKit::RemoteAudioSession::setPreferredBufferSize):
+
 2021-08-02  Kate Cheney  <katherine_cheney@apple.com>
 

trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp

@@ -110 +110 @@
 void RemoteAudioSession::setPreferredBufferSize(size_t size)
 {
+    configuration().preferredBufferSize = size;
     ensureConnection().send(Messages::RemoteAudioSessionProxy::SetPreferredBufferSize(size), { });
 }

trunk/Tools/ChangeLog

@@ +1 @@
+2021-08-02  Peng Liu  <peng.liu6@apple.com>
+
+        [GPUP] RemoteAudioSession::setPreferredBufferSize() does not change its preferredBufferSize
+        https://bugs.webkit.org/show_bug.cgi?id=228720
+
+        Reviewed by Jer Noble.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
+        (TEST_F):
+
 2021-08-02  Alex Christensen  <achristensen@webkit.org>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm

@@ -80 +80 @@
 }
 
-TEST_F(PreferredAudioBufferSize, DISABLED_AudioElement)
+TEST_F(PreferredAudioBufferSize, AudioElement)
 {
     runPlayingTestWithPageNamed(@"audio-only", 4096);
 }
 
-TEST_F(PreferredAudioBufferSize, DISABLED_WebAudio)
+TEST_F(PreferredAudioBufferSize, WebAudio)
 {
     runPlayingTestWithPageNamed(@"web-audio-only", 128);
 }
 
-TEST_F(PreferredAudioBufferSize, DISABLED_VideoOnly)
+TEST_F(PreferredAudioBufferSize, VideoOnly)
 {
     runPlayingTestWithPageNamed(@"video-without-audio", 4096);
 }
 
-TEST_F(PreferredAudioBufferSize, DISABLED_VideoWithAudio)
+TEST_F(PreferredAudioBufferSize, VideoWithAudio)
 {
     runPlayingTestWithPageNamed(@"video-with-audio", 4096);
 }
 
-TEST_F(PreferredAudioBufferSize, DISABLED_AudioWithWebAudio)
+TEST_F(PreferredAudioBufferSize, AudioWithWebAudio)
 {
     runPlayingTestWithPageNamed(@"audio-with-web-audio", 128);
 }
 
-TEST_F(PreferredAudioBufferSize, DISABLED_VideoWithAudioAndWebAudio)
+TEST_F(PreferredAudioBufferSize, VideoWithAudioAndWebAudio)
 {
     runPlayingTestWithPageNamed(@"video-with-audio-and-web-audio", 128);