Changeset 280589 in webkit

Timestamp:

Aug 3, 2021, 6:15:40 AM (5 years ago)

Author:

jer.noble@apple.com

Message:

REGRESSION (r280531): multiple modern-media-controls tests have become flaky timeouts
​https://bugs.webkit.org/show_bug.cgi?id=228714
<rdar://problem/81426715>

Reviewed by Eric Carlson.

Update preferredRenderingMode() to reflect what setUpVideoRendering() actually does: use
MediaRenderingToContext whenever possible. This will cause setUpVideoRendering() to be
called from updateStates() to create the context, even if the element has been marked as
!isVisible() by RenderVideo upon removal from the DOM.

Also, in renderingModeChanged(), don't attempt to deduce whether scheduleUpdateStates()
should be called; just call it universally.

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::preferredRenderingMode const):
(WebCore::MediaPlayerPrivateAVFoundation::renderingModeChanged):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-08-03  Jer Noble  <jer.noble@apple.com>
+
+        REGRESSION (r280531): multiple modern-media-controls tests have become flaky timeouts
+        https://bugs.webkit.org/show_bug.cgi?id=228714
+        <rdar://problem/81426715>
+
+        Reviewed by Eric Carlson.
+
+        Update preferredRenderingMode() to reflect what setUpVideoRendering() actually does: use
+        MediaRenderingToContext whenever possible. This will cause setUpVideoRendering() to be
+        called from updateStates() to create the context, even if the element has been marked as
+        !isVisible() by RenderVideo upon removal from the DOM.
+
+        Also, in renderingModeChanged(), don't attempt to deduce whether scheduleUpdateStates()
+        should be called; just call it universally.
+
+        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
+        (WebCore::MediaPlayerPrivateAVFoundation::preferredRenderingMode const):
+        (WebCore::MediaPlayerPrivateAVFoundation::renderingModeChanged):
+
 2021-08-03  Kimmo Kinnunen  <kkinnunen@apple.com>
 

trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp

@@ -106 +106 @@
 MediaPlayerPrivateAVFoundation::MediaRenderingMode MediaPlayerPrivateAVFoundation::preferredRenderingMode() const
 {
-    if (!m_visible || assetStatus() == MediaPlayerAVAssetStatusUnknown)
+    if (assetStatus() == MediaPlayerAVAssetStatusUnknown)
         return MediaRenderingNone;
 
@@ -469 +469 @@
 void MediaPlayerPrivateAVFoundation::renderingModeChanged()
 {
-    if (m_delayingReadyState && m_cachedHasVideo && hasAvailableVideoFrame())
-        scheduleUpdateStates();
+    scheduleUpdateStates();
     m_player->renderingModeChanged();
 }