Changeset 280600 in webkit

Timestamp:

Aug 3, 2021, 10:05:15 AM (5 years ago)

Author:

youenn@apple.com

Message:

RealtimeMediaSource::audioSamplesAvailable is calling malloc as part of locking in audio thread
​https://bugs.webkit.org/show_bug.cgi?id=228688

Reviewed by Eric Carlson.

Allow allocations in lockSlow since allocations might happen in rare case and not for each lockSlow call.

• wtf/Lock.cpp:

(WTF::Lock::lockSlow):
(WTF::Lock::unlockSlow):
(WTF::Lock::unlockFairlySlow):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/Lock.cpp (modified) (3 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2021-08-03  Youenn Fablet  <youenn@apple.com>
+
+        RealtimeMediaSource::audioSamplesAvailable is calling malloc as part of locking in audio thread
+        https://bugs.webkit.org/show_bug.cgi?id=228688
+
+        Reviewed by Eric Carlson.
+
+        Allow allocations in lockSlow since allocations might happen in rare case and not for each lockSlow call.
+
+        * wtf/Lock.cpp:
+        (WTF::Lock::lockSlow):
+        (WTF::Lock::unlockSlow):
+        (WTF::Lock::unlockFairlySlow):
+
 2021-08-02  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WTF/wtf/Lock.cpp

@@ -44 +44 @@
     if (profileLockContention)
         STACK_SHOT_PROFILE(4, 2, 5);
+
+    // Heap allocations are forbidden on certain threads (e.g. audio rendering thread) for performance reasons so we need to
+    // explicitly allow the following allocation(s). In some rare cases, the lockSlow() algorithm may cause allocations.
+    DisableMallocRestrictionsForCurrentThreadScope disableMallocRestrictions;
+
     DefaultLockAlgorithm::lockSlow(m_byte);
 }
@@ -49 +54 @@
 void Lock::unlockSlow()
 {
-    // Heap allocations are forbidden on the certain threads (e.g. audio rendering thread) for performance reasons so we need to
-    // explicitly allow the following allocation(s). In some rare cases, the unlockSlow() algorith may cause allocations.
+    // Heap allocations are forbidden on certain threads (e.g. audio rendering thread) for performance reasons so we need to
+    // explicitly allow the following allocation(s). In some rare cases, the unlockSlow() algorithm may cause allocations.
     DisableMallocRestrictionsForCurrentThreadScope disableMallocRestrictions;
 
@@ -58 +63 @@
 void Lock::unlockFairlySlow()
 {
-    // Heap allocations are forbidden on the certain threads (e.g. audio rendering thread) for performance reasons so we need to
-    // explicitly allow the following allocation(s). In some rare cases, the unlockSlow() algorith may cause allocations.
+    // Heap allocations are forbidden on certain threads (e.g. audio rendering thread) for performance reasons so we need to
+    // explicitly allow the following allocation(s). In some rare cases, the unlockSlow() algorithm may cause allocations.
     DisableMallocRestrictionsForCurrentThreadScope disableMallocRestrictions;