⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 280610 in webkit


Ignore:
Timestamp:
Aug 3, 2021, 1:29:28 PM (5 years ago)
Author:
timothy_horton@apple.com
Message:

fast/dom/navigator-iOS-userAgent.html fails on iPad because the platform is not "iPhone" or "iPad"
​https://bugs.webkit.org/show_bug.cgi?id=228750

Reviewed by Dean Jackson.

  • fast/dom/navigator-iOS-userAgent.html:
  • platform/ipad/fast/dom/navigator-iOS-userAgent-expected.txt: Removed.

This test fails on iPad in the default configuration because navigator.platform is MacIntel
due to desktop-class browsing. To maintain previous behavior of the test, revert to mobile mode.
This lets us delete the iPad-specific results.
Also, fix a typo in the variable names.

Location:
trunk/LayoutTests
Files:
1 deleted
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r280608 r280610  
     12021-08-03  Tim Horton  <timothy_horton@apple.com>
     2
     3        fast/dom/navigator-iOS-userAgent.html fails on iPad because the platform is not "iPhone" or "iPad"
     4        https://bugs.webkit.org/show_bug.cgi?id=228750
     5
     6        Reviewed by Dean Jackson.
     7
     8        * fast/dom/navigator-iOS-userAgent.html:
     9        * platform/ipad/fast/dom/navigator-iOS-userAgent-expected.txt: Removed.
     10        This test fails on iPad in the default configuration because navigator.platform is MacIntel
     11        due to desktop-class browsing. To maintain previous behavior of the test, revert to mobile mode.
     12        This lets us delete the iPad-specific results.
     13        Also, fix a typo in the variable names.
     14
    1152021-08-03  Tim Horton  <timothy_horton@apple.com>
    216

  • trunk/LayoutTests/fast/dom/navigator-iOS-userAgent.html

    r188132 r280610  
    1 <html>
     1<html><!-- webkit-test-runner [ contentMode=mobile ] -->
    22<head>
    33<script src="../../resources/js-test-pre.js"></script>
    … …  
    1010
    1111var userAgent = navigator.userAgent;
    12 var isIPadUserAgent = userAgent.indexOf("Mozilla/5.0 (iPhone;") == 0;
    13 var isIPhoneUserAgent = userAgent.indexOf("Mozilla/5.0 (iPad;") == 0;
     12var isIPadUserAgent = userAgent.indexOf("Mozilla/5.0 (iPad;") == 0;
     13var isIPhoneUserAgent = userAgent.indexOf("Mozilla/5.0 (iPhone;") == 0;
    1414
    1515function test(str, condition) {
Note: See TracChangeset for help on using the changeset viewer.