⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 280611 in webkit


Ignore:
Timestamp:
Aug 3, 2021, 1:36:45 PM (5 years ago)
Author:
timothy_horton@apple.com
Message:

Remove unused processDidTransitionTo{Foreground,Background} IPC
​https://bugs.webkit.org/show_bug.cgi?id=228328

Reviewed by Wenson Hsieh.

  • GPUProcess/GPUProcess.cpp:

(WebKit::GPUProcess::processDidTransitionToForeground): Deleted.
(WebKit::GPUProcess::processDidTransitionToBackground): Deleted.

  • GPUProcess/GPUProcess.h:
  • GPUProcess/GPUProcess.messages.in:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::processDidTransitionToForeground): Deleted.
(WebKit::NetworkProcess::processDidTransitionToBackground): Deleted.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformProcessDidTransitionToBackground): Deleted.
(WebKit::NetworkProcess::platformProcessDidTransitionToForeground): Deleted.

  • NetworkProcess/curl/NetworkProcessCurl.cpp:

(WebKit::NetworkProcess::platformProcessDidTransitionToForeground): Deleted.
(WebKit::NetworkProcess::platformProcessDidTransitionToBackground): Deleted.

  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformProcessDidTransitionToForeground): Deleted.
(WebKit::NetworkProcess::platformProcessDidTransitionToBackground): Deleted.

  • UIProcess/GPU/GPUProcessProxy.cpp:

(WebKit::GPUProcessProxy::updateProcessAssertion):

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::updateProcessAssertion):

  • UIProcess/WebAuthentication/WebAuthnProcessProxy.cpp:

(WebKit::WebAuthnProcessProxy::updateProcessAssertion):

  • WebAuthnProcess/WebAuthnProcess.cpp:

(WebKit::WebAuthnProcess::processDidTransitionToForeground): Deleted.
(WebKit::WebAuthnProcess::processDidTransitionToBackground): Deleted.

  • WebAuthnProcess/WebAuthnProcess.h:
  • WebAuthnProcess/WebAuthnProcess.messages.in:

These messages do nothing.

Location:
trunk/Source/WebKit
Files:
16 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r280606 r280611  
     12021-08-03  Tim Horton  <timothy_horton@apple.com>
     2
     3        Remove unused processDidTransitionTo{Foreground,Background} IPC
     4        https://bugs.webkit.org/show_bug.cgi?id=228328
     5
     6        Reviewed by Wenson Hsieh.
     7
     8        * GPUProcess/GPUProcess.cpp:
     9        (WebKit::GPUProcess::processDidTransitionToForeground): Deleted.
     10        (WebKit::GPUProcess::processDidTransitionToBackground): Deleted.
     11        * GPUProcess/GPUProcess.h:
     12        * GPUProcess/GPUProcess.messages.in:
     13        * NetworkProcess/NetworkProcess.cpp:
     14        (WebKit::NetworkProcess::processDidTransitionToForeground): Deleted.
     15        (WebKit::NetworkProcess::processDidTransitionToBackground): Deleted.
     16        * NetworkProcess/NetworkProcess.h:
     17        * NetworkProcess/NetworkProcess.messages.in:
     18        * NetworkProcess/cocoa/NetworkProcessCocoa.mm:
     19        (WebKit::NetworkProcess::platformProcessDidTransitionToBackground): Deleted.
     20        (WebKit::NetworkProcess::platformProcessDidTransitionToForeground): Deleted.
     21        * NetworkProcess/curl/NetworkProcessCurl.cpp:
     22        (WebKit::NetworkProcess::platformProcessDidTransitionToForeground): Deleted.
     23        (WebKit::NetworkProcess::platformProcessDidTransitionToBackground): Deleted.
     24        * NetworkProcess/soup/NetworkProcessSoup.cpp:
     25        (WebKit::NetworkProcess::platformProcessDidTransitionToForeground): Deleted.
     26        (WebKit::NetworkProcess::platformProcessDidTransitionToBackground): Deleted.
     27        * UIProcess/GPU/GPUProcessProxy.cpp:
     28        (WebKit::GPUProcessProxy::updateProcessAssertion):
     29        * UIProcess/Network/NetworkProcessProxy.cpp:
     30        (WebKit::NetworkProcessProxy::updateProcessAssertion):
     31        * UIProcess/WebAuthentication/WebAuthnProcessProxy.cpp:
     32        (WebKit::WebAuthnProcessProxy::updateProcessAssertion):
     33        * WebAuthnProcess/WebAuthnProcess.cpp:
     34        (WebKit::WebAuthnProcess::processDidTransitionToForeground): Deleted.
     35        (WebKit::WebAuthnProcess::processDidTransitionToBackground): Deleted.
     36        * WebAuthnProcess/WebAuthnProcess.h:
     37        * WebAuthnProcess/WebAuthnProcess.messages.in:
     38        These messages do nothing.
     39
    1402021-08-03  Per Arne  <pvollan@apple.com>
    241

  • trunk/Source/WebKit/GPUProcess/GPUProcess.cpp

    r280416 r280611  
    276276}
    277277
    278 void GPUProcess::processDidTransitionToForeground()
    279 {
    280 }
    281 
    282 void GPUProcess::processDidTransitionToBackground()
    283 {
    284 }
    285 
    286278GPUConnectionToWebProcess* GPUProcess::webProcessConnection(ProcessIdentifier identifier) const
    287279{

  • trunk/Source/WebKit/GPUProcess/GPUProcess.h

    r280416 r280611  
    120120    void removeSession(PAL::SessionID);
    121121
    122     void processDidTransitionToForeground();
    123     void processDidTransitionToBackground();
    124122#if ENABLE(MEDIA_STREAM)
    125123    void setMockCaptureDevicesEnabled(bool);

  • trunk/Source/WebKit/GPUProcess/GPUProcess.messages.in

    r280416 r280611  
    2727
    2828    CreateGPUConnectionToWebProcess(WebCore::ProcessIdentifier processIdentifier, PAL::SessionID sessionID, struct WebKit::GPUProcessConnectionParameters parameters) -> (std::optional<IPC::Attachment> connectionIdentifier) Async
    29 
    30     ProcessDidTransitionToForeground()
    31     ProcessDidTransitionToBackground()
    3229
    3330    PrepareToSuspend(bool isSuspensionImminent) -> () Async

  • trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp

    r280110 r280611  
    21972197}
    21982198
    2199 void NetworkProcess::processDidTransitionToForeground()
    2200 {
    2201     platformProcessDidTransitionToForeground();
    2202 }
    2203 
    2204 void NetworkProcess::processDidTransitionToBackground()
    2205 {
    2206     platformProcessDidTransitionToBackground();
    2207 }
    2208 
    22092199void NetworkProcess::processWillSuspendImminentlyForTestingSync(CompletionHandler<void()>&& completionHandler)
    22102200{

  • trunk/Source/WebKit/NetworkProcess/NetworkProcess.h

    r280481 r280611  
    399399    void lowMemoryHandler(Critical);
    400400   
    401     void processDidTransitionToForeground();
    402     void processDidTransitionToBackground();
    403     void platformProcessDidTransitionToForeground();
    404     void platformProcessDidTransitionToBackground();
    405 
    406401    // AuxiliaryProcess
    407402    void initializeProcess(const AuxiliaryProcessInitializationParameters&) override;

  • trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in

    r279750 r280611  
    7070    SetCacheModel(enum:uint8_t WebKit::CacheModel cacheModel)
    7171    SetCacheModelSynchronouslyForTesting(enum:uint8_t WebKit::CacheModel cacheModel) -> () Synchronous
    72 
    73     ProcessDidTransitionToBackground()
    74     ProcessDidTransitionToForeground()
    7572
    7673    ProcessWillSuspendImminentlyForTestingSync() -> () Synchronous

  • trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm

    r280481 r280611  
    244244}
    245245
    246 void NetworkProcess::platformProcessDidTransitionToBackground()
    247 {
    248 }
    249 
    250 void NetworkProcess::platformProcessDidTransitionToForeground()
    251 {
    252 }
    253 
    254246} // namespace WebKit

  • trunk/Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp

    r267763 r280611  
    5656}
    5757
    58 void NetworkProcess::platformProcessDidTransitionToForeground()
    59 {
    60     notImplemented();
    61 }
    62 
    63 void NetworkProcess::platformProcessDidTransitionToBackground()
    64 {
    65     notImplemented();
    66 }
    67 
    6858void NetworkProcess::setNetworkProxySettings(PAL::SessionID sessionID, WebCore::CurlProxySettings&& settings)
    6959{

  • trunk/Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp

    r277967 r280611  
    172172}
    173173
    174 void NetworkProcess::platformProcessDidTransitionToForeground()
    175 {
    176     notImplemented();
    177 }
    178 
    179 void NetworkProcess::platformProcessDidTransitionToBackground()
    180 {
    181     notImplemented();
    182 }
    183 
    184174} // namespace WebKit

  • trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp

    r279912 r280611  
    432432        if (!ProcessThrottler::isValidForegroundActivity(m_activityFromWebProcesses)) {
    433433            m_activityFromWebProcesses = throttler().foregroundActivity("GPU for foreground view(s)"_s);
    434             send(Messages::GPUProcess::ProcessDidTransitionToForeground(), 0);
    435434        }
    436435        return;
    … …  
    439438        if (!ProcessThrottler::isValidBackgroundActivity(m_activityFromWebProcesses)) {
    440439            m_activityFromWebProcesses = throttler().backgroundActivity("GPU for background view(s)"_s);
    441             send(Messages::GPUProcess::ProcessDidTransitionToBackground(), 0);
    442440        }
    443441        return;

  • trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp

    r280247 r280611  
    15181518        if (!ProcessThrottler::isValidForegroundActivity(m_activityFromWebProcesses)) {
    15191519            m_activityFromWebProcesses = throttler().foregroundActivity("Networking for foreground view(s)"_s);
    1520             send(Messages::NetworkProcess::ProcessDidTransitionToForeground(), 0);
    15211520        }
    15221521        return;
    … …  
    15251524        if (!ProcessThrottler::isValidBackgroundActivity(m_activityFromWebProcesses)) {
    15261525            m_activityFromWebProcesses = throttler().backgroundActivity("Networking for background view(s)"_s);
    1527             send(Messages::NetworkProcess::ProcessDidTransitionToBackground(), 0);
    15281526        }
    15291527        return;

  • trunk/Source/WebKit/UIProcess/WebAuthentication/WebAuthnProcessProxy.cpp

    r275805 r280611  
    169169        if (!ProcessThrottler::isValidForegroundActivity(m_activityFromWebProcesses)) {
    170170            m_activityFromWebProcesses = throttler().foregroundActivity("WebAuthn for foreground view(s)"_s);
    171             send(Messages::WebAuthnProcess::ProcessDidTransitionToForeground(), 0);
    172171        }
    173172        return;
    … …  
    176175        if (!ProcessThrottler::isValidBackgroundActivity(m_activityFromWebProcesses)) {
    177176            m_activityFromWebProcesses = throttler().backgroundActivity("WebAuthn for background view(s)"_s);
    178             send(Messages::WebAuthnProcess::ProcessDidTransitionToBackground(), 0);
    179177        }
    180178        return;

  • trunk/Source/WebKit/WebAuthnProcess/WebAuthnProcess.cpp

    r278877 r280611  
    114114}
    115115
    116 void WebAuthnProcess::processDidTransitionToForeground()
    117 {
    118 }
    119 
    120 void WebAuthnProcess::processDidTransitionToBackground()
    121 {
    122 }
    123 
    124116WebAuthnConnectionToWebProcess* WebAuthnProcess::webProcessConnection(ProcessIdentifier identifier) const
    125117{

  • trunk/Source/WebKit/WebAuthnProcess/WebAuthnProcess.h

    r278877 r280611  
    8383    void createWebAuthnConnectionToWebProcess(WebCore::ProcessIdentifier, CompletionHandler<void(std::optional<IPC::Attachment>&&)>&&);
    8484
    85     void processDidTransitionToForeground();
    86     void processDidTransitionToBackground();
    87 
    8885    // Connections to WebProcesses.
    8986    HashMap<WebCore::ProcessIdentifier, Ref<WebAuthnConnectionToWebProcess>> m_webProcessConnections;

  • trunk/Source/WebKit/WebAuthnProcess/WebAuthnProcess.messages.in

    r278253 r280611  
    2929    # Creates a connection for communication with a WebProcess
    3030    CreateWebAuthnConnectionToWebProcess(WebCore::ProcessIdentifier processIdentifier) -> (std::optional<IPC::Attachment> connectionIdentifier) Async
    31 
    32     ProcessDidTransitionToForeground()
    33     ProcessDidTransitionToBackground()
    3431}
    3532
Note: See TracChangeset for help on using the changeset viewer.