Changeset 280614 in webkit

Timestamp:

Aug 3, 2021, 1:54:17 PM (5 years ago)

Author:

Russell Epstein

Message:

Cherry-pick r280589. rdar://problem/81471336

REGRESSION (r280531): multiple modern-media-controls tests have become flaky timeouts
​https://bugs.webkit.org/show_bug.cgi?id=228714
<rdar://problem/81426715>

Reviewed by Eric Carlson.

Update preferredRenderingMode() to reflect what setUpVideoRendering() actually does: use
MediaRenderingToContext whenever possible. This will cause setUpVideoRendering() to be
called from updateStates() to create the context, even if the element has been marked as
!isVisible() by RenderVideo upon removal from the DOM.

Also, in renderingModeChanged(), don't attempt to deduce whether scheduleUpdateStates()
should be called; just call it universally.

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::preferredRenderingMode const): (WebCore::MediaPlayerPrivateAVFoundation::renderingModeChanged):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@280589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-612.1-branch/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp (modified) (2 diffs)

branches/safari-612.1-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2021-08-03  Russell Epstein  <repstein@apple.com>
+
+        Cherry-pick r280589. rdar://problem/81471336
+
+    REGRESSION (r280531): multiple modern-media-controls tests have become flaky timeouts
+    https://bugs.webkit.org/show_bug.cgi?id=228714
+    <rdar://problem/81426715>
+    
+    Reviewed by Eric Carlson.
+    
+    Update preferredRenderingMode() to reflect what setUpVideoRendering() actually does: use
+    MediaRenderingToContext whenever possible. This will cause setUpVideoRendering() to be
+    called from updateStates() to create the context, even if the element has been marked as
+    !isVisible() by RenderVideo upon removal from the DOM.
+    
+    Also, in renderingModeChanged(), don't attempt to deduce whether scheduleUpdateStates()
+    should be called; just call it universally.
+    
+    * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
+    (WebCore::MediaPlayerPrivateAVFoundation::preferredRenderingMode const):
+    (WebCore::MediaPlayerPrivateAVFoundation::renderingModeChanged):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-08-03  Jer Noble  <jer.noble@apple.com>
+
+            REGRESSION (r280531): multiple modern-media-controls tests have become flaky timeouts
+            https://bugs.webkit.org/show_bug.cgi?id=228714
+            <rdar://problem/81426715>
+
+            Reviewed by Eric Carlson.
+
+            Update preferredRenderingMode() to reflect what setUpVideoRendering() actually does: use
+            MediaRenderingToContext whenever possible. This will cause setUpVideoRendering() to be
+            called from updateStates() to create the context, even if the element has been marked as
+            !isVisible() by RenderVideo upon removal from the DOM.
+
+            Also, in renderingModeChanged(), don't attempt to deduce whether scheduleUpdateStates()
+            should be called; just call it universally.
+
+            * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
+            (WebCore::MediaPlayerPrivateAVFoundation::preferredRenderingMode const):
+            (WebCore::MediaPlayerPrivateAVFoundation::renderingModeChanged):
+
 2021-08-03  Russell Epstein  <repstein@apple.com>
 

branches/safari-612.1-branch/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp

@@ -106 +106 @@
 MediaPlayerPrivateAVFoundation::MediaRenderingMode MediaPlayerPrivateAVFoundation::preferredRenderingMode() const
 {
-    if (!m_visible || assetStatus() == MediaPlayerAVAssetStatusUnknown)
+    if (assetStatus() == MediaPlayerAVAssetStatusUnknown)
         return MediaRenderingNone;
 
@@ -469 +469 @@
 void MediaPlayerPrivateAVFoundation::renderingModeChanged()
 {
-    if (m_delayingReadyState && m_cachedHasVideo && hasAvailableVideoFrame())
-        scheduleUpdateStates();
+    scheduleUpdateStates();
     m_player->renderingModeChanged();
 }