Changeset 280648 in webkit

Timestamp:

Aug 4, 2021, 11:55:25 AM (5 years ago)

Author:

Devin Rousso

Message:

REGRESSION(?): subtitle text sizing is sometimes inconsistent
​https://bugs.webkit.org/show_bug.cgi?id=228786
<rdar://problem/80525509>

Reviewed by Eric Carlson.

Tested manually. I'm still not 100% sure of the root cause of this, but after talking with
some folks more familiar with WebKit's media "stack" it seems like this only happens with
in-band non-VTT subtitle tracks that have their own styling. The fix is also pretty obvious.

• html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGeneric::setFontSize):
We should still pass along the new font size (and bool important) even if we don't have a
display tree yet, as the font size (and bool important) are used when the display tree is
created, meaning that we shouldn't have to wait for another setFontSize call after the
display tree is created in order to update the font size.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/track/TextTrackCueGeneric.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-08-04  Devin Rousso  <drousso@apple.com>
+
+        REGRESSION(?): subtitle text sizing is sometimes inconsistent
+        https://bugs.webkit.org/show_bug.cgi?id=228786
+        <rdar://problem/80525509>
+
+        Reviewed by Eric Carlson.
+
+        Tested manually. I'm still not 100% sure of the root cause of this, but after talking with
+        some folks more familiar with WebKit's media "stack" it seems like this only happens with
+        in-band non-VTT subtitle tracks that have their own styling. The fix is also pretty obvious.
+
+        * html/track/TextTrackCueGeneric.cpp:
+        (WebCore::TextTrackCueGeneric::setFontSize):
+        We should still pass along the new font size (and `bool important`) even if we don't have a
+        display tree yet, as the font size (and `bool important`) are used when the display tree is
+        created, meaning that we shouldn't have to wait for another `setFontSize` call after the
+        display tree is created in order to update the font size.
+
 2021-08-04  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/html/track/TextTrackCueGeneric.cpp

@@ -195 +195 @@
 void TextTrackCueGeneric::setFontSize(int fontSize, const IntSize& videoSize, bool important)
 {
-    if (!hasDisplayTree() || !fontSize)
+    if (!fontSize)
         return;
     
-    if (important || !baseFontSizeRelativeToVideoHeight()) {
+    if (important || !hasDisplayTree() || !baseFontSizeRelativeToVideoHeight()) {
         VTTCue::setFontSize(fontSize, videoSize, important);
         return;