⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 280649 in webkit


Ignore:
Timestamp:
Aug 4, 2021, 11:59:03 AM (5 years ago)
Author:
Chris Dumez
Message:

REGRESSION (r280541): [ BigSur Debug ] accessibility/roles-computedRoleString.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=228744
<rdar://problem/81472432>

Unreviewed, the test's JS was getting in some sort of infinite loop. Tweak the code a bit
so that it keeps running without infinite looping.

  • accessibility/roles-computedRoleString.html:
  • platform/mac/TestExpectations:
  • platform/mac/accessibility/roles-computedRoleString-expected.txt:
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r280646 r280649  
     12021-08-04  Chris Dumez  <cdumez@apple.com>
     2
     3        REGRESSION (r280541): [ BigSur Debug ] accessibility/roles-computedRoleString.html is timing out
     4        https://bugs.webkit.org/show_bug.cgi?id=228744
     5        <rdar://problem/81472432>
     6
     7        Unreviewed, the test's JS was getting in some sort of infinite loop. Tweak the code a bit
     8        so that it keeps running without infinite looping.
     9
     10        * accessibility/roles-computedRoleString.html:
     11        * platform/mac/TestExpectations:
     12        * platform/mac/accessibility/roles-computedRoleString-expected.txt:
     13
    1142021-08-04  Commit Queue  <commit-queue@webkit.org>
    215

  • trunk/LayoutTests/accessibility/roles-computedRoleString.html

    r279829 r280649  
    343343        matchedResults = (computedAriaRole == expectedRole)
    344344
    345         result = document.getElementById('console');
    346         if (matchedResults) {
    347             result.innerText += "PASS: " + output + "\n";
    348         } else {
    349             result.innerText += "FAIL: " + output + "Expected: " + expectation + ".\n";
    350         }
     345        if (matchedResults)
     346            testPassed(output);
     347        else
     348            testFailed(output + "Expected: " + expectation);
    351349    }
    352350

  • trunk/LayoutTests/platform/mac/TestExpectations

    r280636 r280649  
    15741574webkit.org/b/205403 accessibility/presentation-role-iframe.html [ Pass Failure ]
    15751575
    1576 webkit.org/b/228744 [ BigSur+ Debug ] accessibility/roles-computedRoleString.html [ Timeout ]
    1577 
    15781576# Disabled temporarily since it is causing other tests to fail.
    15791577accessibility/mac/isolated-tree-mode-on-off.html [ Skip ]

  • trunk/LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt

    r279829 r280649  
    44
    55
    6 PASS: a[href] -> link.
    7 PASS: article -> article.
    8 PASS: aside -> complementary.
    9 PASS: button -> button.
    10 PASS: del -> deletion.
    11 PASS: dfn -> definition.
    12 PASS: dl -> .
    13 PASS: footer -> contentinfo.
    14 PASS: form -> form.
    15 PASS: header -> banner.
    16 PASS: h1 -> heading.
    17 PASS: h2 -> heading.
    18 PASS: h3 -> heading.
    19 PASS: h4 -> heading.
    20 PASS: h5 -> heading.
    21 PASS: h5 -> heading.
    22 PASS: hr -> separator.
    23 PASS: img[alt='X'] -> image.
    24 PASS: input[type='button'] -> button.
    25 PASS: input[type='checkbox'] -> checkbox.
    26 PASS: input[type='date'] -> .
    27 PASS: input[type='datetime'] -> .
    28 PASS: input[type='datetime-local'] -> .
    29 PASS: input[type='email'] -> .
    30 PASS: input[type='file'] -> button.
    31 PASS: input[type='image'] -> button.
    32 PASS: input[type='month'] -> .
    33 PASS: input[type='number'] -> .
    34 PASS: input[type='password'] -> .
    35 PASS: input[type='radio'] -> radio.
    36 PASS: input[type='range'] -> slider.
    37 PASS: input[type='reset'] -> button.
    38 PASS: input[type='search'] -> searchbox.
    39 PASS: input[type='submit'] -> button.
    40 PASS: input[type='tel'] -> .
    41 PASS: input[type='text'] -> .
    42 PASS: input[type='time'] -> .
    43 PASS: input[type='url'] -> .
    44 PASS: input[type='week'] -> .
    45 PASS: ins -> insertion.
    46 PASS: mark -> .
    47 PASS: math -> math.
    48 PASS: meter -> meter.
    49 PASS: nav -> navigation.
    50 PASS: ol -> list.
    51 PASS: li -> listitem.
    52 PASS: p -> paragraph.
    53 PASS: pre -> .
    54 PASS: progress -> progressbar.
    55 PASS: samp -> .
    56 PASS: section:not([aria-label]:not([aria-labelledby]) -> .
    57 PASS: section[aria-label] -> region.
    58 PASS: section[aria-labelledby] -> region.
    59 PASS: select:not([multiple]) -> button.
    60 PASS: select[multiple] -> listbox.
    61 PASS: option -> option.
    62 PASS: optgroup -> option.
    63 PASS: option -> option.
    64 PASS: option -> option.
    65 PASS: sub -> subscript.
    66 PASS: sup -> superscript.
    67 PASS: table -> table.
    68 PASS: tr -> row.
    69 PASS: th -> columnheader.
    70 PASS: tr -> row.
    71 PASS: td -> cell.
    72 PASS: tr -> row.
    73 PASS: td -> cell.
    74 PASS: table[role="grid"] -> grid.
    75 PASS: tr -> row.
    76 PASS: th -> columnheader.
    77 PASS: tr -> row.
    78 PASS: td[role="gridcell"] -> gridcell.
    79 PASS: tr -> row.
    80 PASS: td[role="gridcell"] -> gridcell.
    81 PASS: textarea -> textbox.
    82 PASS: time -> time.
    83 PASS: ul -> list.
    84 PASS: li -> listitem.
    85 PASS: var -> .
    86 PASS: div[role="command"] -> .
    87 PASS: div[role="composite"] -> .
    88 PASS: div[role="input"] -> .
    89 PASS: div[role="landmark"] -> .
    90 PASS: div[role="range"] -> .
    91 PASS: div[role="roletype"] -> .
    92 PASS: div[role="section"] -> .
    93 PASS: div[role="sectionhead"] -> .
    94 PASS: div[role="select"] -> .
    95 PASS: div[role="structure"] -> .
    96 PASS: div[role="widget"] -> .
    97 PASS: div[role="window"] -> .
    98 PASS: div[role="alert"] -> alert.
    99 PASS: div[role="alertdialog"] -> alertdialog.
    100 PASS: div[role="application"] -> application.
    101 PASS: div[role="article"] -> article.
    102 PASS: div[role="banner"] -> banner.
    103 PASS: div[role="blockquote"] -> blockquote.
    104 PASS: div[role="button"] -> button.
    105 PASS: div[role="caption"] -> caption.
    106 PASS: div[role="checkbox"] -> checkbox.
    107 PASS: div[role="combobox"] -> combobox.
    108 PASS: div[role="complementary"] -> complementary.
    109 PASS: div[role="contentinfo"] -> contentinfo.
    110 PASS: div[role="definition"] -> definition.
    111 PASS: div[role="deletion"] -> deletion.
    112 PASS: div[role="dialog"] -> dialog.
    113 PASS: div[role="directory"] -> list.
    114 PASS: div[role="document"] -> document.
    115 PASS: div[role="figure"] -> figure.
    116 PASS: div[role="form"] -> form.
    117 PASS: div[role="graphics-document"] -> document.
    118 PASS: div[role="graphics-object"] -> group.
    119 PASS: div[role="graphics-symbol"] -> image.
    120 PASS: div[role="grid"] -> grid.
    121 PASS: div[role="row"] -> row.
    122 PASS: div[role="rowheader"] -> rowheader.
    123 PASS: div[role="columnheader"] -> columnheader.
    124 PASS: div[role="gridcell"] -> gridcell.
    125 PASS: div[role="feed"] -> feed.
    126 PASS: div[role="group"] -> group.
    127 PASS: div[role="heading"] -> heading.
    128 PASS: div[role="img"] -> image.
    129 PASS: div[role="insertion"] -> insertion.
    130 PASS: div[role="link"] -> link.
    131 PASS: div[role="list"] -> list.
    132 PASS: div[role="listitem"] -> listitem.
    133 PASS: div[role="listbox"] -> listbox.
    134 PASS: div[role="option"] -> option.
    135 PASS: div[role="log"] -> log.
    136 PASS: div[role="main"] -> main.
    137 PASS: div[role="marquee"] -> marquee.
    138 PASS: div[role="math"] -> math.
    139 PASS: div[role="menu"] -> menu.
    140 PASS: div[role="menuitem"] -> menuitem.
    141 PASS: div[role="menuitemcheckbox"] -> menuitemcheckbox.
    142 PASS: div[role="menuitemradio"] -> menuitemradio.
    143 PASS: div[role="menubar"] -> menubar.
    144 PASS: div[role="menuitem"] -> menuitem.
    145 PASS: div[role="menuitemcheckbox"] -> menuitemcheckbox.
    146 PASS: div[role="menuitemradio"] -> menuitemradio.
    147 PASS: div[role="meter"] -> meter.
    148 PASS: div[role="navigation"] -> navigation.
    149 PASS: div[role="note"] -> note.
    150 PASS: div[role="paragraph"] -> paragraph.
    151 PASS: div[role="progressbar"] -> progressbar.
    152 PASS: div[role="radiogroup"] -> radiogroup.
    153 PASS: div[role="radio"] -> radio.
    154 PASS: div[role="region"]:not([aria-label]:not([aria-labelledby]) -> .
    155 PASS: div[role="region"][aria-label] -> region.
    156 PASS: div[role="region"][aria-labelledby] -> region.
    157 PASS: div[role="scrollbar"] -> scrollbar.
    158 PASS: div[role="search"] -> search.
    159 PASS: div[role="separator"] -> separator.
    160 PASS: div[role="slider"] -> slider.
    161 PASS: div[role="spinbutton"] -> spinbutton.
    162 PASS: div[role="status"] -> status.
    163 PASS: div[role="subscript"] -> subscript.
    164 PASS: div[role="superscript"] -> superscript.
    165 PASS: div[role="tablist"] -> tablist.
    166 PASS: div[role="tab"] -> tab.
    167 PASS: div[role="tabpanel"] -> tabpanel.
    168 PASS: div[role="textbox"] -> .
    169 PASS: div[role="term"] -> term.
    170 PASS: div[role="time"] -> time.
    171 PASS: div[role="timer"] -> timer.
    172 PASS: div[role="toolbar"] -> toolbar.
    173 PASS: div[role="tooltip"] -> tooltip.
    174 PASS: div[role="tree"] -> tree.
    175 PASS: div[role="treeitem"] -> treeitem.
    176 PASS: div[role="treeitem"] -> treeitem.
    177 PASS: div[role="treegrid"] -> treegrid.
    178 PASS: div[role="row"] -> row.
    179 PASS: div[role="rowheader"] -> rowheader.
    180 PASS: div[role="columnheader"] -> columnheader.
    181 PASS: div[role="gridcell"] -> gridcell.
    182 PASS: div[role="button foo"] -> button.
    183 PASS: div[role="foo button bar"] -> button.
    184 PASS: div[role="foo  button  bar"] -> button.
    185 PASS: div[role="foo     button  bar"] -> .
    186 PASS: div[role="foo
     6PASS a[href] -> link.
     7PASS article -> article.
     8PASS aside -> complementary.
     9PASS button -> button.
     10PASS del -> deletion.
     11PASS dfn -> definition.
     12PASS dl -> .
     13PASS footer -> contentinfo.
     14PASS form -> form.
     15PASS header -> banner.
     16PASS h1 -> heading.
     17PASS h2 -> heading.
     18PASS h3 -> heading.
     19PASS h4 -> heading.
     20PASS h5 -> heading.
     21PASS h5 -> heading.
     22PASS hr -> separator.
     23PASS img[alt='X'] -> image.
     24PASS input[type='button'] -> button.
     25PASS input[type='checkbox'] -> checkbox.
     26PASS input[type='date'] -> .
     27PASS input[type='datetime'] -> .
     28PASS input[type='datetime-local'] -> .
     29PASS input[type='email'] -> .
     30PASS input[type='file'] -> button.
     31PASS input[type='image'] -> button.
     32PASS input[type='month'] -> .
     33PASS input[type='number'] -> .
     34PASS input[type='password'] -> .
     35PASS input[type='radio'] -> radio.
     36PASS input[type='range'] -> slider.
     37PASS input[type='reset'] -> button.
     38PASS input[type='search'] -> searchbox.
     39PASS input[type='submit'] -> button.
     40PASS input[type='tel'] -> .
     41PASS input[type='text'] -> .
     42PASS input[type='time'] -> .
     43PASS input[type='url'] -> .
     44PASS input[type='week'] -> .
     45PASS ins -> insertion.
     46PASS mark -> .
     47PASS math -> math.
     48PASS meter -> meter.
     49PASS nav -> navigation.
     50PASS ol -> list.
     51PASS li -> listitem.
     52PASS p -> paragraph.
     53PASS pre -> .
     54PASS progress -> progressbar.
     55PASS samp -> .
     56PASS section:not([aria-label]:not([aria-labelledby]) -> .
     57PASS section[aria-label] -> region.
     58PASS section[aria-labelledby] -> region.
     59PASS select:not([multiple]) -> button.
     60PASS select[multiple] -> listbox.
     61PASS option -> option.
     62PASS optgroup -> option.
     63PASS option -> option.
     64PASS option -> option.
     65PASS sub -> subscript.
     66PASS sup -> superscript.
     67PASS table -> table.
     68PASS tr -> row.
     69PASS th -> columnheader.
     70PASS tr -> row.
     71PASS td -> cell.
     72PASS tr -> row.
     73PASS td -> cell.
     74PASS table[role="grid"] -> grid.
     75PASS tr -> row.
     76PASS th -> columnheader.
     77PASS tr -> row.
     78PASS td[role="gridcell"] -> gridcell.
     79PASS tr -> row.
     80PASS td[role="gridcell"] -> gridcell.
     81PASS textarea -> textbox.
     82PASS time -> time.
     83PASS ul -> list.
     84PASS li -> listitem.
     85PASS var -> .
     86PASS div[role="command"] -> .
     87PASS div[role="composite"] -> .
     88PASS div[role="input"] -> .
     89PASS div[role="landmark"] -> .
     90PASS div[role="range"] -> .
     91PASS div[role="roletype"] -> .
     92PASS div[role="section"] -> .
     93PASS div[role="sectionhead"] -> .
     94PASS div[role="select"] -> .
     95PASS div[role="structure"] -> .
     96PASS div[role="widget"] -> .
     97PASS div[role="window"] -> .
     98PASS div[role="alert"] -> alert.
     99PASS div[role="alertdialog"] -> alertdialog.
     100PASS div[role="application"] -> application.
     101PASS div[role="article"] -> article.
     102PASS div[role="banner"] -> banner.
     103PASS div[role="blockquote"] -> blockquote.
     104PASS div[role="button"] -> button.
     105PASS div[role="caption"] -> caption.
     106PASS div[role="checkbox"] -> checkbox.
     107PASS div[role="combobox"] -> combobox.
     108PASS div[role="complementary"] -> complementary.
     109PASS div[role="contentinfo"] -> contentinfo.
     110PASS div[role="definition"] -> definition.
     111PASS div[role="deletion"] -> deletion.
     112PASS div[role="dialog"] -> dialog.
     113PASS div[role="directory"] -> list.
     114PASS div[role="document"] -> document.
     115PASS div[role="figure"] -> figure.
     116PASS div[role="form"] -> form.
     117PASS div[role="graphics-document"] -> document.
     118PASS div[role="graphics-object"] -> group.
     119PASS div[role="graphics-symbol"] -> image.
     120PASS div[role="grid"] -> grid.
     121PASS div[role="row"] -> row.
     122PASS div[role="rowheader"] -> rowheader.
     123PASS div[role="columnheader"] -> columnheader.
     124PASS div[role="gridcell"] -> gridcell.
     125PASS div[role="feed"] -> feed.
     126PASS div[role="group"] -> group.
     127PASS div[role="heading"] -> heading.
     128PASS div[role="img"] -> image.
     129PASS div[role="insertion"] -> insertion.
     130PASS div[role="link"] -> link.
     131PASS div[role="list"] -> list.
     132PASS div[role="listitem"] -> listitem.
     133PASS div[role="listbox"] -> listbox.
     134PASS div[role="option"] -> option.
     135PASS div[role="log"] -> log.
     136PASS div[role="main"] -> main.
     137PASS div[role="marquee"] -> marquee.
     138PASS div[role="math"] -> math.
     139PASS div[role="menu"] -> menu.
     140PASS div[role="menuitem"] -> menuitem.
     141PASS div[role="menuitemcheckbox"] -> menuitemcheckbox.
     142PASS div[role="menuitemradio"] -> menuitemradio.
     143PASS div[role="menubar"] -> menubar.
     144PASS div[role="menuitem"] -> menuitem.
     145PASS div[role="menuitemcheckbox"] -> menuitemcheckbox.
     146PASS div[role="menuitemradio"] -> menuitemradio.
     147PASS div[role="meter"] -> meter.
     148PASS div[role="navigation"] -> navigation.
     149PASS div[role="note"] -> note.
     150PASS div[role="paragraph"] -> paragraph.
     151PASS div[role="progressbar"] -> progressbar.
     152PASS div[role="radiogroup"] -> radiogroup.
     153PASS div[role="radio"] -> radio.
     154PASS div[role="region"]:not([aria-label]:not([aria-labelledby]) -> .
     155PASS div[role="region"][aria-label] -> region.
     156PASS div[role="region"][aria-labelledby] -> region.
     157PASS div[role="scrollbar"] -> scrollbar.
     158PASS div[role="search"] -> search.
     159PASS div[role="separator"] -> separator.
     160PASS div[role="slider"] -> slider.
     161PASS div[role="spinbutton"] -> spinbutton.
     162PASS div[role="status"] -> status.
     163PASS div[role="subscript"] -> subscript.
     164PASS div[role="superscript"] -> superscript.
     165PASS div[role="tablist"] -> tablist.
     166PASS div[role="tab"] -> tab.
     167PASS div[role="tabpanel"] -> tabpanel.
     168PASS div[role="textbox"] -> .
     169PASS div[role="term"] -> term.
     170PASS div[role="time"] -> time.
     171PASS div[role="timer"] -> timer.
     172PASS div[role="toolbar"] -> toolbar.
     173PASS div[role="tooltip"] -> tooltip.
     174PASS div[role="tree"] -> tree.
     175PASS div[role="treeitem"] -> treeitem.
     176PASS div[role="treeitem"] -> treeitem.
     177PASS div[role="treegrid"] -> treegrid.
     178PASS div[role="row"] -> row.
     179PASS div[role="rowheader"] -> rowheader.
     180PASS div[role="columnheader"] -> columnheader.
     181PASS div[role="gridcell"] -> gridcell.
     182PASS div[role="button foo"] -> button.
     183PASS div[role="foo button bar"] -> button.
     184PASS div[role="foo  button  bar"] -> button.
     185PASS div[role="foo      button  bar"] -> .
     186PASS div[role="foo
    187187button
    188188bar"] -> .
    189 PASS: img[role="foo"] -> image.
    190 PASS: img[role="foo bar"] -> image.
    191 PASS: img[role="foo  bar"] -> image.
    192 PASS: img[role="foo     bar"] -> image.
    193 PASS: img[role="foo     
     189PASS img[role="foo"] -> image.
     190PASS img[role="foo bar"] -> image.
     191PASS img[role="foo  bar"] -> image.
     192PASS img[role="foo      bar"] -> image.
     193PASS img[role="foo     
    194194bar"] -> image.
    195 PASS: img[role="text"] -> text.
    196 PASS: img[role="text img"] -> text.
    197 PASS: img[role="img text"] -> image.
    198 PASS: img[role="presentation"][aria-label] -> image.
    199 PASS: a[role="foo bar"] -> link.
     195PASS img[role="text"] -> text.
     196PASS img[role="text img"] -> text.
     197PASS img[role="img text"] -> image.
     198PASS img[role="presentation"][aria-label] -> image.
     199PASS a[role="foo bar"] -> link.
    200200PASS successfullyParsed is true
    201201
Note: See TracChangeset for help on using the changeset viewer.