Changeset 280652 in webkit

Timestamp:

Aug 4, 2021, 12:43:00 PM (5 years ago)

Author:

Said Abou-Hallawa

Message:

[GPUProcess] REGRESSION: A noticeable slow down when browsing Live Photos album on iCloud.com
​https://bugs.webkit.org/show_bug.cgi?id=228673
<rdar://81353138>

Reviewed by Wenson Hsieh.

RemoteImageBufferProxy::flushDrawingContext() assumes a FlushContext item
is always appended to its DisplayList when it calls flushDrawingContextAsync()
and this is why it waits up to 3 seconds for the DidFlush message. But this
does not happen if the DisplayList of RemoteImageBufferProxy is empty.

In addition to checking whether the DisplayList is empty, we can check also
whether we do not have pending a FlushContext item before appending a new
one.

• WebProcess/GPU/graphics/RemoteImageBufferProxy.h:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/GPU/graphics/RemoteImageBufferProxy.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-08-04  Said Abou-Hallawa  <said@apple.com>
+
+        [GPUProcess] REGRESSION: A noticeable slow down when browsing Live Photos album on iCloud.com
+        https://bugs.webkit.org/show_bug.cgi?id=228673
+        <rdar://81353138>
+
+        Reviewed by Wenson Hsieh.
+
+        RemoteImageBufferProxy::flushDrawingContext() assumes a FlushContext item
+        is always appended to its DisplayList when it calls flushDrawingContextAsync()
+        and this is why it waits up to 3 seconds for the DidFlush message. But this
+        does not happen if the DisplayList of RemoteImageBufferProxy is empty.
+
+        In addition to checking whether the DisplayList is empty, we can check also
+        whether we do not have pending a FlushContext item before appending a new
+        one.
+
+        * WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
+
 2021-08-04  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h

@@ -261 +261 @@
             return;
 
-        if (!m_drawingContext.displayList().isEmpty()) {
+        if (!m_drawingContext.displayList().isEmpty() || !hasPendingFlush()) {
             m_sentFlushIdentifier = WebCore::DisplayList::FlushIdentifier::generate();
             m_drawingContext.recorder().flushContext(m_sentFlushIdentifier);